{"id":19695,"url":"https://patchwork.libcamera.org/api/1.1/patches/19695/?format=json","web_url":"https://patchwork.libcamera.org/patch/19695/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240313105645.120317-8-stefan.klug@ideasonboard.com>","date":"2024-03-13T10:56:39","name":"[07/12] libcamera: delayed_controls: Add some logging","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5003502376ae5e72c51af0131a6ff120c896aad5","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19695/mbox/","series":[{"id":4219,"url":"https://patchwork.libcamera.org/api/1.1/series/4219/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4219","date":"2024-03-13T10:56:32","name":"Preparation for per-frame-controls and initial tests","version":1,"mbox":"https://patchwork.libcamera.org/series/4219/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19695/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19695/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09B18C32C3\n\tfor ;\n\tWed, 13 Mar 2024 10:57:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E8E462C80;\n\tWed, 13 Mar 2024 11:57:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28BD36294A\n\tfor ;\n\tWed, 13 Mar 2024 11:56:54 +0100 (CET)","from jasper.fritz.box (unknown\n\t[IPv6:2a00:6020:448c:6c00:9b07:31b5:38e1:e957])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AEC98899;\n\tWed, 13 Mar 2024 11:56:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"heWHkB3M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710327391;\n\tbh=eqDcYzYC3IRHoBLNUgYxis11DNDgStZM920gWGOcno8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=heWHkB3Mf0YWQZgT+KXqKdJ/EjZdTSoycc7G5aPMlqcwIiWB6np9JdE7OkCvU1y5a\n\tqlGzNTcXoCvaQL9p/h3pfmBTbCRkMI5r4+dg8MXPmDjebyiq/MEH9wvE2CZLSCh9C+\n\tcfTFjqZTxsZ0Ta/hjQnmA/vbQ+1sK9uxhK1liJKs=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 07/12] libcamera: delayed_controls: Add some logging","Date":"Wed, 13 Mar 2024 11:56:39 +0100","Message-Id":"<20240313105645.120317-8-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","In-Reply-To":"<20240313105645.120317-1-stefan.klug@ideasonboard.com>","References":"<20240313105645.120317-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This replaces changes the log output to a more compact form.\nThere might be different opinions on that one\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/delayed_controls.cpp | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\nindex 59314388..c46e54d1 100644\n--- a/src/libcamera/delayed_controls.cpp\n+++ b/src/libcamera/delayed_controls.cpp\n@@ -104,6 +104,8 @@ DelayedControls::DelayedControls(V4L2Device *device,\n \t\tmaxDelay_ = std::max(maxDelay_, controlParams_[id].delay);\n \t}\n \n+\tLOG(DelayedControls, Debug) << \"Maximum delay: \" << maxDelay_;\n+\n \treset();\n }\n \n@@ -212,6 +214,14 @@ bool DelayedControls::push(const ControlList &controls)\n \n bool DelayedControls::pushForFrame(uint32_t sequence, const ControlList &controls)\n {\n+\tLOG(DelayedControls, Debug) << \"push: \" << sequence;\n+\tauto idMap = controls.idMap();\n+\tif (idMap) {\n+\t\tfor (const auto &[id, value] : controls) {\n+\t\t\tLOG(DelayedControls, Debug) << \" \" << idMap->at(id)->name() << \" : \" << value.toString();\n+\t\t}\n+\t}\n+\n \tif (sequence < queueIndex_) {\n \t\tLOG(DelayedControls, Debug) << \"Got updated data for frame:\" << sequence;\n \t}\n@@ -320,6 +330,7 @@ bool DelayedControls::pushForFrame(uint32_t sequence, const ControlList &control\n */\n ControlList DelayedControls::get(uint32_t sequence)\n {\n+\tLOG(DelayedControls, Debug) << \"get \" << sequence << \":\";\n \tControlList out(device_->controls());\n \tfor (const auto &ctrl : values_) {\n \t\tconst ControlId *id = ctrl.first;\n@@ -328,9 +339,8 @@ ControlList DelayedControls::get(uint32_t sequence)\n \t\tout.set(id->id(), info);\n \n \t\tLOG(DelayedControls, Debug)\n-\t\t\t<< \"Reading \" << id->name()\n-\t\t\t<< \" to \" << info.toString()\n-\t\t\t<< \" at index \" << sequence;\n+\t\t\t<< \" \" << id->name()\n+\t\t\t<< \": \" << info.toString();\n \t}\n \n \treturn out;\n","prefixes":["07/12"]}