{"id":19653,"url":"https://patchwork.libcamera.org/api/1.1/patches/19653/?format=json","web_url":"https://patchwork.libcamera.org/patch/19653/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240310143023.752559-2-pobrn@protonmail.com>","date":"2024-03-10T14:30:33","name":"[v2,1/3] libcamera: framebuffer_allocator: Move from argument in constructor","commit_ref":"443734023c1c953a3e4d0f3404b0d054f2449d99","pull_url":null,"state":"accepted","archived":false,"hash":"37a3443489cc84108b919be633f1b0feb4724900","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/1.1/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19653/mbox/","series":[{"id":4209,"url":"https://patchwork.libcamera.org/api/1.1/series/4209/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4209","date":"2024-03-10T14:30:38","name":"couple FrameBufferAllocator changes","version":2,"mbox":"https://patchwork.libcamera.org/series/4209/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19653/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19653/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEE33BD160\n\tfor ;\n\tSun, 10 Mar 2024 14:30:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 837EB6286F;\n\tSun, 10 Mar 2024 15:30:52 +0100 (CET)","from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2613462973\n\tfor ;\n\tSun, 10 Mar 2024 15:30:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"kGUDemr6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1710081050; x=1710340250;\n\tbh=aWQhyjRoCHcfdYy792f/KmWzWIHqSdZBpbElcK0Sb5o=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=kGUDemr6fNj/4PHGPD4bF5N2teDFy8+HvuG4efdWFWO6k5Vh9Xohvv7UnpErAJnxY\n\t4HhFvK5tuwF4mS9+rjhgbfg8yAu+l0ik7koNe/e0QcBeViFTpuBwRs7o0rNYqi/t3h\n\tR9AjYffwGU7Btj7X6ZK2D/nKDFhX8MKv/HzFKQjZh3DRnpKm5Hdrvj64n+wk5QRwnk\n\tMwzlFTeONak8YGZI0cXquclSe4YAcZTrEeSfp/Su6jXsNP/eyyAYzF4rJqEym5TbEq\n\tyk4ok1Dy9jor6jjpiqp3Vj/KPGswxKBh2SdphbIVoeEHrraZr7OsEZJ6ykhqEzAeqr\n\tNVeFXaBbryibg==","Date":"Sun, 10 Mar 2024 14:30:33 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v2 1/3] libcamera: framebuffer_allocator: Move from argument\n\tin constructor","Message-ID":"<20240310143023.752559-2-pobrn@protonmail.com>","In-Reply-To":"<20240310143023.752559-1-pobrn@protonmail.com>","References":"<20240310143023.752559-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The single argument, of type `std::shared_ptr`,\nis passed by value, so it can simply be moved from in order to\navoid calling the copy constructor.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/framebuffer_allocator.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp\nindex 94389735..8cf45ab2 100644\n--- a/src/libcamera/framebuffer_allocator.cpp\n+++ b/src/libcamera/framebuffer_allocator.cpp\n@@ -59,7 +59,7 @@ LOG_DEFINE_CATEGORY(Allocator)\n * \\param[in] camera The camera\n */\n FrameBufferAllocator::FrameBufferAllocator(std::shared_ptr camera)\n-\t: camera_(camera)\n+\t: camera_(std::move(camera))\n {\n }\n \n","prefixes":["v2","1/3"]}