{"id":19648,"url":"https://patchwork.libcamera.org/api/1.1/patches/19648/?format=json","web_url":"https://patchwork.libcamera.org/patch/19648/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240310012946.727641-3-pobrn@protonmail.com>","date":"2024-03-10T01:29:59","name":"[v1,2/3] libcamera: framebuffer_allocator: use default destructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"43a1ed822fd46ef0d1d19e20f2d868d1c2874023","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/1.1/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19648/mbox/","series":[{"id":4208,"url":"https://patchwork.libcamera.org/api/1.1/series/4208/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4208","date":"2024-03-10T01:29:49","name":"couple FrameBufferAllocator changes","version":1,"mbox":"https://patchwork.libcamera.org/series/4208/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19648/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19648/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21BBBC32A3\n\tfor ;\n\tSun, 10 Mar 2024 01:30:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 832F46286F;\n\tSun, 10 Mar 2024 02:30:12 +0100 (CET)","from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F02A62867\n\tfor ;\n\tSun, 10 Mar 2024 02:30:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"M0VVQf+X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1710034208; x=1710293408;\n\tbh=5yBcKnlzWNolNatJ/vV+dlGJf5Ljs1qqNw6QviWWj0c=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=M0VVQf+XgjPxAVkLvKAigaje0jJPbXJ3ZG7A+PF+Cq6Qei3XftJylTQEVNWoNU2Db\n\tDNejPej6uuoVWEXUiMEkr7207b36Fvmj1Ws6nG8pObVIPuSQZ5o1LLMj0uG4X+m3yS\n\txjsRHMWarRv2i2CiyBy1hnOXMsNmXDYu1C423e9gk4DBp2rIoQrixG1fS1nW5iQS3Z\n\tqHB9hz5SmwboSQICD/5+ct0qkTOVmhbY0VD55CNDLnM/1eBNjTQViugA/LiyAJN+S3\n\tTVwuy5RQgsdqRIUvsMuIRZ2ihqO8UKhjk/EHeH5LgLwErifloDdiZUsL/CEmBnMq17\n\tdNsU6I52E6zaw==","Date":"Sun, 10 Mar 2024 01:29:59 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v1 2/3] libcamera: framebuffer_allocator: use default\n\tdestructor","Message-ID":"<20240310012946.727641-3-pobrn@protonmail.com>","In-Reply-To":"<20240310012946.727641-1-pobrn@protonmail.com>","References":"<20240310012946.727641-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The compiler generated destructor works fine, so use that.\n---\n src/libcamera/framebuffer_allocator.cpp | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp\nindex 8cf45ab2..fc19a33a 100644\n--- a/src/libcamera/framebuffer_allocator.cpp\n+++ b/src/libcamera/framebuffer_allocator.cpp\n@@ -63,10 +63,7 @@ FrameBufferAllocator::FrameBufferAllocator(std::shared_ptr camera)\n {\n }\n \n-FrameBufferAllocator::~FrameBufferAllocator()\n-{\n-\tbuffers_.clear();\n-}\n+FrameBufferAllocator::~FrameBufferAllocator() = default;\n \n /**\n * \\brief Allocate buffers for a configured stream\n","prefixes":["v1","2/3"]}