{"id":19520,"url":"https://patchwork.libcamera.org/api/1.1/patches/19520/?format=json","web_url":"https://patchwork.libcamera.org/patch/19520/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<CANWxtmn7ZNYWnPPsN7AsEQbfPXfHLLpa8tXAeZ33s1C_-aWhxQ@mail.gmail.com>","date":"2024-02-21T05:38:00","name":"The first valid settings should be saved","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d680ab7ef17c9aa734bcb79eb1fd3f39ac712fc4","submitter":{"id":185,"url":"https://patchwork.libcamera.org/api/1.1/people/185/?format=json","name":"hui fang","email":"biomifang118@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19520/mbox/","series":[{"id":4174,"url":"https://patchwork.libcamera.org/api/1.1/series/4174/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4174","date":"2024-02-21T05:38:00","name":"The first valid settings should be saved","version":1,"mbox":"https://patchwork.libcamera.org/series/4174/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19520/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19520/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDE97BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Feb 2024 10:06:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3EC7362800;\n\tWed, 21 Feb 2024 11:06:05 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4814A62800\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Feb 2024 06:38:12 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-41273252724so4009135e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Feb 2024 21:38:12 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EuO+LMT3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1708493891; x=1709098691;\n\tdarn=lists.libcamera.org; \n\th=to:subject:message-id:date:from:mime-version:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=5c/SyQQ6ga1349ZotIr6GyRBX+c7Pi2H7Zu/eteg49k=;\n\tb=EuO+LMT3DvLYbKMYl/QeBJgjL+rs0jYwMSr8z5Eo6zoN1WiCxLaPGu8wpQGuRgZyLV\n\tUE6hgaPo5l80FRsOg38m0zk57mgq5ZzDHu2X4OG75A0XqDqJTmjKkMERQ1KwgrusJuPx\n\t+89Xx3kzk2c30OTBjeevXthOruqHXhne8260WS88CMDQQ7YAS15KkAYnXwFBb3zhjy1F\n\tIcI7gLsB3iBppwqiah0K5QW1qjDmlAQXNtxVgfbKNWOTMG+KoHll8K3NYNdsCqR6UgXS\n\tnRBbdw+vqaFy7TYiHBb+ROC/9ao5zmGe1EyeBD0fjqw6uWN7rHPaWRj0DTHLqZcysqXE\n\tNcXw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1708493891; x=1709098691;\n\th=to:subject:message-id:date:from:mime-version:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=5c/SyQQ6ga1349ZotIr6GyRBX+c7Pi2H7Zu/eteg49k=;\n\tb=TU46yHsiQ4NpZjVJFYHlM46etFj2zHICmqfM0sqEpJvR74CK9jDnLndFeUbushu5NW\n\tgJoW1+wh5tgk2K4P1taGFeW1CPRqeaa1uqI65efaWA5x3Sw4+cbD/QF+2ST/cyEbV6q7\n\tUTh4Q+gi373UNjFS0FYW3Rz9JUnMZ4heoOPgAeOWyOngke1UuKTQDNpvOvDmg0GX5tPC\n\t4Jc7peuBl+y57smgODRiS7teuE2vQudiG2hwzr+x/EfYoZa2D9wYiPfP21jc9sPr8W6N\n\tD8NYXuAYbI9Ha0z4XYkaRgvKDrCBf/8ByPuHCTqnCvDGumyBrZ+bzcOXE72VA75nuk/J\n\t4V8g==","X-Gm-Message-State":"AOJu0YyDiv/Y6Ey86I8/rt/LtbUv/nEMsXIxHuXABN8mcBNHe9wq48RN\n\tHk3N9HZHYOOdYvTkuWj8pmD5pkRaMUrnDIUx/7weeFvDPbl3zrrtLUFXWn+jvHB2j/SIu4CL8q1\n\tGMMyWs2WT33SLtRU79k41B6hXu/Rcz0Bs5EU=","X-Google-Smtp-Source":"AGHT+IE4N6o8H845JOKJR9rIr1qrx6hbTQbSii1xh8WEGB5Fzj9OK+jFJbDtZZ4MK8xty1L9xDjFxFbWRVF9U4GTRNE=","X-Received":"by 2002:a05:600c:1382:b0:410:7897:6bc0 with SMTP id\n\tu2-20020a05600c138200b0041078976bc0mr12732714wmf.22.1708493891469;\n\tTue, 20 Feb 2024 21:38:11 -0800 (PST)","MIME-Version":"1.0","From":"hui fang <biomifang118@gmail.com>","Date":"Wed, 21 Feb 2024 13:38:00 +0800","Message-ID":"<CANWxtmn7ZNYWnPPsN7AsEQbfPXfHLLpa8tXAeZ33s1C_-aWhxQ@mail.gmail.com>","Subject":"The first valid settings should be saved","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"0000000000008086020611ddbbc6\"","X-Mailman-Approved-At":"Wed, 21 Feb 2024 11:06:02 +0100","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The first valid settings should be saved, or will be deferred to the next frame.\n\n\n\nBRs,\n\nFangHui","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 25cedd44..d45ed1a5 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -952,8 +952,8 @@ int\nCameraDevice::processCaptureRequest(camera3_capture_request_t\n*camera3Reques\n         */\n        if (camera3Request->settings)\n                lastSettings_ = camera3Request->settings;\n-       else\n-               descriptor->settings_ = lastSettings_;\n+\n+       descriptor->settings_ = lastSettings_;\n\n","prefixes":[]}