{"id":19454,"url":"https://patchwork.libcamera.org/api/1.1/patches/19454/?format=json","web_url":"https://patchwork.libcamera.org/patch/19454/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240123011249.22716-7-laurent.pinchart@ideasonboard.com>","date":"2024-01-23T01:12:43","name":"[v2,06/12] test: message: Remove incorrect slow receiver test","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"58aa093fc5ddddf0705c0477ec3365ddc295508f","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19454/mbox/","series":[{"id":4157,"url":"https://patchwork.libcamera.org/api/1.1/series/4157/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4157","date":"2024-01-23T01:12:37","name":"libcamera: Hardening against thread race conditions","version":2,"mbox":"https://patchwork.libcamera.org/series/4157/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19454/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19454/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 745A5C32C0\n\tfor ;\n\tTue, 23 Jan 2024 01:12:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4E5362957;\n\tTue, 23 Jan 2024 02:12:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4217A62954\n\tfor ;\n\tTue, 23 Jan 2024 02:12:54 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DACD91B9A;\n\tTue, 23 Jan 2024 02:11:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JWcqnKJi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705972301;\n\tbh=1vKKV4M7kENbh/o8JW9ET2qZ2bxeYrGjnJIthe49NUg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JWcqnKJiaCAn9OV9U0Yc7QBICL5oMu2m5a/W15ni0Rgg+F4iDpVHHfLBcQSuVnKTg\n\tlCKbw3vZZ6xT8s2/vWnlSggfJ/lOgSH41zepBFFBmRBrLUdVB4FGNMOivrY/w4VF8U\n\tTO9N0sJAt9cJWNLVSuALvnRAfTKAsUsP79JA8Hws=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 06/12] test: message: Remove incorrect slow receiver test","Date":"Tue, 23 Jan 2024 03:12:43 +0200","Message-ID":"<20240123011249.22716-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240123011249.22716-1-laurent.pinchart@ideasonboard.com>","References":"<20240123011249.22716-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The slow receiver test verifies there's no race condition between\nconcurrent message delivery and object deletion. This is not a valid use\ncase in the first place, as objects are not allowed to be deleted from a\ndifferent thread than the one they are bound to. Remove the incorrect\ntest.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Milan Zamazal \n---\nChanges since v1:\n\n- Fix typo in commit message\n---\n test/message.cpp | 34 ----------------------------------\n 1 file changed, 34 deletions(-)","diff":"diff --git a/test/message.cpp b/test/message.cpp\nindex 0e76f323e3b9..a34e0f0b5e10 100644\n--- a/test/message.cpp\n+++ b/test/message.cpp\n@@ -93,25 +93,6 @@ private:\n \tbool success_;\n };\n \n-class SlowMessageReceiver : public Object\n-{\n-protected:\n-\tvoid message(Message *msg)\n-\t{\n-\t\tif (msg->type() != Message::None) {\n-\t\t\tObject::message(msg);\n-\t\t\treturn;\n-\t\t}\n-\n-\t\t/*\n-\t\t * Don't access any member of the object here (including the\n-\t\t * vtable) as the object will be deleted by the main thread\n-\t\t * while we're sleeping.\n-\t\t */\n-\t\tthis_thread::sleep_for(chrono::milliseconds(100));\n-\t}\n-};\n-\n class MessageTest : public Test\n {\n protected:\n@@ -148,21 +129,6 @@ protected:\n \t\t\tbreak;\n \t\t}\n \n-\t\t/*\n-\t\t * Test for races between message delivery and object deletion.\n-\t\t * Failures result in assertion errors, there is no need for\n-\t\t * explicit checks.\n-\t\t */\n-\t\tSlowMessageReceiver *slowReceiver = new SlowMessageReceiver();\n-\t\tslowReceiver->moveToThread(&thread_);\n-\t\tslowReceiver->postMessage(std::make_unique(Message::None));\n-\n-\t\tthis_thread::sleep_for(chrono::milliseconds(10));\n-\n-\t\tdelete slowReceiver;\n-\n-\t\tthis_thread::sleep_for(chrono::milliseconds(100));\n-\n \t\t/*\n \t\t * Test recursive calls to Thread::dispatchMessages(). Messages\n \t\t * should be delivered correctly, without crashes or memory\n","prefixes":["v2","06/12"]}