{"id":19362,"url":"https://patchwork.libcamera.org/api/1.1/patches/19362/?format=json","web_url":"https://patchwork.libcamera.org/patch/19362/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240104151548.2589-2-laurent.pinchart@ideasonboard.com>","date":"2024-01-04T15:15:41","name":"[libcamera-devel,1/8] utils: update-mojo.sh: Properly remove old sources","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bf01d092a222644334df61a7598c7d650fa93edf","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19362/mbox/","series":[{"id":4132,"url":"https://patchwork.libcamera.org/api/1.1/series/4132/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4132","date":"2024-01-04T15:15:40","name":"libcamera: Update mojo and mojo updater","version":1,"mbox":"https://patchwork.libcamera.org/series/4132/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19362/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19362/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B47DC3240\n\tfor ;\n\tThu, 4 Jan 2024 15:15:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C034A62B58;\n\tThu, 4 Jan 2024 16:15:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74F4661D82\n\tfor ;\n\tThu, 4 Jan 2024 16:15:41 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6547D49;\n\tThu, 4 Jan 2024 16:14:40 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704381344;\n\tbh=Hz10/+gr+xxlH/SpuBT08am0O4gRyM3saiCXJMFBEhE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yr2N/FEnmHQbufKbwvk5LgTQ0ZdO8DyNTFqP23vSp6TzOrdAq6x5lOc55+BhdJnRt\n\tAgR4VfDv98l9zB3TRLeTC1CYM9HjtfMYwFQg6ZShF75Am2PjPkNOiZA9GZ4L1ZK4tT\n\tI2ZaBKFMqeqE/K1JN3YK2/0B0VBG/A/eWFMQDajrVz9aIW3MLIMOfduXIAE6YwmMqv\n\tnCmQkdoPqKo1WqgcXgbh/k7Bw8Uw5ng2vTj1yUNoAiRlTwtxqupQBip1hOhYV9qqnj\n\tN1x/PqCig8rRn8WkyLR+Aew5eppcubNdYJcXsctA2J0XYUP6urQqqSY80vTErlFf9x\n\tHtCsk9vRMR4OQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704381280;\n\tbh=Hz10/+gr+xxlH/SpuBT08am0O4gRyM3saiCXJMFBEhE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=erdtgxNtu4HEO5Bq2CrZjmKzI3zNOZIcsN63y4TkTti2gMtGTPjPlhI8V75fxoojX\n\tGJkmheKZoIVApH6TkfpJvieIFYy8ZiNlIPV0PoyuiblFWXeJ77wbbzHHpb1Uv6MIjE\n\tYYWVcGX8BN8fVIdKYAZ0BRkQ7OL7qmYMLRd14qzA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"erdtgxNt\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 4 Jan 2024 17:15:41 +0200","Message-ID":"<20240104151548.2589-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","In-Reply-To":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/8] utils: update-mojo.sh: Properly\n\tremove old sources","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Khem Raj ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The update-mojo.sh script starts by removing all sources before copying\nthe new files from chromium. A bug in the 'rm' command makes the removal\na no-op: the glob pattern is quoted, which attempts to remove a file\nname '*' in the tools directory, not all files in the directory. Fix it\nby removing the whole utils/ipc/mojo/ directory.\n\nWhile at it, also remove the utils/ipc/tools/ directory that contains\nimported sources.\n\nSigned-off-by: Laurent Pinchart \n---\n utils/update-mojo.sh | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)","diff":"diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh\nindex fcbc81e70529..967d139a3f70 100755\n--- a/utils/update-mojo.sh\n+++ b/utils/update-mojo.sh\n@@ -30,14 +30,18 @@ if [ -n \"$(git -C \"${chromium_dir}\" status --porcelain)\" ] ; then\n \texit 1\n fi\n \n+# Remove the previously imported files.\n+rm -rf \"${ipc_dir}/mojo/\"\n+rm -rf \"${ipc_dir}/tools/\"\n+\n # Copy the diagnosis file\n+mkdir -p \"${ipc_dir}/tools/diagnosis\"\n cp \"${chromium_dir}/tools/diagnosis/crbug_1001171.py\" \"${ipc_dir}/tools/diagnosis\"\n \n # Copy the rest of mojo\n+mkdir -p \"${ipc_dir}/mojo/public\"\n cp \"${chromium_dir}/mojo/public/LICENSE\" \"${ipc_dir}/mojo/public\"\n \n-rm -rf \"${ipc_dir}/mojo/public/tools/*\"\n-\n (\n \tcd \"${chromium_dir}\" || exit\n \tfind ./mojo/public/tools -type f \\\n","prefixes":["libcamera-devel","1/8"]}