{"id":19353,"url":"https://patchwork.libcamera.org/api/1.1/patches/19353/?format=json","web_url":"https://patchwork.libcamera.org/patch/19353/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231230162912.827669-3-jacopo.mondi@ideasonboard.com>","date":"2023-12-30T16:29:07","name":"[libcamera-devel,v3,2/7] apps: lc-compliance: Check that requests complete successfully","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cadcafb1751b2e25190232d7f70bff1ac61e6afb","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19353/mbox/","series":[{"id":4129,"url":"https://patchwork.libcamera.org/api/1.1/series/4129/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4129","date":"2023-12-30T16:29:05","name":"apps: lc-compliance: Properties and multi-stream tests","version":3,"mbox":"https://patchwork.libcamera.org/series/4129/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19353/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19353/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B412DC3295\n\tfor ;\n\tSat, 30 Dec 2023 16:29:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A91862B61;\n\tSat, 30 Dec 2023 17:29:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C9AF62B40\n\tfor ;\n\tSat, 30 Dec 2023 17:29:32 +0100 (CET)","from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E1CA9B6;\n\tSat, 30 Dec 2023 17:28:35 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1703953776;\n\tbh=qneqtV9quvOjU67kpSxwhaJzfrt4bucT1eOPM/MgTvQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dd3WKFGqqIoqD7WFWFBK6+9XGNR4Jyjbi4I2ejuWTzmAbjR2782Zjr1yMCSWCNLOb\n\tQYu59nG/WCW2304/Q2H6G3lLYjPBQZ0Ixh5i8jXD83PrzQZ4ADRAF63RQP+piM51Tg\n\tbqqauOKJA+giTobhqI7RlWWZzDupkLi1/00SrkJmx71YaNvzz+LOxomX+X9GiLCRGG\n\tiH6b3K61+g5NHeB1NQUc8Vg9TtUHxy3TGZLj8dkAMgrUVUrAgKzn+fmTijLA3u7iq/\n\tDP8qZQZhxWr6QpL4w3+9kRQs+fy3WNnrSUQz0XlSQUdJ1fhnb3+C6l32FFFwDyZQIF\n\tLsrKWeyddTfWg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1703953715;\n\tbh=qneqtV9quvOjU67kpSxwhaJzfrt4bucT1eOPM/MgTvQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VOXkWDbwUe/yXTBcdhYoQfeLDIvOtnK/3lBpWdRIEzhw79LLQx1FFzuTQhCdldP/p\n\tADk279NiTQrlbFEDyDsKJJPCH0AODbH1LGdL+xKHHjfPn8/hFAonF5pjyyKnP4R9wb\n\t2yqHsHsjDaAn5WFhHKd9qWgoPAj+ZAg993bTN5NE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VOXkWDbw\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 30 Dec 2023 17:29:07 +0100","Message-ID":"<20231230162912.827669-3-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","In-Reply-To":"<20231230162912.827669-1-jacopo.mondi@ideasonboard.com>","References":"<20231230162912.827669-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 2/7] apps: lc-compliance: Check that\n\trequests complete successfully","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Nícolas F. R. A. Prado \n\nWhen a request fails to queue it is completed but with its status set to\nRequestCancelled. Add a check in the requestComplete callback to make\nsure that the request was completed successfully.\n\nFor the SimpleCaptureUnbalanced test we need to do this check only if\nthe capture isn't over yet, otherwise the few extra requests that get\ncancelled at the end, which is the normal behavior, will make the test\nfail.\n\nSigned-off-by: Nícolas F. R. A. Prado \nReviewed-by: Paul Elder \nSigned-off-by: Paul Elder \n---\n src/apps/lc-compliance/simple_capture.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\nindex cf4d7cf38bc3..e22a339c4e1c 100644\n--- a/src/apps/lc-compliance/simple_capture.cpp\n+++ b/src/apps/lc-compliance/simple_capture.cpp\n@@ -127,6 +127,9 @@ int SimpleCaptureBalanced::queueRequest(Request *request)\n \n void SimpleCaptureBalanced::requestComplete(Request *request)\n {\n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n+\t\t<< \"Request didn't complete successfully\";\n+\n \tcaptureCount_++;\n \tif (captureCount_ >= captureLimit_) {\n \t\tloop_->exit(0);\n@@ -184,6 +187,9 @@ void SimpleCaptureUnbalanced::requestComplete(Request *request)\n \t\treturn;\n \t}\n \n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n+\t\t<< \"Request didn't complete successfully\";\n+\n \trequest->reuse(Request::ReuseBuffers);\n \tif (camera_->queueRequest(request))\n \t\tloop_->exit(-EINVAL);\n","prefixes":["libcamera-devel","v3","2/7"]}