{"id":19346,"url":"https://patchwork.libcamera.org/api/1.1/patches/19346/?format=json","web_url":"https://patchwork.libcamera.org/patch/19346/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231223111023.668199-3-jacopo.mondi@ideasonboard.com>","date":"2023-12-23T11:10:20","name":"[libcamera-devel,v2,2/5] apps: lc-compliance: Check that requests complete successfully","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cadcafb1751b2e25190232d7f70bff1ac61e6afb","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19346/mbox/","series":[{"id":4127,"url":"https://patchwork.libcamera.org/api/1.1/series/4127/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4127","date":"2023-12-23T11:10:18","name":"apps: lc-compliance: Add controls and properties test","version":2,"mbox":"https://patchwork.libcamera.org/series/4127/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19346/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19346/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EAC8BDB1D\n\tfor ;\n\tSat, 23 Dec 2023 11:10:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77FD762B5C;\n\tSat, 23 Dec 2023 12:10:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0597A62B31\n\tfor ;\n\tSat, 23 Dec 2023 12:10:36 +0100 (CET)","from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 942349A8;\n\tSat, 23 Dec 2023 12:09:43 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1703329839;\n\tbh=qneqtV9quvOjU67kpSxwhaJzfrt4bucT1eOPM/MgTvQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=FDoRcWzmFnI4ZDZf+fMKW0akgXhLiuQjb7a32tuARLkzPy7yTWE5t9jkkpR1UHGRJ\n\taf68dcN13cvYwxBIHWbCmuat5g0SqZPh3vwDW8gdSiJsEHsJI6GciPfm+3edARBCJ+\n\thSB8uKFibW7SilTfCg9qah/H8W5aER5hT88WrYDs67Zi99FIJ80XVts9B4weMzsPH3\n\t023lnw7q+AP+miIqUSao3zW/vvKcO6l9FnxLlGIgg0am3++l8gq80+y+sAwklK3B6h\n\tuFiEtwseyoD7j/oj7sufOQtFNzYMyXfg3hLVDy3c/1iu3j5H+RYdO0EJNW2zIGNiuU\n\tubmOSKId5etNg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1703329783;\n\tbh=qneqtV9quvOjU67kpSxwhaJzfrt4bucT1eOPM/MgTvQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UYT5rkMPMTLQrhePi/PToHOrh1BLoz562Gn/opiP+qiR31CvxfFuxlmmuWRDaZXbl\n\tv9pvz+BvjQbSpdl+sC9p+9up2gePOvJxaCWL541ITXK1tvY3XJIWe1I3BC7yYZBoGU\n\tzq9ei0NVcEqZdawV4Y3KPBR/mDf6RwJhhrK6x6C4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UYT5rkMP\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 23 Dec 2023 12:10:20 +0100","Message-ID":"<20231223111023.668199-3-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","In-Reply-To":"<20231223111023.668199-1-jacopo.mondi@ideasonboard.com>","References":"<20231223111023.668199-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/5] apps: lc-compliance: Check that\n\trequests complete successfully","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Nícolas F. R. A. Prado \n\nWhen a request fails to queue it is completed but with its status set to\nRequestCancelled. Add a check in the requestComplete callback to make\nsure that the request was completed successfully.\n\nFor the SimpleCaptureUnbalanced test we need to do this check only if\nthe capture isn't over yet, otherwise the few extra requests that get\ncancelled at the end, which is the normal behavior, will make the test\nfail.\n\nSigned-off-by: Nícolas F. R. A. Prado \nReviewed-by: Paul Elder \nSigned-off-by: Paul Elder \n---\n src/apps/lc-compliance/simple_capture.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\nindex cf4d7cf38bc3..e22a339c4e1c 100644\n--- a/src/apps/lc-compliance/simple_capture.cpp\n+++ b/src/apps/lc-compliance/simple_capture.cpp\n@@ -127,6 +127,9 @@ int SimpleCaptureBalanced::queueRequest(Request *request)\n \n void SimpleCaptureBalanced::requestComplete(Request *request)\n {\n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n+\t\t<< \"Request didn't complete successfully\";\n+\n \tcaptureCount_++;\n \tif (captureCount_ >= captureLimit_) {\n \t\tloop_->exit(0);\n@@ -184,6 +187,9 @@ void SimpleCaptureUnbalanced::requestComplete(Request *request)\n \t\treturn;\n \t}\n \n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n+\t\t<< \"Request didn't complete successfully\";\n+\n \trequest->reuse(Request::ReuseBuffers);\n \tif (camera_->queueRequest(request))\n \t\tloop_->exit(-EINVAL);\n","prefixes":["libcamera-devel","v2","2/5"]}