{"id":19342,"url":"https://patchwork.libcamera.org/api/1.1/patches/19342/?format=json","web_url":"https://patchwork.libcamera.org/patch/19342/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231222164036.649245-6-jacopo.mondi@ideasonboard.com>","date":"2023-12-22T16:40:36","name":"[libcamera-devel,5/5] apps: lc-compliance: Test for mandatory controls","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"76c84ea9ea152fb0606023dce21b69a56390f02b","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19342/mbox/","series":[{"id":4125,"url":"https://patchwork.libcamera.org/api/1.1/series/4125/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4125","date":"2023-12-22T16:40:31","name":"apps: lc-compliance: Add controls and properties test","version":1,"mbox":"https://patchwork.libcamera.org/series/4125/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19342/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19342/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8291C32BD\n\tfor ;\n\tFri, 22 Dec 2023 16:40:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F15BE62B60;\n\tFri, 22 Dec 2023 17:40:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFF3762B53\n\tfor ;\n\tFri, 22 Dec 2023 17:40:50 +0100 (CET)","from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1040B250;\n\tFri, 22 Dec 2023 17:39:59 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1703263256;\n\tbh=k8Mbr2+JgGuhmFwIhLIu3QQyr3B588Uw/2u4g5cSFgE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dIgQTc4FlKkQrL/EDK9qE2pPaIg7L7R8Rfld9KFINkJ2viGmIZi4WQAY1g5apxaVC\n\tB8gsb1Hsm1sE6TROQerESfxQYarJp/2Zw5FS0xC+BrdYJqZppDMBPJH40gAGcD4Qqi\n\tznEn/O7sTAJalmV6E0HEwBl5DNWtcYtpZgWqktq00T9PA+lQHJzT3S9yE3ybupIOHT\n\t4/1XtXyOt2zSphDXuMh5GJJ8RkZETZ2Ip+A/1/IeN3yTR9dnP6J2NlEzLR2XhW7UOS\n\tBmuEkPUu6E8P7pVgFsw1thGGi3YRbl3xLaUuDXiMMhgy6D4EK1GclBjiRzf1Fl0ArL\n\tH9f7QR98StpBw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1703263199;\n\tbh=k8Mbr2+JgGuhmFwIhLIu3QQyr3B588Uw/2u4g5cSFgE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IyJ8DDr8Li3KRr97A7loKd9dp2AI2Bt3aKXJU9E+6b/6PGCBG8w4O3iWGMERXI5g/\n\tUvJ1q+Yr/lQm6yp2UCzOMcLNEHmKl7gY1jEKOB7yxx+88DPeK/6FewDlVIV0Fd3FHa\n\t2Jxou+j7E8wtRAKiOemnNYyizGcUnjfAG4vbMmSg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IyJ8DDr8\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 Dec 2023 17:40:36 +0100","Message-ID":"<20231222164036.649245-6-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","In-Reply-To":"<20231222164036.649245-1-jacopo.mondi@ideasonboard.com>","References":"<20231222164036.649245-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 5/5] apps: lc-compliance: Test for\n\tmandatory controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Test for mandatory controls and properties to be supported by\na Camera.\n\nSigned-off-by: Jacopo Mondi \n---\n src/apps/lc-compliance/controls_test.cpp | 98 ++++++++++++++++++++++++\n src/apps/lc-compliance/meson.build | 1 +\n 2 files changed, 99 insertions(+)\n create mode 100644 src/apps/lc-compliance/controls_test.cpp","diff":"diff --git a/src/apps/lc-compliance/controls_test.cpp b/src/apps/lc-compliance/controls_test.cpp\nnew file mode 100644\nindex 000000000000..e9bdf6fdb7e3\n--- /dev/null\n+++ b/src/apps/lc-compliance/controls_test.cpp\n@@ -0,0 +1,98 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2023, Ideas On Board Oy\n+ *\n+ * controls_test.cpp - Test controls and properties\n+ */\n+\n+#include \n+#include \n+\n+#include \n+#include \n+#include \n+\n+#include \n+\n+#include \"environment.h\"\n+\n+using namespace libcamera;\n+\n+std::array controlMaps = {\n+\t&controls::controls,\n+\t&properties::properties,\n+};\n+\n+class ControlTest : public testing::TestWithParam\n+{\n+public:\n+\tstatic std::string nameParameters(const testing::TestParamInfo &info);\n+\n+protected:\n+\tvoid SetUp() override;\n+\tvoid TearDown() override;\n+\n+\tstd::shared_ptr camera_;\n+};\n+\n+void ControlTest::SetUp()\n+{\n+\tEnvironment *env = Environment::get();\n+\n+\tcamera_ = env->cm()->get(env->cameraId());\n+\n+\tASSERT_EQ(camera_->acquire(), 0);\n+}\n+\n+void ControlTest::TearDown()\n+{\n+\tif (!camera_)\n+\t\treturn;\n+\n+\tcamera_->release();\n+\tcamera_.reset();\n+}\n+\n+std::string ControlTest::nameParameters(const testing::TestParamInfo &info)\n+{\n+\tconst ControlIdMap *idMap = info.param;\n+\tif (idMap == &controls::controls)\n+\t\treturn \"controls\";\n+\telse if (idMap == &properties::properties)\n+\t\treturn \"properties\";\n+\n+\treturn \"vendor\";\n+}\n+\n+/* Test that mandatory controls and properties are supported by a camera. */\n+TEST_P(ControlTest, RequiredControls)\n+{\n+\tauto controlMap = GetParam();\n+\n+\tfor (const auto &[id, ctrl] : *controlMap) {\n+\t\tif (!ctrl->required())\n+\t\t\tcontinue;\n+\n+\t\tif (controlMap == &controls::controls) {\n+\t\t\tconst auto it = camera_->controls().find(ctrl);\n+\n+\t\t\tif (it == camera_->controls().end())\n+\t\t\t\tFAIL() << \"Mandatory control \\\"\" << ctrl->name()\n+\t\t\t\t << \"\\\" not supported\" << std::endl;\n+\t\t} else if (controlMap == &properties::properties) {\n+\t\t\tbool found = camera_->properties().contains(id);\n+\n+\t\t\tif (!found)\n+\t\t\t\tFAIL() << \"Mandatory property \\\"\" << ctrl->name()\n+\t\t\t\t << \"\\\" not supported\" << std::endl;\n+\t\t}\n+\t}\n+}\n+\n+/*\n+ * Use a Value-Parametrized Test case so that vendors can easily test vendor\n+ * control lists by expading 'controlMaps'.\n+ */\n+INSTANTIATE_TEST_SUITE_P(ControlsTest, ControlTest,\n+\t\t\t testing::ValuesIn(controlMaps),\n+\t\t\t ControlTest::nameParameters);\ndiff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\nindex ae8c6f4db51b..c927dd12e9f4 100644\n--- a/src/apps/lc-compliance/meson.build\n+++ b/src/apps/lc-compliance/meson.build\n@@ -15,6 +15,7 @@ lc_compliance_sources = files([\n 'helpers/capture.cpp',\n 'main.cpp',\n 'tests/capture_test.cpp',\n+ 'tests/controls_test.cpp'\n ])\n \n lc_compliance_includes = ([\n","prefixes":["libcamera-devel","5/5"]}