{"id":19297,"url":"https://patchwork.libcamera.org/api/1.1/patches/19297/?format=json","web_url":"https://patchwork.libcamera.org/patch/19297/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231206210524.20974-4-laurent.pinchart@ideasonboard.com>","date":"2023-12-06T21:05:21","name":"[libcamera-devel,3/6] test: log: log_process: Improve debugging on process exit failures","commit_ref":"2d12e6088e92a39e10ffd1faad0bdc7a88401750","pull_url":null,"state":"accepted","archived":false,"hash":"ac2e60df5e62a76a68a0564257ae90d0c5ca845c","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19297/mbox/","series":[{"id":4109,"url":"https://patchwork.libcamera.org/api/1.1/series/4109/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4109","date":"2023-12-06T21:05:18","name":"test: Miscellaneous fixes and improvements for unit tests","version":1,"mbox":"https://patchwork.libcamera.org/series/4109/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19297/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19297/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F562C32BD\n\tfor ;\n\tWed, 6 Dec 2023 21:05:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C65B962B3F;\n\tWed, 6 Dec 2023 22:05:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A60062B3E\n\tfor ;\n\tWed, 6 Dec 2023 22:05:22 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 15DFB556\n\tfor ;\n\tWed, 6 Dec 2023 22:04:41 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701896723;\n\tbh=Y0qLLmJmb7hWO3XbKSizWDexIQw5YU4gUk+zj2merFs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=gDeYZCTFwifRitpTElS9giw5yjzOA5FTyVwjynGVg7HmbpRcnENZrNSqErYrmAC+m\n\t9lAz0ztOLMMGpxJ8f/bIjcan+XscyNOTnn8IMbqNruZI74iDawHJ7NDVp7CFseRSEj\n\tKBBPLSvFhdqchNBX+ZgEAyTPTDpsyzLdU1/hYElE7hwoAG3G5Ey0v6gdI39hPBcu3F\n\tsMlgRJ9nEwuCPTXtt59/IhlMA8roL0/rx/9RzCcKwjCbD7hkg1KNJa6vSR5icpP7sY\n\tt1ZOsqMl1W8MwfcxfT5atPbDsg32xn2noWkYe02y3I1Gd7Kz1QEz9b9OJHSuAYbBFR\n\tR9/s4CBztms8A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701896681;\n\tbh=Y0qLLmJmb7hWO3XbKSizWDexIQw5YU4gUk+zj2merFs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=c/GubRmhNdab3SAvK+XAb0Sg+xW3I3zMcHO/4yY5HNMtABQOaL59J4ghxbeUs32Kx\n\tYMaGJEAFIS7u4bgG2hLAUXYS1iJk5HyOSFq3xzpXX4AGrSvIkkIyPe2IvKrqxpEgz2\n\tLjx1J+7HRlk2R5cy8XOUpQ5uCcsoSrqBpiFXaCpY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"c/GubRmh\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 6 Dec 2023 23:05:21 +0200","Message-ID":"<20231206210524.20974-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","In-Reply-To":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>","References":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/6] test: log: log_process: Improve\n\tdebugging on process exit failures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the process fails to run and exit normally, the test prints an\nerror message that provides little information:\n\n\tprocess did not exit normally\n\nExpand the error message to print the exit status to make debugging\neasier.\n\nSigned-off-by: Laurent Pinchart \n---\n test/log/log_process.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\nindex f7635b70255c..fb6635cc99aa 100644\n--- a/test/log/log_process.cpp\n+++ b/test/log/log_process.cpp\n@@ -86,7 +86,8 @@ protected:\n \t\t\tdispatcher->processEvents();\n \n \t\tif (exitStatus_ != Process::NormalExit) {\n-\t\t\tcerr << \"process did not exit normally\" << endl;\n+\t\t\tcerr << \"process did not exit normally: \" << exitStatus_\n+\t\t\t << endl;\n \t\t\treturn TestFail;\n \t\t}\n \n","prefixes":["libcamera-devel","3/6"]}