{"id":19295,"url":"https://patchwork.libcamera.org/api/1.1/patches/19295/?format=json","web_url":"https://patchwork.libcamera.org/patch/19295/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231206210524.20974-2-laurent.pinchart@ideasonboard.com>","date":"2023-12-06T21:05:19","name":"[libcamera-devel,1/6] test: log: log_process: Log an error when failing due to incorrect message","commit_ref":"030fe617ef2a7064f45d5af515cd49b0a085c711","pull_url":null,"state":"accepted","archived":false,"hash":"a502e9213add6c0e9d9a81e19c12e033812b75ad","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19295/mbox/","series":[{"id":4109,"url":"https://patchwork.libcamera.org/api/1.1/series/4109/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4109","date":"2023-12-06T21:05:18","name":"test: Miscellaneous fixes and improvements for unit tests","version":1,"mbox":"https://patchwork.libcamera.org/series/4109/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19295/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19295/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D64D6C322E\n\tfor ;\n\tWed, 6 Dec 2023 21:05:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8289062B32;\n\tWed, 6 Dec 2023 22:05:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64F3A62B30\n\tfor ;\n\tWed, 6 Dec 2023 22:05:19 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44185556\n\tfor ;\n\tWed, 6 Dec 2023 22:04:38 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701896721;\n\tbh=aUngI5o5kbXxB8j5Td2qe6Z5EqO9Gtm0OHjR2Us5XCk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=QGbj30NlniKleLJnWmf/r2F2LiA4oYN/2HM2sv4ZiWwqWEpfySbeyRgs3p2e0xHxj\n\tskhjUmmQCpiGexSNQwqwUviZbQvof+tHmDIRgZW6Dt9ZXySn5PafAAR1CDAdl8fUEw\n\tsiGqFwD/vU9N8UcM5enDtWGjllxj4veGbW/e0P+y/qI0Yy6y+7ZxEijQaS+xXu/Nlw\n\tPESKJ6EYZuTZPT4XU7TrGRsG2AQghcl+9gWVffX5oqC76GAtnVmp+meCxZiXj3TB0w\n\tyfz8XIxy8+wZ9fmoKy3LZK5pQ1q165rhUaayFNNQlvAbm7w2CGuuBm0YbEifET21io\n\t7fsz0kyf2M89g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701896678;\n\tbh=aUngI5o5kbXxB8j5Td2qe6Z5EqO9Gtm0OHjR2Us5XCk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=t7bm2L1ag6yh64MmGvRilKJL0MaLYVH91qVfDiFs1/MgLlwKQ7t0tjbAdmLxJ3T+E\n\tVYrSZLagd7qjxQOK1pPV86trcLR2VcgCwdSBmwER7HdDWROQKmqLsm94Eo/mjhIQDk\n\tYuABts9PcINYyaIWIAX++m7sgOQfPDosCUb3MiAs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"t7bm2L1a\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 6 Dec 2023 23:05:19 +0200","Message-ID":"<20231206210524.20974-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","In-Reply-To":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>","References":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/6] test: log: log_process: Log an error\n\twhen failing due to incorrect message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"One of the error paths in the test returns without logging a message,\nwhich makes failures difficult to debug. Fix it by adding an error\nmessage.\n\nSigned-off-by: Laurent Pinchart \n---\n test/log/log_process.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\nindex 966b80cf3af7..17af7d74a1d5 100644\n--- a/test/log/log_process.cpp\n+++ b/test/log/log_process.cpp\n@@ -115,8 +115,11 @@ protected:\n \t\tclose(fd);\n \n \t\tstring str(buf);\n-\t\tif (str.find(message) == string::npos)\n+\t\tif (str.find(message) == string::npos) {\n+\t\t\tcerr << \"Received message is not correct (received \"\n+\t\t\t << str.length() << \" bytes)\" << endl;\n \t\t\treturn TestFail;\n+\t\t}\n \n \t\treturn TestPass;\n \t}\n","prefixes":["libcamera-devel","1/6"]}