{"id":19231,"url":"https://patchwork.libcamera.org/api/1.1/patches/19231/?format=json","web_url":"https://patchwork.libcamera.org/patch/19231/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231123130905.103934-1-david.plowman@raspberrypi.com>","date":"2023-11-23T13:09:04","name":"[libcamera-devel,v2,1/2] libcamera: controls: Update the ColourTemperature control to be writable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"820e08476256336584ca64ad1faeede54a89ef97","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19231/mbox/","series":[{"id":4083,"url":"https://patchwork.libcamera.org/api/1.1/series/4083/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4083","date":"2023-11-23T13:09:04","name":"[libcamera-devel,v2,1/2] libcamera: controls: Update the ColourTemperature control to be writable","version":2,"mbox":"https://patchwork.libcamera.org/series/4083/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19231/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19231/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27C91BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Nov 2023 13:09:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25184629BC;\n\tThu, 23 Nov 2023 14:09:13 +0100 (CET)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F72A629AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Nov 2023 14:09:11 +0100 (CET)","by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-40b2c9ee8ecso5637855e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Nov 2023 05:09:11 -0800 (PST)","from pi5-davidp.pitowers.org\n\t([2a00:1098:3142:14:183e:6cc8:a436:a27c])\n\tby smtp.gmail.com with ESMTPSA id\n\tv10-20020adff68a000000b00332c0e934aasm1593380wrp.44.2023.11.23.05.09.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 23 Nov 2023 05:09:09 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700744953;\n\tbh=0POCS3keIpL5tII+8BFiYdRWRt+0LYRuz4bweg/I1Wo=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=DZVZse2pJsaimfhXNcx8EqwWQkm6cg0lPybDqj7jX4byxHwLL1/d3NwuCmkdgps/b\n\tvymrXCJUdCAIvODF0UyDINZroMoY9ZoyUyiTRlEoGXRN8J5KxvH38EMZJBiV+0SR7N\n\tAfLKIqO3sZMYWxqaJPBum7lFgP6Ql2KugPUGdi289yyoMmX6VFzR7InwPp4rWGNLSZ\n\tZ6I1BFnaBkXVeaknnmvwV0GNaWSCWvRQiHJi2nF3gYPVYEewcZJpu3n+A9zSHgeIrX\n\tlE2nSb8l4M+UHOIn2IQSvbuCO6NPKzoCFmaWse8oMK5PJSeWW5Ds3DL3r/PPuYx3IX\n\tjFW3m236LXpZA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1700744950; x=1701349750;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=e4JC3h0rZbhNibftS95P6AEhUzmM7iPR3sNNjkPYK/I=;\n\tb=RibI+mQiOLRTTS/lhhAF69vBuOUJcXV5uXrAF0b2Z3REtqFG2uZ79y5u9vg+CdZYPu\n\t7daIv1h7dmR2BkquOT9K5byknf5OonMc2a/eZFRkTmUlqxuNavv/pDf0iFbZJijrHrp4\n\thOCctDzi2Wfy0JLgqGQex3NmnuJaVGjX3j377AlMDi/Dv8hwRBhCrYksJq9RJIdV8bhu\n\tbiTmkIn4inSFxJNJqgsYYW1fvpF9/fvw92wbuAPM8YnHd4z3y1JzGhxcwQyiK+icSOym\n\t8f1DfuRc9/01MzgrGtXfuD8GhWEitE0UZ4oEFVS8s9cc7863RRHDtdNkUoY9zhfniPd+\n\tJH3g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"RibI+mQi\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1700744950; x=1701349750;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=e4JC3h0rZbhNibftS95P6AEhUzmM7iPR3sNNjkPYK/I=;\n\tb=F4IeMlmJIXvhNmK/U1ljzX7cia8orFzXHFqL8cPfxBsOUe7kyvv70I9yHyF9FrWW8K\n\tR3kNiM+4rmZpjl47j/UqnbZ7xs62YenSdFLsKb6WvG14BUBWAPfMp8npYI9NTWEOrAh4\n\td4S6JeZ9W5TfQ/mQwqGZocid8Ns6MhSS0xyMMo8hGz2d1dhtR63o0H4jyN8wsDrpwGf0\n\tbp8RJEb2JxYuPJncHEAd96ZC0Mr8/bTwRr1r0yFxHqBleoHP3vaLV8V0hhIXZ+RhGOMh\n\tP3ul3LgTskOt5+6zaQFovVOsgSQCZTlWSGqHITcbrTs1Vgownu7IPg7QzQK+jC7i06jZ\n\t9rOg==","X-Gm-Message-State":"AOJu0Yxf60n3B3vhUqAruC0UPQxuMmBkie42ENEnhRbuu33IgZQINBD5\n\tToXPRHiy/mFTr+Is381GhRHyB1bwF0urtHCW8k4=","X-Google-Smtp-Source":"AGHT+IHB8v919xD2+wqDj8akRTVhTGKzJXw3GJhpiEDW+eeUrLkGVJB+r8mT4+eDBoM4oneWdU4IuA==","X-Received":"by 2002:a5d:634f:0:b0:332:e58b:ab58 with SMTP id\n\tb15-20020a5d634f000000b00332e58bab58mr870603wrw.1.1700744950227; \n\tThu, 23 Nov 2023 05:09:10 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 23 Nov 2023 13:09:04 +0000","Message-Id":"<20231123130905.103934-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/2] libcamera: controls: Update the\n\tColourTemperature control to be writable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"David Plowman <david.plowman@raspberrypi.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Implementations are allowed to expose this as a settable control so\nthat applications can demand a specific colour temperature. The\ndescription is updated to this effect.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex c3232abf..8fbcc5f6 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -312,9 +312,11 @@ controls:\n \n   - ColourTemperature:\n       type: int32_t\n-      description: Report the current estimate of the colour temperature, in\n-        kelvin, for this frame. The ColourTemperature control can only be\n-        returned in metadata.\n+      description: |\n+        Report the current estimate of the colour temperature, in kelvin, for\n+        this frame. An implementation may also allow this control to be set so\n+        as to disable the AWB algorithm whilst setting the colour gains to the\n+        correct fixed ones for this colour temperature.\n \n   - Saturation:\n       type: float\n","prefixes":["libcamera-devel","v2","1/2"]}