{"id":19230,"url":"https://patchwork.libcamera.org/api/1.1/patches/19230/?format=json","web_url":"https://patchwork.libcamera.org/patch/19230/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231123075736.3884-1-laurent.pinchart@ideasonboard.com>","date":"2023-11-23T07:57:36","name":"[libcamera-devel,v2] gstreamer: Fix unused variable error","commit_ref":"62e5289819789e37cb169af94869fea0c86c8e9c","pull_url":null,"state":"accepted","archived":false,"hash":"e15ed1c29ad86dde2cfd4a7d3943fbb0bed17a89","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19230/mbox/","series":[{"id":4082,"url":"https://patchwork.libcamera.org/api/1.1/series/4082/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4082","date":"2023-11-23T07:57:36","name":"[libcamera-devel,v2] gstreamer: Fix unused variable error","version":2,"mbox":"https://patchwork.libcamera.org/series/4082/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19230/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19230/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1ABDC3220\n\tfor ;\n\tThu, 23 Nov 2023 07:57:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E400629BB;\n\tThu, 23 Nov 2023 08:57:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F3E8761DA6\n\tfor ;\n\tThu, 23 Nov 2023 08:57:29 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AE6125A;\n\tThu, 23 Nov 2023 08:56:58 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700726251;\n\tbh=waVCEp7eLlDHhKsds7aNsp0nmdzyt1mS5chp2mSb7HY=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=MTgKMHdU0Y3AKanlED5NDs97VnYWMsxKTQt1qpAvW/on96ekcTYrmfcbxeOX7twTN\n\thVzir6EyIEK3WmfgG2WwocsMbzukUT0fg6KgX/F/upgbrfp7abMfASjHRnAH9v3x13\n\tWcQVB3q5eUUi/9jdxSp8s/13GPufcttba6k8cZeCKADgPf0N7Ef3kixLapR8hse7J5\n\tZo9mCT2SqscGv2beCNTx6DLU0+rXSvcamuQWDAJdSMD08+wVQ1s71wVa5TBs8Px0NH\n\tdMLYuefFtJAtqI12uqn5dZWGPBqCtGUE9AOWApgt8Usg374/axjhUIQfk5FBytpes3\n\thNtZ/9prcNkeA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1700726218;\n\tbh=waVCEp7eLlDHhKsds7aNsp0nmdzyt1mS5chp2mSb7HY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=b4yahU815kyFH4h51P3fuNDo8dt8SW9XJpzfDx8PkolaveZ250RZ9cWCeN6YtUjiD\n\tSNvAiK+ffPbYOGVacrhDivRAsxkYwIjVfOdCdbTAp8KRTU8t80PGj+uMOSsiKSYjl0\n\tUTGmwWqZ1a5HQJJyNnORzf/hfybwu61pJnQVCXzg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"b4yahU81\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 23 Nov 2023 09:57:36 +0200","Message-ID":"<20231123075736.3884-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] gstreamer: Fix unused variable error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jaslo Ziska \n\nCommit fd84180d7a09 (\"gstreamer: Implement element EOS handling\") has\nintroduced a compilation warning with clang:\n\n../../src/gstreamer/gstlibcamerasrc.cpp:768:23: error: unused variable 'oldEvent' [-Werror,-Wunused-variable]\n g_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);\n ^\n\nThis seems to be a false positive, but nonetheless breaks the build. Fix\nit.\n\nFixes: fd84180d7a09 (\"gstreamer: Implement element EOS handling\")\nSigned-off-by: Jaslo Ziska \nSigned-off-by: Laurent Pinchart \n---\n src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n\nbase-commit: 2fae9603e6cc483d9d0d74868721b272776513cf","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 767017db63f5..a6f240f56873 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -765,8 +765,8 @@ gst_libcamera_src_send_event(GstElement *element, GstEvent *event)\n \n \tswitch (GST_EVENT_TYPE(event)) {\n \tcase GST_EVENT_EOS: {\n-\t\tg_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);\n-\n+\t\tGstEvent *oldEvent = self->pending_eos.exchange(event);\n+\t\tgst_clear_event(&oldEvent);\n \t\tret = TRUE;\n \t\tbreak;\n \t}\n","prefixes":["libcamera-devel","v2"]}