{"id":19192,"url":"https://patchwork.libcamera.org/api/1.1/patches/19192/?format=json","web_url":"https://patchwork.libcamera.org/patch/19192/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231110104520.384229-1-david.plowman@raspberrypi.com>","date":"2023-11-10T10:45:20","name":"[libcamera-devel] ipa: rpi: agc: Fix bug where AeLocked was never getting set","commit_ref":"2905eabad9ffa3a83c498d5a4a98a110fc0317af","pull_url":null,"state":"accepted","archived":false,"hash":"7beb76ee1cbead7d1599ceeb0c049ef830f5f57e","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19192/mbox/","series":[{"id":4067,"url":"https://patchwork.libcamera.org/api/1.1/series/4067/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4067","date":"2023-11-10T10:45:20","name":"[libcamera-devel] ipa: rpi: agc: Fix bug where AeLocked was never getting set","version":1,"mbox":"https://patchwork.libcamera.org/series/4067/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19192/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19192/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63E24C3284\n\tfor ;\n\tFri, 10 Nov 2023 10:45:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A26D7629BC;\n\tFri, 10 Nov 2023 11:45:24 +0100 (CET)","from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3027C629AB\n\tfor ;\n\tFri, 10 Nov 2023 11:45:23 +0100 (CET)","by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-40859c464daso14148095e9.1\n\tfor ;\n\tFri, 10 Nov 2023 02:45:23 -0800 (PST)","from pi5-davidp.pitowers.org\n\t([2a00:1098:3142:14:183e:6cc8:a436:a27c])\n\tby smtp.gmail.com with ESMTPSA id\n\th7-20020a05600c350700b004090ca6d785sm4813394wmq.2.2023.11.10.02.45.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 10 Nov 2023 02:45:21 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1699613124;\n\tbh=A1+U9S3Pt1XlVbe+RIo1Sz6lc7R7WApLZ9n+G/1UAVw=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=GkIFPDN/BLwT+6CKnctOJibn7ggZNTPSsdddP1ceQ+/J1hOqZHJZr9Y82NkDxne0w\n\tmCF2ywpPbjtveo3n+R/IsMZaUyXBMOD879JcpzM6wAjAstpY6ihfagsE+NWI854Gx+\n\t8mD6T+gbB1cXX0xJ2s3atUUWDUnMQjbbvcmJ7KyXIqfmgEjxHei+C/JIuGMGhJilf/\n\t1pDR4HZ207KzRQMCLsoGxocZYtF7OMtHH6G90C0kky1236t3Q4bqBkjyTVmn6HzEa6\n\tNj6djLmtMeEE/U23b8RWPOXTJQveix9E9HCSiquHFLOcghO/tyGPriwUudd6hTd4tw\n\tIgqBgIQ9trd4Q==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1699613122; x=1700217922;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=7KBMCJLQhBzsuuW/fMdrs68y4Z1BYs2piiTZhacY4+4=;\n\tb=h/2PvuOvTG4eLf96Sd569gDG4pZyC5w1J0hl2r2ry++w+fGJ0g3S4ODYdODi+cuSJn\n\tyBcddud0qAdcUHjRN49HvmCKGx1xMnExKYdcUSFIO06ASHlB+s2ONn8P1EQxUTzz0PbN\n\t+7MXRzdIyQU+x4ceE1sggF/2er6z6d5QbmSfvjBUiYDcB5y3iL4fEMfcm9IYQg8Crq7M\n\txr8WTNPtNun1hhy9ekZXdgvk7X56wsaR2uf4buk0U8zwBSU3hNxjyHdj2R44gSm9z75t\n\tp+A68Xr7Rvb4NEBUgcUzLmkvHzE6LbpNSlCKI35uj8YHipXR9OILJK1pcalMBpk4Phl+\n\tSqxw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"h/2PvuOv\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1699613122; x=1700217922;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=7KBMCJLQhBzsuuW/fMdrs68y4Z1BYs2piiTZhacY4+4=;\n\tb=HgFNwpJWPXrYxSKkB//raHRI92L9QMNjaCo9weZOOwg2yl4tu2+lWZfyRFoI+YMmA7\n\tDTsp/HUbo4fQePrjACdvoyUNuAMAm6vM3atAHJTdnsJFB17aCBwp1O/b2lTbPv07dpSn\n\tZ2dkP91ws9P8x8kQMNVW0A7tcWAZlX9yUlmMxX+is+nkDxmyoQFi7PoIvHrw4bK8Wxz6\n\tMU9dg92rD/aTmqibdc1fSOWeBelgeFeZl6CaAbVhCpdJhszf9lIWY2Ub30psAYMsyG3W\n\twJcPaQe/wnwrqo8DTDXW5biik0dLjoiJR+PlKaQeBnyd/+tDatzgERDcqITvk1qqSK8T\n\tGk7A==","X-Gm-Message-State":"AOJu0YzyW66VZ5ybf0+jZlFhUjEY1sy/8V92Kf+c9RBCsn+cs//N5qVl\n\t6VssMVmEOAytqhu5RTdqWWDSYkNjA9robWXkscc=","X-Google-Smtp-Source":"AGHT+IHGomnOj28jca6IrjK8GAzA+xoxRzu1SL1UXEJiDT0vmWjwMpmBBVXU4lfHdN1VlI6R6RBKxA==","X-Received":"by 2002:a05:600c:19c8:b0:408:3c8a:65ec with SMTP id\n\tu8-20020a05600c19c800b004083c8a65ecmr7034306wmq.8.1699613122198; \n\tFri, 10 Nov 2023 02:45:22 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 10 Nov 2023 10:45:20 +0000","Message-Id":"<20231110104520.384229-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: rpi: agc: Fix bug where AeLocked was\n\tnever getting set","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The recent change where time-filtering is done before sorting out the\ndigital gain means that the target exposure without digital gain is no\nlonger set, breaking the 'AeLocked' calculation.\n\nWe can use the regular (full) target exposure instead.\n\nSigned-off-by: David Plowman \nFixes: 84b6327789fc (\"ipa: rpi: agc: Filter exposures before dealing with digital gain\")\n---\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rpi/controller/rpi/agc_channel.cpp b/src/ipa/rpi/controller/rpi/agc_channel.cpp\nindex 8d374b53..8116c6c1 100644\n--- a/src/ipa/rpi/controller/rpi/agc_channel.cpp\n+++ b/src/ipa/rpi/controller/rpi/agc_channel.cpp\n@@ -977,7 +977,7 @@ void AgcChannel::divideUpExposure()\n void AgcChannel::writeAndFinish(Metadata *imageMetadata, bool desaturate)\n {\n \tstatus_.totalExposureValue = filtered_.totalExposure;\n-\tstatus_.targetExposureValue = desaturate ? 0s : target_.totalExposureNoDG;\n+\tstatus_.targetExposureValue = desaturate ? 0s : target_.totalExposure;\n \tstatus_.shutterTime = filtered_.shutter;\n \tstatus_.analogueGain = filtered_.analogueGain;\n \t/*\n","prefixes":["libcamera-devel"]}