{"id":19190,"url":"https://patchwork.libcamera.org/api/1.1/patches/19190/?format=json","web_url":"https://patchwork.libcamera.org/patch/19190/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231102180916.3575006-1-kieran.bingham@ideasonboard.com>","date":"2023-11-02T18:09:16","name":"[libcamera-devel] libcamera: ipa: Add IMX335 support","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1f9f1b7b3d0e466cbe1e3c27043e79f802f37138","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19190/mbox/","series":[{"id":4065,"url":"https://patchwork.libcamera.org/api/1.1/series/4065/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4065","date":"2023-11-02T18:09:16","name":"[libcamera-devel] libcamera: ipa: Add IMX335 support","version":1,"mbox":"https://patchwork.libcamera.org/series/4065/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19190/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19190/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0DCFBDCBD\n\tfor ;\n\tThu, 2 Nov 2023 18:09:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1637361DC8;\n\tThu, 2 Nov 2023 19:09:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB27E61DC6\n\tfor ;\n\tThu, 2 Nov 2023 19:09:19 +0100 (CET)","from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43F14C58;\n\tThu, 2 Nov 2023 19:09:02 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698948562;\n\tbh=pzy5bsBdearxhieNhlomrSnF8RdembIdhV56ewSSqZQ=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=a/gtc3Nfl4MMXCGbMhzknjWbnf4ybqVx5CUQ7P0CJ/wfuS7tAbLQZk9OrK3WMwFZG\n\tdWACb48NFiE+cGo9AwZaoqJQ0GUoaL11mZJLqXvROgDurLfQzS4e04Q6BZkda5BrIc\n\t4O4E9yLy0TmvCXx5k472mLZYbmx2HZScMC4OJC1AidrFG+JxpRRqzYUYeeUfqgmEK0\n\tHonTAtuv8NES+V12m8f3rT4rUt7su98dfPiR8L1oEed65KGWKF2NTod4KPMWQzuxlI\n\tZeO6+n1s3DYtzgjBiA2npwjFesdfkAdVWvjeFCz1Jqc4szvsvZ0y+5cjbQLsC0Pc0x\n\thfS+Iuj1thMyQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698948542;\n\tbh=pzy5bsBdearxhieNhlomrSnF8RdembIdhV56ewSSqZQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=vaMLyARdw1REdbLTZ/FhCvEy2ZMLxgmEAZSSZv0dQPwBfs3xtQ1t2Ho3Ynqz5nkm7\n\tgdUB05DlVkQdbVmsECT5ZAA0aFfXKqt+v5KHhPgX6E6JDXOGEyLbyBdHG18YMfP/Gj\n\t+xbCJys2FxWo2E/I/Vnf8uTdL+Zv0o0f1GysNvOc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vaMLyARd\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Thu, 2 Nov 2023 18:09:16 +0000","Message-Id":"<20231102180916.3575006-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: ipa: Add IMX335 support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide support for the Sony IMX335 in both libipa and RaspberryPi IPA\nmodules.\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 23 ++++++\n src/ipa/rpi/cam_helper/cam_helper_imx335.cpp | 74 ++++++++++++++++++++\n src/ipa/rpi/cam_helper/meson.build | 1 +\n src/libcamera/camera_sensor_properties.cpp | 4 ++\n 4 files changed, 102 insertions(+)\n create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx335.cpp","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex f0ecc3830115..ddab5af6eac2 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -444,6 +444,29 @@ class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n \n+class CameraSensorHelperImx335 : public CameraSensorHelper\n+{\n+public:\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+private:\n+\tstatic constexpr uint32_t maxGainCode_ = 240;\n+};\n+\n+uint32_t CameraSensorHelperImx335::gainCode(double gain) const\n+{\n+\tuint32_t code = 10 * std::log10(gain) * 10 / 3;\n+\n+\treturn std::min(code, maxGainCode_);\n+}\n+\n+double CameraSensorHelperImx335::gain(uint32_t gainCode) const\n+{\n+\treturn std::pow(10.0, gainCode / (10 * 10 / 3));\n+}\n+\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx335\", CameraSensorHelperImx335)\n+\n class CameraSensorHelperImx477 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/ipa/rpi/cam_helper/cam_helper_imx335.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx335.cpp\nnew file mode 100644\nindex 000000000000..659c69d6b6c7\n--- /dev/null\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx335.cpp\n@@ -0,0 +1,74 @@\n+/* SPDX-License-Identifier: BSD-2-Clause */\n+/*\n+ * Copyright (C) 2023, Ideas on Board Oy.\n+ *\n+ * cam_helper_imx335.cpp - camera information for the Sony IMX335 sensor\n+ */\n+\n+#include \n+\n+#include \"cam_helper.h\"\n+#include \"math.h\"\n+\n+using namespace RPiController;\n+\n+class CamHelperImx335 : public CamHelper\n+{\n+public:\n+\tCamHelperImx335();\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+\tvoid getDelays(int &exposureDelay, int &gainDelay,\n+\t\t int &vblankDelay, int &hblankDelay) const override;\n+\tunsigned int hideFramesModeSwitch() const override;\n+\n+private:\n+\t/*\n+\t * Smallest difference between the frame length and integration time,\n+\t * in units of lines.\n+\t */\n+\tstatic constexpr int frameIntegrationDiff = 4;\n+\tstatic constexpr uint32_t maxGainCode = 240;\n+};\n+\n+/*\n+ * IMX335 Metadata isn't yet supported.\n+ */\n+\n+CamHelperImx335::CamHelperImx335()\n+\t: CamHelper({}, frameIntegrationDiff)\n+{\n+}\n+\n+uint32_t CamHelperImx335::gainCode(double gain) const\n+{\n+\tuint32_t code = 10 * std::log10(gain) * 10 / 3;\n+\treturn std::min(code, maxGainCode);\n+}\n+\n+double CamHelperImx335::gain(uint32_t gainCode) const\n+{\n+\treturn std::pow(10.0, gainCode / (10 * 10 / 3));\n+}\n+\n+void CamHelperImx335::getDelays(int &exposureDelay, int &gainDelay,\n+\t\t\t\tint &vblankDelay, int &hblankDelay) const\n+{\n+\texposureDelay = 2;\n+\tgainDelay = 2;\n+\tvblankDelay = 2;\n+\thblankDelay = 2;\n+}\n+\n+unsigned int CamHelperImx335::hideFramesModeSwitch() const\n+{\n+\t/* One bad frame can be expected after a mode switch. */\n+\treturn 1;\n+}\n+\n+static CamHelper *create()\n+{\n+\treturn new CamHelperImx335();\n+}\n+\n+static RegisterCamHelper reg(\"imx335\", &create);\ndiff --git a/src/ipa/rpi/cam_helper/meson.build b/src/ipa/rpi/cam_helper/meson.build\nindex bdf2db8eb742..17c25cb0e4a6 100644\n--- a/src/ipa/rpi/cam_helper/meson.build\n+++ b/src/ipa/rpi/cam_helper/meson.build\n@@ -6,6 +6,7 @@ rpi_ipa_cam_helper_sources = files([\n 'cam_helper_imx219.cpp',\n 'cam_helper_imx290.cpp',\n 'cam_helper_imx296.cpp',\n+ 'cam_helper_imx335.cpp',\n 'cam_helper_imx477.cpp',\n 'cam_helper_imx519.cpp',\n 'cam_helper_imx708.cpp',\ndiff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex 27d6799a2686..dc76051fa349 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -111,6 +111,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t.unitCellSize = { 2900, 2900 },\n \t\t\t.testPatternModes = {},\n \t\t} },\n+\t\t{ \"imx335\", {\n+\t\t\t.unitCellSize = { 2000, 2000 },\n+\t\t\t.testPatternModes = {},\n+\t\t} },\n \t\t{ \"imx477\", {\n \t\t\t.unitCellSize = { 1550, 1550 },\n \t\t\t.testPatternModes = {},\n","prefixes":["libcamera-devel"]}