{"id":1919,"url":"https://patchwork.libcamera.org/api/1.1/patches/1919/?format=json","web_url":"https://patchwork.libcamera.org/patch/1919/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190904125427.13943-5-jacopo@jmondi.org>","date":"2019-09-04T12:54:24","name":"[libcamera-devel,v4,4/7] android: camera_device: Add missing tags in request template","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"65286e87189441e4d317f5dc898762c8d95dff11","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1919/mbox/","series":[{"id":479,"url":"https://patchwork.libcamera.org/api/1.1/series/479/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=479","date":"2019-09-04T12:54:20","name":"android: Rework metadata tags","version":3,"mbox":"https://patchwork.libcamera.org/series/479/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1919/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1919/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0805C61929\n\tfor ;\n\tWed, 4 Sep 2019 14:53:08 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B88B624000D;\n\tWed, 4 Sep 2019 12:53:06 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi , kamesan@google.com, jcliang@google.com,\n\tshik@google.com, wtlee@google.com","Date":"Wed, 4 Sep 2019 14:54:24 +0200","Message-Id":"<20190904125427.13943-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20190904125427.13943-1-jacopo@jmondi.org>","References":"<20190904125427.13943-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 4/7] android: camera_device: Add\n\tmissing tags in request template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 12:53:08 -0000"},"content":"Add two missing tags from the request template generated by the HAL.\nThe tags are reported as missing by the cros_camera_test tool.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex bd69198ec482..969c8192c316 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -611,6 +611,17 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n \t\t\t&faceDetectMode, 1);\n \tMETADATA_ASSERT(ret);\n \n+\tuint8_t noiseReduction = ANDROID_NOISE_REDUCTION_MODE_OFF;\n+\tret = add_camera_metadata_entry(requestTemplate_,\n+\t\t\tANDROID_NOISE_REDUCTION_MODE, &noiseReduction, 1);\n+\tMETADATA_ASSERT(ret);\n+\n+\tuint8_t aberrationMode = ANDROID_COLOR_CORRECTION_ABERRATION_MODE_OFF;\n+\tret = add_camera_metadata_entry(requestTemplate_,\n+\t\t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n+\t\t\t&aberrationMode, 1);\n+\tMETADATA_ASSERT(ret);\n+\n \tret = add_camera_metadata_entry(requestTemplate_,\n \t\t\tANDROID_CONTROL_CAPTURE_INTENT,\n \t\t\t&captureIntent, 1);\n","prefixes":["libcamera-devel","v4","4/7"]}