{"id":19177,"url":"https://patchwork.libcamera.org/api/1.1/patches/19177/?format=json","web_url":"https://patchwork.libcamera.org/patch/19177/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231022224159.30298-9-laurent.pinchart@ideasonboard.com>","date":"2023-10-22T22:41:59","name":"[libcamera-devel,v6,21/12] libcamera: transform: Make the transformFromOrientation() function static","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0786c38a04999dc6a0181b159447a1795a83ead1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19177/mbox/","series":[{"id":4053,"url":"https://patchwork.libcamera.org/api/1.1/series/4053/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4053","date":"2023-10-19T14:01:21","name":"libcamera: Replace CameraConfiguration::transform","version":6,"mbox":"https://patchwork.libcamera.org/series/4053/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19177/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19177/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFF74C32B9\n\tfor ;\n\tSun, 22 Oct 2023 22:42:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82F236299B;\n\tMon, 23 Oct 2023 00:42:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4767D62990\n\tfor ;\n\tMon, 23 Oct 2023 00:42:02 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E752CD20;\n\tMon, 23 Oct 2023 00:41:51 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698014524;\n\tbh=MJ7wHvEOETCVJDNchxhDWGfJNlIODO9/4WptVnFI3Z0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fOTPeKoVonYRjs3nlGwUsVkBYmH1LE8reKjCjDYJGMVAWyuzPf9qdPnpEksin5y97\n\tycYIypn0xDj2q1ADKS4pFFIxRVC56wyMrz3lO5G6vQoCk0hCCJePfJtuI3uheZuQv9\n\tBHHnpV2+p6rCR6wp8XWiwQB9uFHN1rBh+PYkOtQVqDYQZISno0AtSijjWoPjsbYch3\n\t4REvzved3NV68CyFMEMqbmvVxjrbBdKw8Qr6vuFfAt2L2r7p+acNxqGW14sxuABXwl\n\tpnUgroqY4AYby7vFk/x8vjeFz9yV0TmyGI1quSw+k8lUfrhNjEq4ODDT8nKjnJ3TkT\n\tbU1h8dbhuYyPg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698014512;\n\tbh=MJ7wHvEOETCVJDNchxhDWGfJNlIODO9/4WptVnFI3Z0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cjaBZRrzNFlG9EtRiY2DGVXq6YzJb6/tJZtWNFoaIzxQvkcAiIwazV7n8wRYc/MhO\n\t0VxBjZg4Cm2O8yLWTi7eBbO5ST/wNEIeJCeSXmpgm/z989aU7K0eVTTSfXTfhWc9Xd\n\tLUM2dv66RdIZtr/gytK4tjC9XLqI2jbUrssNP4WM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cjaBZRrz\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Oct 2023 01:41:59 +0300","Message-ID":"<20231022224159.30298-9-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","In-Reply-To":"<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>","References":"<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 21/12] libcamera: transform: Make the\n\ttransformFromOrientation() function static","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that the transformFromOrientation() function isn't used outside of\ntransform.cpp, make it static to remove it from the public API.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/transform.h | 1 -\n src/libcamera/transform.cpp | 4 ++++\n 2 files changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\nindex 4998a6c04cb7..44cb4c6fc974 100644\n--- a/include/libcamera/transform.h\n+++ b/include/libcamera/transform.h\n@@ -71,7 +71,6 @@ constexpr Transform operator~(Transform t)\n }\n \n Transform transformFromRotation(int angle, bool *success = nullptr);\n-Transform transformFromOrientation(const Orientation &orientation);\n \n Transform operator/(const Orientation &o1, const Orientation &o2);\n Orientation operator*(const Orientation &o, const Transform &t);\ndiff --git a/src/libcamera/transform.cpp b/src/libcamera/transform.cpp\nindex cd2717c28c3a..fb2d55ac1931 100644\n--- a/src/libcamera/transform.cpp\n+++ b/src/libcamera/transform.cpp\n@@ -301,6 +301,8 @@ Transform transformFromRotation(int angle, bool *success)\n \treturn Transform::Identity;\n }\n \n+namespace {\n+\n /**\n * \\brief Return the transform representing \\a orientation\n * \\param[in] orientation The orientation to convert\n@@ -330,6 +332,8 @@ Transform transformFromOrientation(const Orientation &orientation)\n \treturn Transform::Identity;\n }\n \n+} /* namespace */\n+\n /**\n * \\brief Return the Transform that applied to \\a o2 gives \\a o1\n * \\param o1 The Orientation to obtain\n","prefixes":["libcamera-devel","v6","21/12"]}