{"id":19171,"url":"https://patchwork.libcamera.org/api/1.1/patches/19171/?format=json","web_url":"https://patchwork.libcamera.org/patch/19171/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231022224159.30298-4-laurent.pinchart@ideasonboard.com>","date":"2023-10-22T22:41:54","name":"[libcamera-devel,v6,16/12] fixup! libcamera: transform: Invert operator*() operands","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"18e9f72059c09d9ca9cdfb743811df0817d494eb","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19171/mbox/","series":[{"id":4053,"url":"https://patchwork.libcamera.org/api/1.1/series/4053/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4053","date":"2023-10-19T14:01:21","name":"libcamera: Replace CameraConfiguration::transform","version":6,"mbox":"https://patchwork.libcamera.org/series/4053/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19171/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19171/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94AC7C327D\n\tfor ;\n\tSun, 22 Oct 2023 22:42:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB8CF6298B;\n\tMon, 23 Oct 2023 00:42:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBB046297F\n\tfor ;\n\tMon, 23 Oct 2023 00:41:55 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 80AC2749;\n\tMon, 23 Oct 2023 00:41:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698014520;\n\tbh=68riQlISkZJCXaML5fDwxRa+HhSre6E/lhJjRdCvqrY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Ut0REliPP/1mXBqj7GbZz2CpUcA2smVy6eid0ao7L5MrMqa1SjJk5Uxj1D+rOZ7/y\n\tq3N1M8f32DZ6DVXUUWThpi7knN5yHw2b4bnBl1s/JTaCpbCKRDBCK2JNPM5OHuvuCy\n\t7+s3/sM8CK1wmmIULDd/e/aSwm5PBKm9wUsYvbTdRx4ImGIXdsAcUwMe0Rsw1dZNBe\n\tk8MbiZuCucGPpGR8SrDnQTxUxsDT+odejV115FQeNm9uqzDkMxFfbcQ6GIBs/j8Cyv\n\tuqkwUxAVOGDepHPDJ3oSPGCQDQMOY6odUgFVRKmBvvJevjeq/rRywTroiRWXMgMAyP\n\tKtKVwBW7pjHjw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698014505;\n\tbh=68riQlISkZJCXaML5fDwxRa+HhSre6E/lhJjRdCvqrY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QB2El6V9rNirFrmqLM4zT64Bqg0eoJBQ+pS7FZ8v+5MtVw0Yn5Tdlvu2XNRtuAPlB\n\tqEBKZU3LEpN5zNkvRvPtWiAT7BsxM2dWy4ESnlxQqzhqmVIZDIei7Q8X7EmMW7PcgO\n\tMIg4hQPl/0ldscf9nYxjetjCNIcWlsxrOOGvXBYs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QB2El6V9\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Oct 2023 01:41:54 +0300","Message-ID":"<20231022224159.30298-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","In-Reply-To":"<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>","References":"<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 16/12] fixup! libcamera: transform:\n\tInvert operator*() operands","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"- Simplify documentation\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/transform.cpp | 17 +++++++----------\n 1 file changed, 7 insertions(+), 10 deletions(-)","diff":"diff --git a/src/libcamera/transform.cpp b/src/libcamera/transform.cpp\nindex 85bc2d28b0cd..0ccdb42fa406 100644\n--- a/src/libcamera/transform.cpp\n+++ b/src/libcamera/transform.cpp\n@@ -193,21 +193,18 @@ Input image | | goes to output image | |\n * \\param[in] t0 The first transform to apply\n * \\param[in] t1 The second transform to apply\n *\n- * Compose two transforms by applying \\a t1 after \\a t0. The operation\n- * is conceptually equivalent to the canonical notion of function composition,\n- * with inverse order of operands. If in the canonical function composition\n- * notation \"f * g\" equals to \"f(g())\", the notation for Transforms composition\n- * \"t0 * t1\" equals to \"t1(t0()))\" where \\a t0 is applied first, then \\a t1.\n- *\n- * For example, `HFlip * Transpose` performs `HFlip` first and then the\n- * `Transpose` yielding `Rot270`, as shown below.\n+ * Compose two transforms into a transform that is equivalent to first applying\n+ * \\a t0 and then applying \\a t1. For example, `HFlip * Transpose` performs\n+ * `HFlip` first and then the `Transpose` yielding `Rot270`, as shown below.\n ~~~\n A-B B-A B-D\n Input image | | -> HFLip -> | | -> Transpose -> | | = Rot270\n C-D D-C A-C\n ~~~\n- * Note that composition is generally non-commutative for Transforms,\n- * and not the same as XOR-ing the underlying bit representations.\n+ * Note that composition is generally non-commutative for Transforms, and not\n+ * the same as XOR-ing the underlying bit representations.\n+ *\n+ * \\return A Transform equivalent to applying \\a t0 and then \\a t1\n */\n Transform operator*(Transform t0, Transform t1)\n {\n","prefixes":["libcamera-devel","v6","16/12"]}