{"id":19106,"url":"https://patchwork.libcamera.org/api/1.1/patches/19106/?format=json","web_url":"https://patchwork.libcamera.org/patch/19106/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231006132000.23504-5-naush@raspberrypi.com>","date":"2023-10-06T13:19:44","name":"[libcamera-devel,04/20] ipa: rpi: Add IpaBase::platformStart() member function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c1c508af0897280a212f0dab9b2a3020a86c9fe1","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19106/mbox/","series":[{"id":4047,"url":"https://patchwork.libcamera.org/api/1.1/series/4047/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4047","date":"2023-10-06T13:19:40","name":"Raspberry Pi: Preliminary PiSP support","version":1,"mbox":"https://patchwork.libcamera.org/series/4047/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19106/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19106/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2BA8BD808\n\tfor ;\n\tFri, 6 Oct 2023 13:20:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60E6762971;\n\tFri, 6 Oct 2023 15:20:04 +0200 (CEST)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CFBC6296B\n\tfor ;\n\tFri, 6 Oct 2023 15:20:01 +0200 (CEST)","by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-406619b53caso18758485e9.1\n\tfor ;\n\tFri, 06 Oct 2023 06:20:01 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tm8-20020a056000180800b00321773bb933sm1639478wrh.77.2023.10.06.06.19.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 06 Oct 2023 06:20:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1696598404;\n\tbh=9ZDDvTxPOZsT2Xs9ZsTNX9mUbI9BoXmsCquizANYbFQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=uUGaFpAOyl6f4sVuWYcbJIKSbAf4KTGFdcOwUvzlsZ6xVt1hkssap9vnKs/toHGmr\n\tkCevA3g2ztTEmQt2IqLITD5Sl0JzVkGWY40DdGNfq2KrBh99iqTMVTcICww8vWTA3Q\n\tc1a5i5OgvcQoC5+cJGNKRSzEAczA5xdLe/kNQLilJ6U3zN62rIijs8MrYrTD1YC38x\n\tRlFS54PgSKFqMdYXda+bsdNhjE7T+wAxhprERe7eTR2r+bCOjPa+U7sCIxEsj7rejg\n\t+284VdWe+anU/RaMlOwK1gyiS2bVyOVuuXFnlGBhl3Rj0tqIErWy+1mOhBRVe8X3fb\n\tkxwmwjvfY0znQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1696598401; x=1697203201;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=3C7R0572Ac27bu5Wt1ogqZJgDpUoBbC5YoWlWcVDKLY=;\n\tb=fO0JsH3MV/1znDZDChDmkH83d50fmBZD96h9M7LdY7JB1y/NMF+I4nnNtShJdEpNam\n\tBQPqUTed3KcB3gl8TMHgIWl0/BaCk7yoxB+tkdlv3dpEqMuWHuE1k8UIwnQ79Y2e1/EV\n\ttCk13Xs+zFGzB8R3DwTOC8+BrU4HJTMEIANzYUwP+eJ8u0+7+edhVGV2jBZK40xoEA2F\n\tw4HNsgjGlhCIdwKFVPcHOIC16vAwrbM7/E+PG5V/btu4idzky4DMvdFQ2ju3ySp1Z3C2\n\tm2T1uiQ0Nlf9k7Zb0KX94+NC6MQAyAholIG3d1KQayQFUBFralEM4oSZIjBtp/5yiW1R\n\t7/oA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"fO0JsH3M\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1696598401; x=1697203201;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=3C7R0572Ac27bu5Wt1ogqZJgDpUoBbC5YoWlWcVDKLY=;\n\tb=rUeMhanboa75hiDr998tgsdikw9y4Csao/i47MVQb2OORaYLUFYeRX7kbB6kmFiegp\n\tztUtLvk54iwN+e5YBU4ShAe6suEqyCZWoh1JZ/ImEVHCETdK+xmvwmvWncP5K9ggmWum\n\tLGqrKLVVVV7+MK6X+YZhS9ZCYjKybUKSmB/M2Vuaf+vbJalUT2UYzYTTBXapM7PWhy+E\n\tinNVMl8Jm6dXL0/aBae/CK02VVGSX6y0ME5zujHgzsnVREbZFFCTlxkexiZ62XkMgpQh\n\t/OCOFKal0scZrLAgBt/NJgq0beTAzsOKc1tBfOpfeuvc1kFgqKn1bT2Di/Z30A4xxj8a\n\tCjsA==","X-Gm-Message-State":"AOJu0Yx1BmZOhJbkr9TsOpcSgZH9UMVLYlm9mg7D1O0UfRbi/WUNTfmL\n\tfM8Lsa7q0fvQThnv3hWaz/MQV1KDy+imQjxSmISf+g==","X-Google-Smtp-Source":"AGHT+IGQnXIGs0ckmEpBHr8qKRiW5OpYZ8s1DtQFZ22L/8SRpwTW+D2PlMXoYB2hiIdoqUrSsQZnBg==","X-Received":"by 2002:adf:f404:0:b0:31c:3136:60af with SMTP id\n\tg4-20020adff404000000b0031c313660afmr6428510wro.61.1696598400999; \n\tFri, 06 Oct 2023 06:20:00 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Oct 2023 14:19:44 +0100","Message-Id":"<20231006132000.23504-5-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20231006132000.23504-1-naush@raspberrypi.com>","References":"<20231006132000.23504-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 04/20] ipa: rpi: Add\n\tIpaBase::platformStart() member function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a virtual IpaBase::platformStart() member function that is called\nat the end of IpaBase::start(). For the IpaVc4 derived class, this\nfunction does nothing, but will be used in the PiSP derived class to\nreset internal state on startup.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \n---\n src/ipa/rpi/common/ipa_base.cpp | 2 ++\n src/ipa/rpi/common/ipa_base.h | 1 +\n src/ipa/rpi/vc4/vc4.cpp | 7 +++++++\n 3 files changed, 10 insertions(+)","diff":"diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 5df1998c8113..5939fe57f040 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -341,6 +341,8 @@ void IpaBase::start(const ControlList &controls, StartResult *result)\n \n \tfirstStart_ = false;\n \tlastRunTimestamp_ = 0;\n+\n+\tplatformStart(controls, result);\n }\n \n void IpaBase::mapBuffers(const std::vector &buffers)\ndiff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\nindex 097f436af93b..eaa9f71182ed 100644\n--- a/src/ipa/rpi/common/ipa_base.h\n+++ b/src/ipa/rpi/common/ipa_base.h\n@@ -67,6 +67,7 @@ private:\n \tstatic constexpr unsigned int numMetadataContexts = 16;\n \n \tvirtual int32_t platformInit(const InitParams ¶ms, InitResult *result) = 0;\n+\tvirtual int32_t platformStart(const ControlList &controls, StartResult *result) = 0;\n \tvirtual int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) = 0;\n \n \tvirtual void platformPrepareIsp(const PrepareParams ¶ms,\ndiff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp\nindex 1de0d3ccdc44..4a4d720ce7dd 100644\n--- a/src/ipa/rpi/vc4/vc4.cpp\n+++ b/src/ipa/rpi/vc4/vc4.cpp\n@@ -51,6 +51,7 @@ public:\n \n private:\n \tint32_t platformInit(const InitParams ¶ms, InitResult *result) override;\n+\tint32_t platformStart(const ControlList &controls, StartResult *result) override;\n \tint32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) override;\n \n \tvoid platformPrepareIsp(const PrepareParams ¶ms, RPiController::Metadata &rpiMetadata) override;\n@@ -94,6 +95,12 @@ int32_t IpaVc4::platformInit([[maybe_unused]] const InitParams ¶ms, [[maybe_\n \treturn 0;\n }\n \n+int32_t IpaVc4::platformStart([[maybe_unused]] const ControlList &controls,\n+\t\t\t [[maybe_unused]] StartResult *result)\n+{\n+\treturn 0;\n+}\n+\n int32_t IpaVc4::platformConfigure(const ConfigParams ¶ms, [[maybe_unused]] ConfigResult *result)\n {\n \tispCtrls_ = params.ispControls;\n","prefixes":["libcamera-devel","04/20"]}