{"id":19088,"url":"https://patchwork.libcamera.org/api/1.1/patches/19088/?format=json","web_url":"https://patchwork.libcamera.org/patch/19088/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230925170919.301540-1-kieran.bingham@ideasonboard.com>","date":"2023-09-25T17:09:19","name":"[libcamera-devel,14/13] apps: qcam: Add option to configure sensor","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8ae77f4e8a8a452c2fef61b1ca8d66b2cca04b9c","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19088/mbox/","series":[{"id":4034,"url":"https://patchwork.libcamera.org/api/1.1/series/4034/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4034","date":"2023-09-21T16:55:37","name":"libcamera: Introduce SensorConfiguration","version":5,"mbox":"https://patchwork.libcamera.org/series/4034/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19088/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19088/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38CA6BD808\n\tfor ;\n\tMon, 25 Sep 2023 17:09:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F0EC62944;\n\tMon, 25 Sep 2023 19:09:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 255EA628FA\n\tfor ;\n\tMon, 25 Sep 2023 19:09:32 +0200 (CEST)","from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADF9A13C5;\n\tMon, 25 Sep 2023 19:07:51 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695661773;\n\tbh=mOAhWaYS94aJWI+MYiMnRTt8MBKEteFTUQSCqRi7Qx8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=vqbEZOI20jlWPtwZJSGkAeOcwd3kfp6uaJb0FqiOsLNaP1xNO+XxRNrS9Vk50HTRI\n\tPjda2fY7yc9JlcJikkfuNBSGOgaHL9MUavRX+BURL47NYuORTMcNT/QnCWXpTi3i0Z\n\ta2JhWFtXRdzz4Un18vNgk+/RkoDm+irQXfAxjTntWXVni6kUtRfdpEbl9VVi8/C65M\n\tt59lVI1fbYDmuuY3Ao9go0Q9kPv89F+KMSMY1Pg/+GtPhsdq10VUdE2EUyce8bIQau\n\teUsPPSPfAPHoG4Q/tecdyWtx59hKo1uXWOALiwLmk1JuQnXNOIITWd/G6qYbSRjR+Y\n\t0vbb3WDP6/KgA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695661671;\n\tbh=mOAhWaYS94aJWI+MYiMnRTt8MBKEteFTUQSCqRi7Qx8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WOZyQP6U5xGMibNAi9df1CmKLrdGwBdf4aMC9+6o+RUjdcO9g27HpyO06gAoOdYr1\n\tJnmBQ/AOnbM4zZIKl6jl203/HWevQR45WSXa+z5j6SgT2AA979/WaJhLiHKhXDNE5q\n\tMg10LXBt0o6zb7yWRXR7/S/czJ6aKT8CaCm+1Xwk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WOZyQP6U\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Mon, 25 Sep 2023 18:09:19 +0100","Message-Id":"<20230925170919.301540-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>","References":"<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 14/13] apps: qcam: Add option to configure\n\tsensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a '-f|--sensor_format' option to qcam to allow forcing a sensor\nconfiguration from the command line.\n\nAs an example:\nqcam -f width=3840,height=2160,bitDepth=10\n\nSigned-off-by: Kieran Bingham \n---\n\nExtending Jacopo's implementation for cam to qcam\nHelpful for testing with visual display of the selected modes.\n\n src/apps/qcam/main.cpp | 3 +++\n src/apps/qcam/main_window.cpp | 7 +++++++\n src/apps/qcam/main_window.h | 1 +\n 3 files changed, 11 insertions(+)","diff":"diff --git a/src/apps/qcam/main.cpp b/src/apps/qcam/main.cpp\nindex 36cb93a53701..7e3f252e9f09 100644\n--- a/src/apps/qcam/main.cpp\n+++ b/src/apps/qcam/main.cpp\n@@ -30,6 +30,7 @@ void signalHandler([[maybe_unused]] int signal)\n OptionsParser::Options parseOptions(int argc, char *argv[])\n {\n \tStreamKeyValueParser streamKeyValue;\n+\tSensorKeyValueParser sensorKeyValue;\n \n \tOptionsParser parser;\n \tparser.addOption(OptCamera, OptionString,\n@@ -42,6 +43,8 @@ OptionsParser::Options parseOptions(int argc, char *argv[])\n \t\t\t \"renderer\", ArgumentRequired, \"renderer\");\n \tparser.addOption(OptStream, &streamKeyValue,\n \t\t\t \"Set configuration of a camera stream\", \"stream\", true);\n+\tparser.addOption(OptSensorFmt, &sensorKeyValue,\n+\t\t\t \"Apply a format to the sensor\", \"sensor_format\", true);\n \tparser.addOption(OptVerbose, OptionNone,\n \t\t\t \"Print verbose log messages\", \"verbose\");\n \ndiff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\nindex 0f16c038d516..e7511b4c7aa4 100644\n--- a/src/apps/qcam/main_window.cpp\n+++ b/src/apps/qcam/main_window.cpp\n@@ -414,6 +414,13 @@ int MainWindow::startCapture()\n \t\treturn -EINVAL;\n \t}\n \n+\t/* Apply a sensor configuration if requested. */\n+\tif (SensorKeyValueParser::updateConfiguration(config_.get(),\n+\t\t\t\t\t\t options_[OptSensorFmt])) {\n+\t\tqWarning() << \"Failed to apply sensor configuration\";\n+\t\treturn -EINVAL;\n+\t}\n+\n \tCameraConfiguration::Status validation = config_->validate();\n \tif (validation == CameraConfiguration::Invalid) {\n \t\tqWarning() << \"Failed to create valid camera configuration\";\ndiff --git a/src/apps/qcam/main_window.h b/src/apps/qcam/main_window.h\nindex 2e3e1b5c83c2..44646a87cfbf 100644\n--- a/src/apps/qcam/main_window.h\n+++ b/src/apps/qcam/main_window.h\n@@ -42,6 +42,7 @@ enum {\n \tOptHelp = 'h',\n \tOptRenderer = 'r',\n \tOptStream = 's',\n+\tOptSensorFmt = 'f',\n \tOptVerbose = 'v',\n };\n \n","prefixes":["libcamera-devel","14/13"]}