{"id":19043,"url":"https://patchwork.libcamera.org/api/1.1/patches/19043/?format=json","web_url":"https://patchwork.libcamera.org/patch/19043/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230916121930.29490-6-jacopo.mondi@ideasonboard.com>","date":"2023-09-16T12:19:23","name":"[libcamera-devel,v4,05/12] libcamera: rpi: Allow platformValidate() to adjust format strides","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1047eb03c5e678d3f33aaa767dff89fa5b8a6e06","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19043/mbox/","series":[{"id":4027,"url":"https://patchwork.libcamera.org/api/1.1/series/4027/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4027","date":"2023-09-16T12:19:18","name":"libcamera: Introduce SensorConfiguration","version":4,"mbox":"https://patchwork.libcamera.org/series/4027/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19043/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19043/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2635CBD160\n\tfor ;\n\tSat, 16 Sep 2023 12:19:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B51CE6291F;\n\tSat, 16 Sep 2023 14:19:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A278162911\n\tfor ;\n\tSat, 16 Sep 2023 14:19:39 +0200 (CEST)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 881C91536;\n\tSat, 16 Sep 2023 14:18:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694866785;\n\tbh=QfR+JclEnCYqYSFFstRnyrbg8ePcbMNcod+QMO9f+wQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=LfYQ2gXr14ts9qxW5AfIITiICEDC0zPEQcYzKfviTtk9XH5HAtLlut+keo7tfyxGr\n\t53l8ndlvEXptiKa4nsI3GBrSxqvSsDCT0i2xw/V9Igo8Vr529AAS3/UF+NaPWnVobF\n\t88kVk3O5w2CkemAl/nr9vRZhnQAS4SJ6ZcD30XBHvNnypfWmwTbn9+YU0pDtg5XLJ4\n\tHFexbDY0uhs4j1n0DKiBBcCKYxkjpz6R5OLfGoQxzPFuenghOitLjKg2zJqbKd/KmD\n\tdmmODVz+3ySxUUiUa3c7SOD8BDinSDP/TosuellyRveZRiWC5uRUb/eYwa8YsJpjQW\n\tBpXCSi22LQSKA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1694866685;\n\tbh=QfR+JclEnCYqYSFFstRnyrbg8ePcbMNcod+QMO9f+wQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DY6sQi6WC1srU0fNNaqgOr/Z92TjOCLSm4unVQyQZBS6tibGVA/QQYj8KlcHZa/sI\n\tmQsjQVfv8yaTx0N2VL1SzasdQ6NQBP2okzB+0ZaFgO4N2PqXi6el2wUoCwqrqIIUms\n\tTEhtusxSR5wTTqF91A6qeAA8FhdyJR9RA9+HA7FY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DY6sQi6W\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 16 Sep 2023 14:19:23 +0200","Message-ID":"<20230916121930.29490-6-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.42.0","In-Reply-To":"<20230916121930.29490-1-jacopo.mondi@ideasonboard.com>","References":"<20230916121930.29490-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 05/12] libcamera: rpi: Allow\n\tplatformValidate() to adjust format strides","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Naushir Patuck \n\nPropagate any changes to the format stride done by platformValidate().\nThe stride value may be adjusted for performace reasons.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Jacopo Mondi \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 4d0d150ccf0c..566aa8f3211e 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -305,6 +305,17 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \t\tV4L2DeviceFormat format;\n \t\tformat.fourcc = out.dev->toV4L2PixelFormat(cfg.pixelFormat);\n \t\tformat.size = cfg.size;\n+\n+\t\t/*\n+\t\t * platformValidate may have worked out the correct stride so we\n+\t\t * must pass it in. This also needs the planesCount to be set\n+\t\t * correctly or the stride will be ignored.\n+\t\t */\n+\t\tconst PixelFormat &pixFormat = format.fourcc.toPixelFormat();\n+\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(pixFormat);\n+\t\tformat.planesCount = info.numPlanes();\n+\t\tformat.planes[0].bpl = cfg.stride;\n+\n \t\t/* We want to send the associated YCbCr info through to the driver. */\n \t\tformat.colorSpace = yuvColorSpace_;\n \n","prefixes":["libcamera-devel","v4","05/12"]}