{"id":19011,"url":"https://patchwork.libcamera.org/api/1.1/patches/19011/?format=json","web_url":"https://patchwork.libcamera.org/patch/19011/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230915-libyuv-convert-v1-5-1e5bcf68adac@baylibre.com>","date":"2023-09-15T07:57:29","name":"[libcamera-devel,RFC,5/7] android: camera_stream: add add explicit input configuration","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8a4df2a0f422f155bbfc558587acfbf01a068f6c","submitter":{"id":153,"url":"https://patchwork.libcamera.org/api/1.1/people/153/?format=json","name":"Mattijs Korpershoek","email":"mkorpershoek@baylibre.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19011/mbox/","series":[{"id":4023,"url":"https://patchwork.libcamera.org/api/1.1/series/4023/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4023","date":"2023-09-15T07:57:24","name":"android: add YUYV->NV12 conversion via libyuv","version":1,"mbox":"https://patchwork.libcamera.org/series/4023/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19011/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19011/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97091C3260\n\tfor ;\n\tFri, 15 Sep 2023 07:57:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 265EE62925;\n\tFri, 15 Sep 2023 09:57:35 +0200 (CEST)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4771F62921\n\tfor ;\n\tFri, 15 Sep 2023 09:57:31 +0200 (CEST)","by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-402cc6b8bedso21187035e9.1\n\tfor ;\n\tFri, 15 Sep 2023 00:57:31 -0700 (PDT)","from [192.168.1.20] ([2a01:cb19:8704:be00:4f55:bd9d:611a:6c8e])\n\tby smtp.gmail.com with ESMTPSA id\n\tm2-20020a056000174200b0031fe9a47a87sm2506942wrf.112.2023.09.15.00.57.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 15 Sep 2023 00:57:30 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694764655;\n\tbh=jVKLL5QEF5z5C0TNFbo0tgqqRfWikpDWJ129oNMsrl0=;\n\th=Date:References:In-Reply-To:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Yk1bCfA91vEmPWOSkYqt/ARouZOmxndzhsFS5dOp5NATGmZ8lZQJKcsG3VUJLjybs\n\tSs7TCNwoWrRaF3V5YcyPUe035ovtvOjMDfUvXiiK+Grag+gR/k0sHbLv7gS3N6mziv\n\tQ0Lvm1vCDEPIvsvzRxDrAtXzfUqs37aJJcFESwhvgwY/QzAtHL/r8BqrQhFEo4wyEo\n\tLcFTJnx6afNRzaYXD35Cgl2j8ZwEBwN9uH03gFV949qdjwdfm76scIx2hIqTw/08eF\n\tCHvIIm4M2kasiM53rQ7t7q/2H1QavXTpF9jypujt1DqKTXbLhPt56/LaK0GBHInPjx\n\tk6sMjPPHH4SBg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1694764650;\n\tx=1695369450; darn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=7Yd76vAKqd9nCx1+b0DVl9wG9TBhJs7jAHDcebruqiE=;\n\tb=JlmqQ/hU5CxrdP7dFcuKk3cvEqHMxjvbLlghZ85mdx0KX2gB2ScDHb7T5sI7bszUuI\n\te7DI2ZkLY/PZ2tHF6LtOuxbggzf5iP7BTuzOLHSu6ASSQzGK3ZFBUPxOPo7JqdvonNQc\n\tRvhY99CGvgPdbpHqLHNj0/5WvcmFz9xPshHrTzNb/yAyLWr4xgtZBocftelanMus0r1Q\n\t1cE3ut1v/jJp962G8gY5d0hvpfI2xgFN/UU/jYHhXsPh1EWdIiAMeBt67cG80NAr3J5U\n\tVsHYEK03YfOfzGpjRQ/XamGIRQhC/fJ4kbwbucLyQ7bnjCHyyoDzawQdGTq5aR2Wt3js\n\t28Rg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20230601.gappssmtp.com\n\theader.i=@baylibre-com.20230601.gappssmtp.com header.b=\"JlmqQ/hU\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1694764650; x=1695369450;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=7Yd76vAKqd9nCx1+b0DVl9wG9TBhJs7jAHDcebruqiE=;\n\tb=Nv7UMmFBCsZLJdesOrgYutftK6/a5oYE/4+/djDm/l1kTjzDmaxBjuvorC+npzCBFu\n\t27kr6G6/n7qIiYscNymYzqSUAh2shbBy1z9TDtsKlZy0ArY6cSLcP3Qt2LwV9wv+3jv9\n\t5N/bEw/LOHITeokyl2Z5odirft27US5/rQYCRB0ExhF5zzFuqJbaUxhds5fBnhe6/him\n\ttqJUM/QBoO12Uo0+Ghwjn32+HlCNTT8tkdVVnOnLXpSdsQeGuEd8kTmIPZYj5EsQisOH\n\tX1ujBHdAe029JYrXRZ1ze8fz/ONPOqwwTh1QumEVUC30zgGYgaD86qDmXq6GuPOhwrX4\n\t4CvQ==","X-Gm-Message-State":"AOJu0YyR71EdZIe1v7W/GPMPQhWxCx/43LfhPIMw9tT+AFdz+a+DSWh6\n\t7P3CuOCVXahoB0AF/bjQF3wslg==","X-Google-Smtp-Source":"AGHT+IHP8tAsP3EL6+g/m2wKXhxeM8R24gXxBLlhhy0By/5lmTstw9JxaZuOhknj7d2gzDFgpJZ8uw==","X-Received":"by 2002:adf:e845:0:b0:31a:d6cb:7f94 with SMTP id\n\td5-20020adfe845000000b0031ad6cb7f94mr692758wrn.23.1694764650741; \n\tFri, 15 Sep 2023 00:57:30 -0700 (PDT)","Date":"Fri, 15 Sep 2023 09:57:29 +0200","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20230915-libyuv-convert-v1-5-1e5bcf68adac@baylibre.com>","References":"<20230915-libyuv-convert-v1-0-1e5bcf68adac@baylibre.com>","In-Reply-To":"<20230915-libyuv-convert-v1-0-1e5bcf68adac@baylibre.com>","To":"libcamera-devel@lists.libcamera.org","X-Mailer":"b4 0.12.4-dev-6aa5d","Subject":"[libcamera-devel] [PATCH RFC 5/7] android: camera_stream: add add\n\texplicit input configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mattijs Korpershoek via libcamera-devel\n\t","Reply-To":"Mattijs Korpershoek ","Cc":"Guillaume La Roque ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"PostProcessors are configured using and input StreamConfigurations.\nRight now, we use configuration() for the input StreamConfiguration.\n\nUse an intermediate variable instead, to prepare for software conversion using libyuv.\n\nSigned-off-by: Mattijs Korpershoek \n---\n src/android/camera_stream.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex 045e60061a20..4fd05dda5ed3 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -87,6 +87,7 @@ int CameraStream::configure()\n \tif (type_ == Type::Internal || type_ == Type::Mapped) {\n \t\tconst PixelFormat outFormat =\n \t\t\tcameraDevice_->capabilities()->toPixelFormat(camera3Stream_->format);\n+\t\tStreamConfiguration input = configuration();\n \t\tStreamConfiguration output = configuration();\n \t\toutput.pixelFormat = outFormat;\n \t\toutput.size.width = camera3Stream_->width;\n@@ -106,7 +107,7 @@ int CameraStream::configure()\n \t\t\treturn -EINVAL;\n \t\t}\n \n-\t\tint ret = postProcessor_->configure(configuration(), output);\n+\t\tint ret = postProcessor_->configure(input, output);\n \t\tif (ret)\n \t\t\treturn ret;\n \n","prefixes":["libcamera-devel","RFC","5/7"]}