{"id":1892,"url":"https://patchwork.libcamera.org/api/1.1/patches/1892/?format=json","web_url":"https://patchwork.libcamera.org/patch/1892/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190829232653.13214-6-niklas.soderlund@ragnatech.se>","date":"2019-08-29T23:26:44","name":"[libcamera-devel,v2,05/14] libcamera: pipeline: Add callback to initialize IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"59fddff649a6205c930c83af0b5699e192f4bdcb","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1892/mbox/","series":[{"id":475,"url":"https://patchwork.libcamera.org/api/1.1/series/475/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=475","date":"2019-08-29T23:26:40","name":"libcamera: ipa: Add basic IPA support","version":2,"mbox":"https://patchwork.libcamera.org/series/475/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1892/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1892/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A43E060BE5\n\tfor ;\n\tFri, 30 Aug 2019 01:27:32 +0200 (CEST)","from bismarck.berto.se (unknown [79.202.45.17])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 8fee1d91-cab4-11e9-837a-0050569116f7;\n\tFri, 30 Aug 2019 01:27:27 +0200 (CEST)"],"X-Halon-ID":"8fee1d91-cab4-11e9-837a-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Aug 2019 01:26:44 +0200","Message-Id":"<20190829232653.13214-6-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.22.1","In-Reply-To":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>","References":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 05/14] libcamera: pipeline: Add\n\tcallback to initialize IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 29 Aug 2019 23:27:33 -0000"},"content":"Add a callback so the IPA can be initialized before a camera is exposed\nto an application.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/include/pipeline_handler.h | 2 ++\n src/libcamera/pipeline_handler.cpp | 20 ++++++++++++++++++++\n 2 files changed, 22 insertions(+)","diff":"diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\nindex 91d40ef40a465c4e..ca40e7ef2b85f372 100644\n--- a/src/libcamera/include/pipeline_handler.h\n+++ b/src/libcamera/include/pipeline_handler.h\n@@ -43,6 +43,8 @@ public:\n \t}\n \tvirtual ~CameraData() {}\n \n+\tvirtual int initIPA() { return 0; };\n+\n \tCamera *camera_;\n \tPipelineHandler *pipe_;\n \tstd::list queuedRequests_;\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 846272485c7d2fc0..613751619a398968 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -66,6 +66,20 @@ LOG_DEFINE_CATEGORY(Pipeline)\n * is needed for the camera both parameters should be set to 0.\n */\n \n+/**\n+ * \\fn CameraData::initIPA()\n+ * \\brief Callback to initialize the IPA\n+ *\n+ * This callback is called once a IPA have been associated with the camera.\n+ * It allows the CameraData to preform initialization of the IPA before the\n+ * camera is registered in the system.\n+ *\n+ * If this callback returns an error, the camera it represents will not be\n+ * registered in the system.\n+ *\n+ * \\return 0 on success or a negative error code otherwise\n+ */\n+\n /**\n * \\var CameraData::camera_\n * \\brief The camera related to this CameraData instance\n@@ -461,6 +475,12 @@ void PipelineHandler::registerCamera(std::shared_ptr camera,\n \t\t\t\t\t << \" no IPA found\";\n \t\t\treturn;\n \t\t}\n+\n+\t\tif (data->initIPA()) {\n+\t\t\tLOG(Pipeline, Warning) << \"Skipping \" << camera->name()\n+\t\t\t\t<< \" initialization of camera data failed\";\n+\t\t\treturn;\n+\t\t}\n \t}\n \n \tcameraData_[camera.get()] = std::move(data);\n","prefixes":["libcamera-devel","v2","05/14"]}