{"id":1889,"url":"https://patchwork.libcamera.org/api/1.1/patches/1889/?format=json","web_url":"https://patchwork.libcamera.org/patch/1889/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190829232653.13214-3-niklas.soderlund@ragnatech.se>","date":"2019-08-29T23:26:41","name":"[libcamera-devel,v2,02/14] libcamera: pipeline: vimc: Increase version of dummy IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f29816df463edee9c150b06151c9547a1b004f11","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1889/mbox/","series":[{"id":475,"url":"https://patchwork.libcamera.org/api/1.1/series/475/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=475","date":"2019-08-29T23:26:40","name":"libcamera: ipa: Add basic IPA support","version":2,"mbox":"https://patchwork.libcamera.org/series/475/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1889/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1889/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2534260BE5\n\tfor ;\n\tFri, 30 Aug 2019 01:27:31 +0200 (CEST)","from bismarck.berto.se (unknown [79.202.45.17])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 8ea029a1-cab4-11e9-837a-0050569116f7;\n\tFri, 30 Aug 2019 01:27:25 +0200 (CEST)"],"X-Halon-ID":"8ea029a1-cab4-11e9-837a-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Aug 2019 01:26:41 +0200","Message-Id":"<20190829232653.13214-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.22.1","In-Reply-To":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>","References":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 02/14] libcamera: pipeline: vimc:\n\tIncrease version of dummy IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 29 Aug 2019 23:27:31 -0000"},"content":"An IPA version number of 0 will be redefined as No IPA support. Increase\nthe VIMC dummy IPA version to 1 to allow it to keep loading.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \n---\n src/ipa/ipa_dummy.cpp | 2 +-\n src/libcamera/pipeline/vimc.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp\nindex 2fe232295c676941..09f1b96a8f3d5c36 100644\n--- a/src/ipa/ipa_dummy.cpp\n+++ b/src/ipa/ipa_dummy.cpp\n@@ -23,7 +23,7 @@ class IPADummy : public IPAInterface\n extern \"C\" {\n const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n-\t0,\n+\t1,\n \t\"PipelineHandlerVimc\",\n \t\"Dummy IPA for Vimc\",\n \t\"LGPL-2.1-or-later\",\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 55d5bff287c3366d..86aefc08a9563d44 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -361,7 +361,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \tif (!media)\n \t\treturn false;\n \n-\tipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n+\tipa_ = IPAManager::instance()->createIPA(this, 1, 1);\n \tif (ipa_ == nullptr)\n \t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n \n","prefixes":["libcamera-devel","v2","02/14"]}