{"id":18874,"url":"https://patchwork.libcamera.org/api/1.1/patches/18874/?format=json","web_url":"https://patchwork.libcamera.org/patch/18874/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230724095925.20877-2-jacopo.mondi@ideasonboard.com>","date":"2023-07-24T09:59:23","name":"[libcamera-devel,v3,1/3] libcamera: rpi: pipeline_base: Remove populateSensorFormats()","commit_ref":"81fa10d87f6a0d639976e67247e0415601e00eaa","pull_url":null,"state":"superseded","archived":false,"hash":"5e000fb53356d588f70c09bd089766655a38ce35","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18874/mbox/","series":[{"id":3982,"url":"https://patchwork.libcamera.org/api/1.1/series/3982/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3982","date":"2023-07-24T09:59:22","name":"[libcamera-devel,v3,1/3] libcamera: rpi: pipeline_base: Remove populateSensorFormats()","version":3,"mbox":"https://patchwork.libcamera.org/series/3982/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18874/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18874/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32440C324E\n\tfor ;\n\tMon, 24 Jul 2023 09:59:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7EBC5628C5;\n\tMon, 24 Jul 2023 11:59:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03BFF60387\n\tfor ;\n\tMon, 24 Jul 2023 11:59:39 +0200 (CEST)","from uno.localdomain (mob-5-91-20-233.net.vodafone.it\n\t[5.91.20.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 14089127D;\n\tMon, 24 Jul 2023 11:58:41 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690192781;\n\tbh=9Kta1lfznw4qKHx0EmPOtWEqvppqoOB+TGqdiXb7qpA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=E+nh7xIP6qy0H25TTvzyFl7DFzF6DYNlzhKYvLFIusEpSvUjEQ+fhOE63ukg8xu/S\n\t+LSfL3NfWw6zzTUtLljfSixf7FP51S3jbpG/I+X4mZKIyjYsDP+2RW1L7HDO1MX1LU\n\ts5LA5RscoD3l7jt5VgVevX1DUBZI0apzDJh9Esbbtl8U3DvmyqidempVeQapfhLWgJ\n\t4I1lQFpL+eVViw0weVEEyNUFb0sHszbjRrheUnifV/cN/MJkxeObMPa4wFf7RyikAV\n\tlxEwBOoNqfS9l8Seiz0IFy0xEr/g7urU6rGleJQ5CX2xMwahTU9ZmievdBsytCadEm\n\tBRLB/bhYz6ing==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690192721;\n\tbh=9Kta1lfznw4qKHx0EmPOtWEqvppqoOB+TGqdiXb7qpA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BC84txmzKur1Yw8n3jHM/cApE1+wXMzcnRPphHpqRqKQLdzMqRobg79hjDoTjCVIp\n\tCCxXuyTM7+zjbwZvUxsyV59Bl7Wu9CaCbE2RgwmErahSaoE9Wy4ltG9ZDK3teotiVg\n\tnCFxcqeBRXxyykQyPEbFojy1Xjbv3NTweKQL4y+Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BC84txmz\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 24 Jul 2023 11:59:23 +0200","Message-Id":"<20230724095925.20877-2-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","In-Reply-To":"<20230724095925.20877-1-jacopo.mondi@ideasonboard.com>","References":"<20230724095925.20877-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 1/3] libcamera: rpi: pipeline_base:\n\tRemove populateSensorFormats()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"populateSensorFormats() is a static helper that is called from a single\nplace and performs a simple loop over the sensor camera formats.\n\nRemove it and in-line it in the caller to remove one static helper from\nthe pipeline_base.cpp file.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Naushir Patuck \nReviewed-by: Kieran Bingham \n---\n .../pipeline/rpi/common/pipeline_base.cpp | 15 ++++-----------\n 1 file changed, 4 insertions(+), 11 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 179a5b81a516..fb3756a47590 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -66,16 +66,6 @@ PixelFormat mbusCodeToPixelFormat(unsigned int mbus_code,\n \treturn pix;\n }\n \n-SensorFormats populateSensorFormats(std::unique_ptr &sensor)\n-{\n-\tSensorFormats formats;\n-\n-\tfor (auto const mbusCode : sensor->mbusCodes())\n-\t\tformats.emplace(mbusCode, sensor->sizes(mbusCode));\n-\n-\treturn formats;\n-}\n-\n bool isMonoSensor(std::unique_ptr &sensor)\n {\n \tunsigned int mbusCode = sensor->mbusCodes()[0];\n@@ -804,7 +794,10 @@ int PipelineHandlerBase::registerCamera(std::unique_ptr &camera\n \tif (data->sensor_->init())\n \t\treturn -EINVAL;\n \n-\tdata->sensorFormats_ = populateSensorFormats(data->sensor_);\n+\t/* Populate the map of sensor supported formats and sizes. */\n+\tfor (auto const mbusCode : data->sensor_->mbusCodes())\n+\t\tdata->sensorFormats_.emplace(mbusCode,\n+\t\t\t\t\t data->sensor_->sizes(mbusCode));\n \n \t/*\n \t * Enumerate all the Video Mux/Bridge devices across the sensor -> Fr\n","prefixes":["libcamera-devel","v3","1/3"]}