{"id":1887,"url":"https://patchwork.libcamera.org/api/1.1/patches/1887/?format=json","web_url":"https://patchwork.libcamera.org/patch/1887/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190829232653.13214-2-niklas.soderlund@ragnatech.se>","date":"2019-08-29T23:26:40","name":"[libcamera-devel,v2,01/14] libcamera: ipa: Remove IPAInterface::init()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bc01d5b4bc61adf6e51324bd948375703cf7c020","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1887/mbox/","series":[{"id":475,"url":"https://patchwork.libcamera.org/api/1.1/series/475/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=475","date":"2019-08-29T23:26:40","name":"libcamera: ipa: Add basic IPA support","version":2,"mbox":"https://patchwork.libcamera.org/series/475/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1887/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1887/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 996C160BE5\n\tfor ;\n\tFri, 30 Aug 2019 01:27:30 +0200 (CEST)","from bismarck.berto.se (unknown [79.202.45.17])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 8e450385-cab4-11e9-837a-0050569116f7;\n\tFri, 30 Aug 2019 01:27:24 +0200 (CEST)"],"X-Halon-ID":"8e450385-cab4-11e9-837a-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Aug 2019 01:26:40 +0200","Message-Id":"<20190829232653.13214-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.22.1","In-Reply-To":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>","References":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 01/14] libcamera: ipa: Remove\n\tIPAInterface::init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 29 Aug 2019 23:27:31 -0000"},"content":"The function performs no useful task and will not be needed when we\nextend the IPA interface to process parameter and statistic buffers.\n\nSigned-off-by: Niklas Söderlund \n---\n include/libcamera/ipa/ipa_interface.h | 2 --\n src/ipa/ipa_dummy.cpp | 8 --------\n src/ipa/ipa_dummy_isolate.cpp | 8 --------\n src/libcamera/ipa_interface.cpp | 5 -----\n src/libcamera/pipeline/vimc.cpp | 2 --\n 5 files changed, 25 deletions(-)","diff":"diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex 2c5eb1fd524311cb..9bbc4cf58ec66420 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -13,8 +13,6 @@ class IPAInterface\n {\n public:\n \tvirtual ~IPAInterface() {}\n-\n-\tvirtual int init() = 0;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp\nindex 4c8b6657689d0c9f..2fe232295c676941 100644\n--- a/src/ipa/ipa_dummy.cpp\n+++ b/src/ipa/ipa_dummy.cpp\n@@ -14,16 +14,8 @@ namespace libcamera {\n \n class IPADummy : public IPAInterface\n {\n-public:\n-\tint init();\n };\n \n-int IPADummy::init()\n-{\n-\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n-\treturn 0;\n-}\n-\n /*\n * External IPA module interface\n */\ndiff --git a/src/ipa/ipa_dummy_isolate.cpp b/src/ipa/ipa_dummy_isolate.cpp\nindex 24434e85d31809e2..fa50be5309eba3c4 100644\n--- a/src/ipa/ipa_dummy_isolate.cpp\n+++ b/src/ipa/ipa_dummy_isolate.cpp\n@@ -15,16 +15,8 @@ namespace libcamera {\n \n class IPADummyIsolate : public IPAInterface\n {\n-public:\n-\tint init();\n };\n \n-int IPADummyIsolate::init()\n-{\n-\tstd::cout << \"initializing isolated dummy IPA!\" << std::endl;\n-\treturn 0;\n-}\n-\n /*\n * External IPA module interface\n */\ndiff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\nindex 9d30da29228fabb7..273477a5272677b7 100644\n--- a/src/libcamera/ipa_interface.cpp\n+++ b/src/libcamera/ipa_interface.cpp\n@@ -19,9 +19,4 @@ namespace libcamera {\n * \\brief Interface for IPA implementation\n */\n \n-/**\n- * \\fn IPAInterface::init()\n- * \\brief Initialise the IPAInterface\n- */\n-\n } /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex f8f91d6219b1aee4..55d5bff287c3366d 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -364,8 +364,6 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \tipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n \tif (ipa_ == nullptr)\n \t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n-\telse\n-\t\tipa_->init();\n \n \tstd::unique_ptr data = utils::make_unique(this);\n \n","prefixes":["libcamera-devel","v2","01/14"]}