{"id":18860,"url":"https://patchwork.libcamera.org/api/1.1/patches/18860/?format=json","web_url":"https://patchwork.libcamera.org/patch/18860/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230721093759.27700-4-naush@raspberrypi.com>","date":"2023-07-21T09:37:58","name":"[libcamera-devel,v1,3/4] pipeline: rpi: Rename RPi::Stream::setExternalBuffer()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9583b7d57180a979c043622686a0e72ac32c22c6","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18860/mbox/","series":[{"id":3980,"url":"https://patchwork.libcamera.org/api/1.1/series/3980/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3980","date":"2023-07-21T09:37:55","name":"Raspberry Pi: External buffer handling","version":1,"mbox":"https://patchwork.libcamera.org/series/3980/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18860/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18860/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74C60C32AA\n\tfor ;\n\tFri, 21 Jul 2023 09:38:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 956F0628CE;\n\tFri, 21 Jul 2023 11:38:03 +0200 (CEST)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0E31628C6\n\tfor ;\n\tFri, 21 Jul 2023 11:37:59 +0200 (CEST)","by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-3fbc77e76abso14448605e9.1\n\tfor ;\n\tFri, 21 Jul 2023 02:37:59 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tn12-20020a5d6b8c000000b003143c6e09ccsm3674663wrx.16.2023.07.21.02.37.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 21 Jul 2023 02:37:58 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689932283;\n\tbh=yItyVuO2VDL507HlcVK+PBcaMIE7vWWz+HZ9prCd06M=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=A5Mk1vbhh0YJt8z0qEixNedSQH8kPSnT2q3Gt7DH+xeniAHBU2tBt42W6eGOM2T4c\n\tDgvGHKlBs2lgzyU2APA+HTm0+WKqmiUMRfMvAGMV/Ch0vLMgNqqcKfFA7M5RoP2aWj\n\t85z+iErym3v2TYaQ3RSeQdvXrQ84NeY4MN5f/msNjQ8J737sDhs4ICLuWt6276HKcH\n\tpWKpqsmvASqI64g92W2LCMFQv6U8JPv8pThir8PTh3hyGHolgxGRR09BkFthLbtdFt\n\t7FONqvdq57YxFmBxRWcTh1pV1JTQ8VffxjNGBScSyd6dvVi352Vh27LPmf+Jit1voa\n\tMbnOdUua73+DA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1689932279; x=1690537079;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=3uFxpASj7huUvtuSvmY8zK0VJmpliDDCi26iSvJYNH4=;\n\tb=V+WCoVVUSBQLU74Kf75rQIIkZpssXtnlvbmMCTPNyDNd0GFOH6SfxyRmTdM+yfJSXE\n\tEhtfaUHOffrnwuTI4uz7z0EY/+aiN+Ov2rwPcpZteDKmEwzysOSUw4EITJnxAKJylfPq\n\tuMpsxeYziPn+CS1nmYQYvnqE0EX2PCy8lz23VQ5yVCm9jAhQim057X2kk/bYbXxVdYK9\n\txAP0X3kc/4hHV+BaOxv14xzDCQ8pudSiS8rkxFssakvz/gA5aeB5pcxlqYlKXRkSQ6Ww\n\tREnrbo2BBUL1orck3xIQe0pWFXP3iW2nIJ08jdEaottQuMViqcFKU3XPTxfOa2XDt2Cz\n\tdJnQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"V+WCoVVU\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1689932279; x=1690537079;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=3uFxpASj7huUvtuSvmY8zK0VJmpliDDCi26iSvJYNH4=;\n\tb=BHyhcEOSlqK+nky7m0+Kdd81oIgYEi14u6NmF2+2WxQcrZ9Da6FO9ZcfkiiLWLitSl\n\tjrABE97Q1rxsHDE8uGMcuv0OzaK5VCeEuCArUtGn/bhou8PSXFThhjkFVB9wkpzxqHDb\n\tJfXQ/AO8V3s/CxtRIGVerCk+5imAfD+gIPdz+9MmH4OdHhQjW+VlenwLRIaPRzX0aix1\n\tY1vttLkerxbdZIVwInB9EOc4E9zt9TD7mF4RQ4XFkz8fT3GZQU+BxZmnZjWc+9rKZuYq\n\tZXoB12y1B2/4htZUDOkIeG2xArnROs46KmTuPQHiKCdtYdz199UpmLxpn8U9nmnvLL9L\n\t7vCA==","X-Gm-Message-State":"ABy/qLYuO50Y/+v5tpL9Mdfu/93jHQtaSZW5Jhq/IeKPBxqYpYo/CYBJ\n\tmmAYclfBRLwQTzoNIHToZHIaEdjUn0gfMRnkZKgZnw==","X-Google-Smtp-Source":"APBJJlHyTYqlbPymtkX7Yy86CSsyPtyb9Ks+S4IMOR8Js/Bbxzpk5vMQcdbzxCKr5JyZvsqsb7OH5A==","X-Received":"by 2002:a05:600c:d7:b0:3fc:1a6:7764 with SMTP id\n\tu23-20020a05600c00d700b003fc01a67764mr946751wmm.16.1689932278929; \n\tFri, 21 Jul 2023 02:37:58 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 21 Jul 2023 10:37:58 +0100","Message-Id":"<20230721093759.27700-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230721093759.27700-1-naush@raspberrypi.com>","References":"<20230721093759.27700-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 3/4] pipeline: rpi: Rename\n\tRPi::Stream::setExternalBuffer()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since we don't distinguish between externally and internally allocated\ndma bufs, rename this function to setExportedBuffer() to clearer on its\nfunction.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 2 +-\n src/libcamera/pipeline/rpi/common/rpi_stream.cpp | 2 +-\n src/libcamera/pipeline/rpi/common/rpi_stream.h | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex f244edc68a85..fc0c0ec3c53c 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -764,7 +764,7 @@ int PipelineHandlerBase::queueRequestDevice(Camera *camera, Request *request)\n \t\t\t * outside the v4l2 device. Store it in the stream buffer list\n \t\t\t * so we can track it.\n \t\t\t */\n-\t\t\tstream->setExternalBuffer(buffer);\n+\t\t\tstream->setExportedBuffer(buffer);\n \t\t}\n \n \t\t/*\ndiff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\nindex 07b8de6875fe..e24531e171c8 100644\n--- a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n@@ -76,7 +76,7 @@ unsigned int Stream::getBufferId(FrameBuffer *buffer) const\n \treturn it->first;\n }\n \n-void Stream::setExternalBuffer(FrameBuffer *buffer)\n+void Stream::setExportedBuffer(FrameBuffer *buffer)\n {\n \tbufferMap_.emplace(id_.get(), buffer);\n }\ndiff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.h b/src/libcamera/pipeline/rpi/common/rpi_stream.h\nindex ca591f99cc45..d1289c4679b9 100644\n--- a/src/libcamera/pipeline/rpi/common/rpi_stream.h\n+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.h\n@@ -76,7 +76,7 @@ public:\n \tconst BufferMap &getBuffers() const;\n \tunsigned int getBufferId(FrameBuffer *buffer) const;\n \n-\tvoid setExternalBuffer(FrameBuffer *buffer);\n+\tvoid setExportedBuffer(FrameBuffer *buffer);\n \n \tint prepareBuffers(unsigned int count);\n \tint queueBuffer(FrameBuffer *buffer);\n","prefixes":["libcamera-devel","v1","3/4"]}