{"id":18774,"url":"https://patchwork.libcamera.org/api/1.1/patches/18774/?format=json","web_url":"https://patchwork.libcamera.org/patch/18774/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230630120303.33023-6-umang.jain@ideasonboard.com>","date":"2023-06-30T12:03:03","name":"[libcamera-devel,RFC,5/5] ipa: rpi: cam_helper_imx519: Only pass embedded buffer in parseEmbeddedData()","commit_ref":null,"pull_url":null,"state":"deferred","archived":false,"hash":"b6aff0d6adcda27b25bc8cddf1f715989b462ffe","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18774/mbox/","series":[{"id":3945,"url":"https://patchwork.libcamera.org/api/1.1/series/3945/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3945","date":"2023-06-30T12:02:58","name":"ipa: rpi: CamHelper improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/3945/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18774/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18774/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E162C3295\n\tfor ;\n\tFri, 30 Jun 2023 12:03:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94216628C8;\n\tFri, 30 Jun 2023 14:03:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04452628C1\n\tfor ;\n\tFri, 30 Jun 2023 14:03:10 +0200 (CEST)","from umang.jainideasonboard.com.praguecc.cz (unknown\n\t[193.85.242.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81CB73320;\n\tFri, 30 Jun 2023 14:02:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688126594;\n\tbh=v1XEwTx8XIC3TLzFQZnBpaCqyNfZFOmH3b6GltBv8QA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Foit8WsoRNivigYFE4gYIUcoFoGj30ebjlazQNw6OyjM5JIaxjyzi7eAJeSu3S0L5\n\thvKRyD2JnMhqW6O+O0FPPqes3o+NZuoQq0C061lmtKydtpAmPITMkt3rAmrqxuv5dI\n\tY/rCRoTdh9d/K8XsLnzUJvE1ch+CmVOPFbfE2EgRz0emurNTQDz2W2mlPUsOvdZMco\n\twbGQM1sLMS4+CiqVdZD/ZWoJ1zGhKznX0nIr6LlTp79OJx1GoLDSIwmlx1eC8iZXfT\n\tc20T9hpv34MkjS402GvwK2JgaZcIb/ADTmDjJTHPYHOfbyDWyD1OxiPMbNIvbopuq1\n\tLF/d+p0QVPB/g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688126548;\n\tbh=v1XEwTx8XIC3TLzFQZnBpaCqyNfZFOmH3b6GltBv8QA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hyqn+PmBxyBKzf6+DB8bTI1HLbRSQUorw/pB5UFfTmH4sD0h/kzvD2Nb9y7lKHHLK\n\tSU6imDX7xnjYWzcOcVHlKK+kyI4YahHuY7/IKRmhf7gdYJ1hyH83rqBFpfD4iQkJQ5\n\t79UuHfT9eTMl/LK/TktSp8L+PHbnbZ6rYzgpIl/c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hyqn+PmB\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Jun 2023 14:03:03 +0200","Message-Id":"<20230630120303.33023-6-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.39.1","In-Reply-To":"<20230630120303.33023-1-umang.jain@ideasonboard.com>","References":"<20230630120303.33023-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 5/5] ipa: rpi: cam_helper_imx519: Only\n\tpass embedded buffer in parseEmbeddedData()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Only the embedded data section should be passed while parsing the\nembedded data through parseEmbeddedData().\n\nSigned-off-by: Umang Jain \n---\n src/ipa/rpi/cam_helper/cam_helper_imx519.cpp | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx519.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx519.cpp\nindex c7262aa0..77fb1f03 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_imx519.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx519.cpp\n@@ -42,6 +42,9 @@ constexpr std::initializer_list registerList =\n \t{ expHiReg, expLoReg, gainHiReg, gainLoReg, frameLengthHiReg, frameLengthLoReg,\n \t lineLengthHiReg, lineLengthLoReg };\n \n+/* No. of lines of embedded data on IMX519. */\n+constexpr uint32_t embeddedDataLinesImx519 = 2;\n+\n class CamHelperImx519 : public CamHelper\n {\n public:\n@@ -95,7 +98,10 @@ void CamHelperImx519::prepare(libcamera::Span buffer, Metadata &m\n \t\treturn;\n \t}\n \n-\tparseEmbeddedData(buffer, metadata);\n+\tsize_t bytesPerLine = (mode_.width * mode_.bitdepth) >> 3;\n+\tlibcamera::Span embeddedData{ buffer.data(),\n+\t\t\t\t\t\t embeddedDataLinesImx519 * bytesPerLine };\n+\tparseEmbeddedData(embeddedData, metadata);\n \n \t/*\n \t * The DeviceStatus struct is first populated with values obtained from\n","prefixes":["libcamera-devel","RFC","5/5"]}