{"id":18773,"url":"https://patchwork.libcamera.org/api/1.1/patches/18773/?format=json","web_url":"https://patchwork.libcamera.org/patch/18773/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230630120303.33023-5-umang.jain@ideasonboard.com>","date":"2023-06-30T12:03:02","name":"[libcamera-devel,RFC,4/5] ipa: rpi: cam_helper_imx477: Only pass embedded buffer in parseEmbeddedData()","commit_ref":null,"pull_url":null,"state":"deferred","archived":false,"hash":"566bb55ce141b0ca2b4091ccc59d514c74ddce69","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18773/mbox/","series":[{"id":3945,"url":"https://patchwork.libcamera.org/api/1.1/series/3945/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3945","date":"2023-06-30T12:02:58","name":"ipa: rpi: CamHelper improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/3945/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18773/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18773/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C312FC32AB\n\tfor ;\n\tFri, 30 Jun 2023 12:03:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F474628C6;\n\tFri, 30 Jun 2023 14:03:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A45C6628C1\n\tfor ;\n\tFri, 30 Jun 2023 14:03:09 +0200 (CEST)","from umang.jainideasonboard.com.praguecc.cz (unknown\n\t[193.85.242.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DB7832D2;\n\tFri, 30 Jun 2023 14:02:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688126594;\n\tbh=4ChzfexEBo0QACUM7f3MjOT0KuOpKExpyR6ioq9zevU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=XLO/vbDEVjLzOsOga0966OO+Zqd0VjZ9xC8RfjCgfPlmfeEp/e1vAWNUdNvuVmGNX\n\t2e2Dt9/eEoWVPxBSYy4p8atKRhgjuTCrvSJXyVGVd4rY6Nz+JKAc8cI07BqjwNHxNy\n\tF++GJTPG5r1QHkYE5NOOZ3nAd4wRxlAjbx5a0w/MQxSbHNtrE9Ij21Na1ULBvfXy/N\n\t/C8IrO7lGupm2IO2HjH7b8XyCg264kOgFez6fRKIBPCCn2+//lIJzzzO566qC0KpAP\n\tu7DughFghcfg84AMhjPssFwcTvdoIvXklgbf7LN7q21b1cKCDbUY9uI5Yg1xqG0BJW\n\tofBoux1YDxLDQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688126548;\n\tbh=4ChzfexEBo0QACUM7f3MjOT0KuOpKExpyR6ioq9zevU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YCDXXlo+RCTnFzTjHmi2pJ715oeZIUR8jnUFzGMHCzoLAMeIZyXgTczfClO4tj+LZ\n\tbe82GTpKbdNoXoIdMMB1EKUJv49H6FQXZdb6XA5LyJYnB6ryKMoGg4YIeGgROJ7U6a\n\tenKKQ0oaPb0xwC3itAnNSokHtaTgWi9uO1ZI9YeU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YCDXXlo+\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Jun 2023 14:03:02 +0200","Message-Id":"<20230630120303.33023-5-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.39.1","In-Reply-To":"<20230630120303.33023-1-umang.jain@ideasonboard.com>","References":"<20230630120303.33023-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 4/5] ipa: rpi: cam_helper_imx477: Only\n\tpass embedded buffer in parseEmbeddedData()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Only the embedded data section should be passed while parsing the\nembedded data through parseEmbeddedData().\n\nSigned-off-by: Umang Jain \n---\n src/ipa/rpi/cam_helper/cam_helper_imx477.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp\nindex bc769ca7..3753fd0b 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp\n@@ -42,6 +42,9 @@ constexpr std::initializer_list registerList =\n \t{ expHiReg, expLoReg, gainHiReg, gainLoReg, frameLengthHiReg, frameLengthLoReg,\n \t lineLengthHiReg, lineLengthLoReg, temperatureReg };\n \n+/* No. of lines of embedded data on IMX477. */\n+constexpr uint32_t embeddedDataLinesImx477 = 2;\n+\n class CamHelperImx477 : public CamHelper\n {\n public:\n@@ -95,7 +98,11 @@ void CamHelperImx477::prepare(libcamera::Span buffer, Metadata &m\n \t\treturn;\n \t}\n \n-\tparseEmbeddedData(buffer, metadata);\n+\tsize_t bytesPerLine = (mode_.width * mode_.bitdepth) >> 3;\n+\tlibcamera::Span embeddedData{ buffer.data(),\n+\t\t\t\t\t\t embeddedDataLinesImx477 * bytesPerLine };\n+\n+\tparseEmbeddedData(embeddedData, metadata);\n \n \t/*\n \t * The DeviceStatus struct is first populated with values obtained from\n","prefixes":["libcamera-devel","RFC","4/5"]}