{"id":18699,"url":"https://patchwork.libcamera.org/api/1.1/patches/18699/?format=json","web_url":"https://patchwork.libcamera.org/patch/18699/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230604085508.1751-1-laurent.pinchart@ideasonboard.com>","date":"2023-06-04T08:55:08","name":"[libcamera-devel,v2] libcamera: controls: Drop reference to IPA in controls documentation","commit_ref":"f65a73f3c8fd3f4d1ca51f537b97b97eaab59bf6","pull_url":null,"state":"accepted","archived":false,"hash":"abf0ae63bf1fbc61bebe4ec677fb33e8cc384e18","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18699/mbox/","series":[{"id":3905,"url":"https://patchwork.libcamera.org/api/1.1/series/3905/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3905","date":"2023-06-04T08:55:08","name":"[libcamera-devel,v2] libcamera: controls: Drop reference to IPA in controls documentation","version":2,"mbox":"https://patchwork.libcamera.org/series/3905/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18699/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18699/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5163FC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun,  4 Jun 2023 08:55:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA3FC6287E;\n\tSun,  4 Jun 2023 10:55:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0015062722\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun,  4 Jun 2023 10:55:08 +0200 (CEST)","from pendragon.ideasonboard.com (om126166129043.28.openmobile.ne.jp\n\t[126.166.129.43])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2377B2B6;\n\tSun,  4 Jun 2023 10:54:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685868910;\n\tbh=JxCJUsFsCnVr7FfgjTOmuIIhjyFWqmdjEbqq9ILBSf0=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=lv2l1IkPIVqvBOyqiF6LsMAIOp86oV3d3uW3/cIKbvqjFho6jwhN26buhwQt9jPDW\n\tuSuCWRBI7pxlmGVQ0hFpMpxz2sRL7BCMToz2WdXbyjYvBeggmxCJgYjNW6ic5VoHW+\n\t08aj+hHB/Vb4RG55n4/v77X5P1O0hev3WRU/jSnOGUdggfhcBJgdZAKBIAdTXncwVw\n\tBnvbjoHqY41xb/ZMo8f2ZQEAwodf3ZCtx6Axz2iTW3wNz2QHqfPpWx9TR0A6Zs6HcD\n\tK+QfA5eRmQ//U2ubT7McRey7ZlQAiRvATEsEFFEqUQ8BqnBBCiNl1rkAbonq5hRMvZ\n\t33kVRcspPVjFQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685868885;\n\tbh=JxCJUsFsCnVr7FfgjTOmuIIhjyFWqmdjEbqq9ILBSf0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=go2F2pQN9Kxfy+zuG6C0q0U/ny8xkg6gsU5P85o+U4FMOk5ZNxQd5SBZjCpipnR+k\n\tbsaFnjyNjCOC17SYyg5pgxPoNlazn7EHaqZKoeQGCGo4wa26EDyhVIpoJKtaqrWDTW\n\t09pri/JQYY6QYz/hBTpr2dB5ztVyh7aKzBVE0Gz8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"go2F2pQN\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sun,  4 Jun 2023 11:55:08 +0300","Message-Id":"<20230604085508.1751-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.39.3","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] libcamera: controls: Drop reference to\n\tIPA in controls documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The controls relates to the public API, which doesn't expose IPA modules\nas they are internal to libcamera. Replace the mention of \"IPA\" in the\ncontrols documentation.\n\nWhile at it, fix a small text reflow issue.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\n---\nChanges since v1:\n\n- Drop IPA reference from FocusFoM documentation (thanks Naush)\n---\n src/libcamera/control_ids.yaml | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex adea5f90acc5..a0fbb772de64 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -275,12 +275,12 @@ controls:\n       type: int32_t\n       description: |\n         Reports a Figure of Merit (FoM) to indicate how in-focus the frame is.\n-        A larger FocusFoM value indicates a more in-focus frame. This control\n-        depends on the IPA to gather ISP statistics from the defined focus\n-        region, and combine them in a suitable way to generate a FocusFoM value.\n-        In this respect, it is not necessarily aimed at providing a way to\n-        implement a focus algorithm by the application, rather an indication of\n-        how in-focus a frame is.\n+        A larger FocusFoM value indicates a more in-focus frame. This singular\n+        value may be based on a combination of statistics gathered from\n+        multiple focus regions within an image. The number of focus regions and\n+        method of combination is platform dependent. In this respect, it is not\n+        necessarily aimed at providing a way to implement a focus algorithm by\n+        the application, rather an indication of how in-focus a frame is.\n \n   - ColourCorrectionMatrix:\n       type: float\n@@ -333,8 +333,8 @@ controls:\n   - FrameDurationLimits:\n       type: int64_t\n       description: |\n-        The minimum and maximum (in that order) frame duration,\n-        expressed in microseconds.\n+        The minimum and maximum (in that order) frame duration, expressed in\n+        microseconds.\n \n         When provided by applications, the control specifies the sensor frame\n         duration interval the pipeline has to use. This limits the largest\n@@ -343,7 +343,7 @@ controls:\n         the sensor will not be able to raise the exposure time above 33ms.\n         A fixed frame duration is achieved by setting the minimum and maximum\n         values to be the same. Setting both values to 0 reverts to using the\n-        IPA provided defaults.\n+        camera defaults.\n \n         The maximum frame duration provides the absolute limit to the shutter\n         speed computed by the AE algorithm and it overrides any exposure mode\n","prefixes":["libcamera-devel","v2"]}