{"id":18697,"url":"https://patchwork.libcamera.org/api/1.1/patches/18697/?format=json","web_url":"https://patchwork.libcamera.org/patch/18697/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230603075615.20663-13-tomi.valkeinen@ideasonboard.com>","date":"2023-06-03T07:56:14","name":"[libcamera-devel,v5,12/13] py: unittests.py: Fix type checker warnings","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a0e79db0d9ff338fc1992d088863067df6fac3e2","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/1.1/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18697/mbox/","series":[{"id":3904,"url":"https://patchwork.libcamera.org/api/1.1/series/3904/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3904","date":"2023-06-03T07:56:02","name":"py: New python bindings event handling","version":5,"mbox":"https://patchwork.libcamera.org/series/3904/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18697/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18697/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1238C32AE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat,  3 Jun 2023 07:57:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EE0462897;\n\tSat,  3 Jun 2023 09:57:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34B986288B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat,  3 Jun 2023 09:57:16 +0200 (CEST)","from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACE11F07;\n\tSat,  3 Jun 2023 09:56:52 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685779042;\n\tbh=ukPLQkZ7mhOvt8DGT/hHKfTwnq7m5x/13Sc5Rq8R/NE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=YCyTJcDOcPnIVwuFGwu4wbonguHC8q5qc2pDpnELFBuwqk910V2SmNTz4NXV4V0Dg\n\tV4Qu1+UOQ7YvfB8rADNudoTA4yVgLx7hbttN5MDyrrQohj08IexYPeQx+5l8OAykYg\n\tsvXMQTfdpH6fB0OysgOjW1iCmkoSEOh4RD170qhcDBws6tntJtVFgEenX7sxPQ/AZ4\n\tq+Qcoh2aMYEGr+9TRdDI1lh+Vn9ghfG4XvrL0xCyCmFa0e0wIPHFti+CH6n0YX6ihj\n\t7i+crcRbkbKf06PvPSJPTRPgwwyNcFzNRt1Y9NZ5AnCpTUTN3AUoopemwM7o9D2RB4\n\tBOcOvId06gzpw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685779013;\n\tbh=ukPLQkZ7mhOvt8DGT/hHKfTwnq7m5x/13Sc5Rq8R/NE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=l3M7Y8wTAjljUKsmrrQry5FqSkkMJUYYzzy7CJyERagzPpmJyaajY2yzL4q8+v/kZ\n\tMr1Pihr1HFpnOQ9mJ8MdzMKHaROLQ9X1u6RprcDJijiRcED15a+AXaugV2DCj1jQje\n\tLrdvYW1DrZ1IzXZRv1zuH8N3rBX0d//mMK2xGO60="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"l3M7Y8wT\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat,  3 Jun 2023 10:56:14 +0300","Message-Id":"<20230603075615.20663-13-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>","References":"<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 12/13] py: unittests.py: Fix type\n\tchecker warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Fix type checker warnings by dropping unused imports and using _ for\nvariable names that are not used.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/py/unittests.py | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 024d9752..967e791f 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -4,11 +4,9 @@\n # Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n \n from collections import defaultdict\n-import errno\n import gc\n import libcamera as libcam\n import selectors\n-import time\n import typing\n import unittest\n import weakref\n@@ -410,7 +408,7 @@ class SimpleCaptureMethods(CameraTesterBase):\n         running = True\n         while running:\n             events = sel.select()\n-            for key, _ in events:\n+            for _ in events:\n                 for ev in cm.get_events():\n                     self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n                     reqs.append(ev.request)\n","prefixes":["libcamera-devel","v5","12/13"]}