{"id":18696,"url":"https://patchwork.libcamera.org/api/1.1/patches/18696/?format=json","web_url":"https://patchwork.libcamera.org/patch/18696/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230603075615.20663-12-tomi.valkeinen@ideasonboard.com>","date":"2023-06-03T07:56:13","name":"[libcamera-devel,v5,11/13] py: unittests.py: Add test for refs & keep-alives","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5396eea151c5fc9298301911b7102fabfed4f731","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/1.1/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18696/mbox/","series":[{"id":3904,"url":"https://patchwork.libcamera.org/api/1.1/series/3904/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3904","date":"2023-06-03T07:56:02","name":"py: New python bindings event handling","version":5,"mbox":"https://patchwork.libcamera.org/series/3904/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18696/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18696/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67A9DC3200\n\tfor ;\n\tSat, 3 Jun 2023 07:57:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E017862896;\n\tSat, 3 Jun 2023 09:57:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F76F62709\n\tfor ;\n\tSat, 3 Jun 2023 09:57:15 +0200 (CEST)","from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1871BB2A;\n\tSat, 3 Jun 2023 09:56:52 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685779041;\n\tbh=xnsU+dBTrM++WqFLAtAgLiiKiQrid4kqBDwvRdKooBA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=u45RAwiTEFc6Jj1MK5/1qtNaV7r1RWfeZ3la+9B92eu4gk2cSZAJyT7zDIXSbqW8N\n\thuWdhmX8fGNb27zr1r1Pv5nedyXhNNdxxS+pUg5qygL/vidD+iduno9MpOMHOgvpWB\n\tHkRaMcauN7yV53aol6jTsx+818ulP6hfOsK2Aez5MN0R/+zDYJJNqsiobEaTVB0k6g\n\tfo4rLPXkdWyiWteh6fGaWeP7v1JA3KG4Ryqgo8tBdDUB2i239Mb3PEmMn77WIp0JSW\n\tafsxhBdIYDzv3fUVwh8//kCjR/No+sJBwQYxEQXwP9yuuKQqUP9eN26ZqZAIlJ36Or\n\t2yMmcEIxJyJKw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685779012;\n\tbh=xnsU+dBTrM++WqFLAtAgLiiKiQrid4kqBDwvRdKooBA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NhaF/WZyL/yCatPWzz3l3yR/RNfJhbvkoPpcO1BlYbekr+IOZrnEYr/W4NiBOQvPj\n\tcFTUyP/PDyyqBx2XsjRIpQju3CiYSMePUz7ccOugeua1JuRyMm4KcIqX+ijGZ6bS1q\n\t3KftdmDGTt7gfngpFTqmUC+qDaj5gq+ihMvgRaug="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NhaF/WZy\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 3 Jun 2023 10:56:13 +0300","Message-Id":"<20230603075615.20663-12-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>","References":"<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 11/13] py: unittests.py: Add test for\n\trefs & keep-alives","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a test for references and keep-alives by doing a capture, reusing\nthe Requests once and testing that the objects are freed as soon as all\nthe refs and keep-alives are gone.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Laurent Pinchart \n---\n test/py/unittests.py | 128 +++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 128 insertions(+)","diff":"diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 0c844a20..024d9752 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -31,6 +31,134 @@ class BaseTestCase(unittest.TestCase):\n self.assertTrue(all([not wr() for wr in wr_list]), msg)\n \n \n+# Test references and keep-alives by doing a capture, reusing the Requests once\n+# and testing that the objects are freed as soon as all the refs and keep-alives\n+# are gone.\n+class CaptureRefTestMethods(BaseTestCase):\n+ def test_ref(self):\n+ cm = libcam.CameraManager.singleton()\n+ wr_cm = weakref.ref(cm)\n+\n+ cam = cm.get('platform/vimc.0 Sensor B')\n+ self.assertIsNotNone(cam)\n+ wr_cam = weakref.ref(cam)\n+\n+ cam.acquire()\n+\n+ camconfig = cam.generate_configuration([libcam.StreamRole.StillCapture])\n+ self.assertTrue(camconfig.size == 1)\n+ wr_camconfig = weakref.ref(camconfig)\n+\n+ streamconfig = camconfig.at(0)\n+ wr_streamconfig = weakref.ref(streamconfig)\n+\n+ cam.configure(camconfig)\n+\n+ stream = streamconfig.stream\n+ wr_stream = weakref.ref(stream)\n+\n+ # stream keeps streamconfig and camconfig alive\n+ del streamconfig\n+ del camconfig\n+ gc.collect()\n+ self.assertIsAlive(wr_camconfig)\n+ self.assertIsAlive(wr_streamconfig)\n+\n+ allocator = libcam.FrameBufferAllocator(cam)\n+ num_bufs = allocator.allocate(stream)\n+ self.assertTrue(num_bufs > 0)\n+ wr_allocator = weakref.ref(allocator)\n+\n+ buffers = allocator.buffers(stream)\n+ self.assertIsNotNone(buffers)\n+\n+ wr_buffers = [weakref.ref(b) for b in buffers]\n+\n+ del allocator\n+ self.assertIsAlive(wr_allocator)\n+\n+ reqs = []\n+ wr_reqs = []\n+ for i in range(num_bufs):\n+ req = cam.create_request(i)\n+ self.assertIsNotNone(req)\n+\n+ wr_reqs.append(weakref.ref(req))\n+\n+ req.add_buffer(stream, buffers[i])\n+\n+ reqs.append(req)\n+\n+ del buffers\n+ del stream\n+\n+ self.assertIsDead(wr_stream)\n+\n+ cam.start()\n+\n+ reqs_target = num_bufs * 2\n+ reqs_queued = 0\n+ reqs_captured = 0\n+\n+ for req in reqs:\n+ cam.queue_request(req)\n+ reqs_queued += 1\n+\n+ del req\n+ del reqs\n+\n+ # All buffers and reqs should be alive\n+ self.assertIsAllAlive(wr_buffers)\n+ self.assertIsAllAlive(wr_reqs)\n+\n+ sel = selectors.DefaultSelector()\n+ sel.register(cm.event_fd, selectors.EVENT_READ)\n+\n+ while True:\n+ events = sel.select()\n+ if not events:\n+ continue\n+ del events\n+\n+ for ev in cm.get_events():\n+ self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n+\n+ reqs_captured += 1\n+ self.assertLessEqual(reqs_captured, reqs_target)\n+\n+ if reqs_queued < reqs_target:\n+ req: libcam.Request = typing.cast(libcam.Request, ev.request)\n+ req.reuse()\n+ cam.queue_request(req)\n+ reqs_queued += 1\n+ del req\n+\n+ del ev\n+\n+ if reqs_captured == reqs_target:\n+ break\n+\n+ del sel\n+\n+ # The allocator and all buffers and reqs should be dead\n+ self.assertIsAllDead(wr_buffers)\n+ self.assertIsAllDead(wr_reqs)\n+ self.assertIsDead(wr_allocator)\n+\n+ events = cam.stop()\n+ self.assertZero(len(events))\n+ del events\n+ cam.release()\n+\n+ del cm\n+ self.assertIsAlive(wr_cm)\n+ self.assertIsAlive(wr_cam)\n+\n+ del cam\n+ self.assertIsDead(wr_cam)\n+ self.assertIsDead(wr_cm)\n+\n+\n class SimpleTestMethods(BaseTestCase):\n def test_get_ref(self):\n cm = libcam.CameraManager.singleton()\n","prefixes":["libcamera-devel","v5","11/13"]}