{"id":18690,"url":"https://patchwork.libcamera.org/api/1.1/patches/18690/?format=json","web_url":"https://patchwork.libcamera.org/patch/18690/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230603075615.20663-6-tomi.valkeinen@ideasonboard.com>","date":"2023-06-03T07:56:07","name":"[libcamera-devel,v5,05/13] py: unittests.py: Use new events support","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eba1527f902aa66578967593b5315f73b709d5f9","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/1.1/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18690/mbox/","series":[{"id":3904,"url":"https://patchwork.libcamera.org/api/1.1/series/3904/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3904","date":"2023-06-03T07:56:02","name":"py: New python bindings event handling","version":5,"mbox":"https://patchwork.libcamera.org/series/3904/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18690/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18690/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81BBBC3200\n\tfor ;\n\tSat, 3 Jun 2023 07:57:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1244A62886;\n\tSat, 3 Jun 2023 09:57:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2E886287C\n\tfor ;\n\tSat, 3 Jun 2023 09:57:11 +0200 (CEST)","from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47507B2A;\n\tSat, 3 Jun 2023 09:56:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685779038;\n\tbh=kJHjyipMYAIbHcbAZy0LPyQnHVkzeNbGTkQwN4dtcLM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ky5f7MRsSoVHBzifmm26guUUjSb4IIaena0/rP+VleWwYpSh3hveUwyHAT7WgXVOZ\n\tDzNM3MMhWqnRjzR+mSk06RqnxsfJL0UvsrfAsngrdIW6SKtT2IU6b6fdtzqQHxI0Nn\n\tva1eEm21pI1A0MTmS+Iph5NFof906fy1T9+rqTZ/+dVn2QSbacSYW3zcZ6K4qH1gVF\n\toxUl7yTg0pP1cq4qnvAB+p1BpPQ0DY7nVNfBk6+iitm7yK80wRvSU8pwXP1+kWgaIu\n\tmyldGTQoex0pD948/9aISB8L2EXN0yF+71xlgG9PUqXfTT+QaAM4lgDtbYUS7rtPvV\n\teTUwC1XYL5gJQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685779008;\n\tbh=kJHjyipMYAIbHcbAZy0LPyQnHVkzeNbGTkQwN4dtcLM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BiLJSbwa/pTGVq51Ndblr+pTXrhVLeeCv9BHfhpqudwG9YslGipodnUUf1xrYQzwr\n\tbnjmpkRaSTnoTTVL0vOCH52lxX1ig5HegNZNz/232cPaU0bk8mES1EVxRyyOm0J5GJ\n\t2zukweRwo/DIassM8/tlpaRlzibH7UyVFqvTPo6w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BiLJSbwa\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 3 Jun 2023 10:56:07 +0300","Message-Id":"<20230603075615.20663-6-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>","References":"<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 05/13] py: unittests.py: Use new events\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Update the Python unittests to use the new event model. The unittests\nexpect a controlled environment to be run on, and the tests will fail if\nwe get any other event but RequestCompleted (e.g. camera connected).\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Laurent Pinchart \n---\n test/py/unittests.py | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex fe1e8ef0..0c844a20 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -217,9 +217,9 @@ class SimpleCaptureMethods(CameraTesterBase):\n if not events:\n continue\n \n- ready_reqs = cm.get_ready_requests()\n-\n- reqs += ready_reqs\n+ for ev in cm.get_events():\n+ self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n+ reqs.append(ev.request)\n \n if len(reqs) == num_bufs:\n break\n@@ -283,9 +283,9 @@ class SimpleCaptureMethods(CameraTesterBase):\n while running:\n events = sel.select()\n for key, _ in events:\n- ready_reqs = cm.get_ready_requests()\n-\n- reqs += ready_reqs\n+ for ev in cm.get_events():\n+ self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n+ reqs.append(ev.request)\n \n if len(reqs) == num_bufs:\n running = False\n","prefixes":["libcamera-devel","v5","05/13"]}