{"id":18680,"url":"https://patchwork.libcamera.org/api/1.1/patches/18680/?format=json","web_url":"https://patchwork.libcamera.org/patch/18680/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230602060947.16309-1-laurent.pinchart@ideasonboard.com>","date":"2023-06-02T06:09:47","name":"[libcamera-devel,v2] libcamera: controls: Define a default lens position behaviour","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"36cd5fcefe2d81f85dfbbed194c36a1b093cfe73","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18680/mbox/","series":[{"id":3901,"url":"https://patchwork.libcamera.org/api/1.1/series/3901/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3901","date":"2023-06-02T06:09:47","name":"[libcamera-devel,v2] libcamera: controls: Define a default lens position behaviour","version":2,"mbox":"https://patchwork.libcamera.org/series/3901/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18680/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18680/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2EA06C3200\n\tfor ;\n\tFri, 2 Jun 2023 06:09:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECD6562728;\n\tFri, 2 Jun 2023 08:09:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3790F61EA5\n\tfor ;\n\tFri, 2 Jun 2023 08:09:49 +0200 (CEST)","from pendragon.ideasonboard.com (om126156168104.26.openmobile.ne.jp\n\t[126.156.168.104])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C3EE6A39;\n\tFri, 2 Jun 2023 08:09:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685686190;\n\tbh=D1tQQDmPtFTJOpwtlzuYC1WQ/MmCXxPnJf/7lgw26I4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=lu3d4TIOHzwGgS1Zcl9uRpIlzqOOnA6Y/NdPkBAyTIe82zRTEB2yupChaSWNUPbNE\n\t/a0HRl8trkodsJYeJA59aP6OXvYoVIvzmNmTMDdzitsJGIVyCq6GOnoYr8NP1LbrWf\n\tVvyFlmWuKobIVhqcVZHt85hokk3dthcxiIowJ0odMJz9wYxyuZl9YaGHVVX7+emqmm\n\t7Q3/7KbyUUR9kfgwb20MNeYvEoqYtbRQDyP55NxUBR1ubO0OV6Ob4Kc/qAVNrkd8bD\n\tE2V0d4M/5w/xm0a+ItkTjcVvfpINHx18IaA8xu7W++5666caEJfIcSIvzFmYE+aOa8\n\tZEnSH89aEkw7w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685686166;\n\tbh=D1tQQDmPtFTJOpwtlzuYC1WQ/MmCXxPnJf/7lgw26I4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ab5ms4P6l+zd2lUx2j8DRzX0okzbpj6isZ6I46Ob0zg82Py2sxR7KcUdmqXg1/Qfl\n\ttS9CGKYl4X99fYq/F0Im0dC9Q/aAAgW0AWfIC/IE/z1jq1fe0cqSOoDW+m8ZE+rH60\n\tdXeip+plw4KRNT244UpanioYmAt7iJtYKnq+TSoQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ab5ms4P6\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Jun 2023 09:09:47 +0300","Message-Id":"<20230602060947.16309-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.39.3","In-Reply-To":"<20230602060916.GP22609@pendragon.ideasonboard.com>","References":"<20230602060916.GP22609@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] libcamera: controls: Define a default\n\tlens position behaviour","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Naushir Patuck \n\nUpdate the AfMode control description to explicitly define a\nstartup/default behaviour.\n\nOn startup, the camera will move the lens to the position given by the\ndefault value of the LensPosition control if operating in manual focus\nmode. Typically this would be the hyperfocal position of the lens.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/control_ids.yaml | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 76d41f5f2a5a..985f792a53c1 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -408,7 +408,15 @@ controls:\n LensPosition control.\n \n In this mode the AfState will always report AfStateIdle.\n- - name: AfModeAuto\n+\n+ If the camera is started is AfModeManual, it will move the focus\n+ lens to the position specified by the LensPosition control.\n+\n+ This mode is the recommended default value for the AfMode control.\n+ External cameras (as reported by the Location property set to\n+ CameraLocationExternal) may use a different default value.\n+\n+ name: AfModeAuto\n value: 1\n description: |\n The AF algorithm is in auto mode. This means that the algorithm\n","prefixes":["libcamera-devel","v2"]}