{"id":1866,"url":"https://patchwork.libcamera.org/api/1.1/patches/1866/?format=json","web_url":"https://patchwork.libcamera.org/patch/1866/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190828011710.32128-2-niklas.soderlund@ragnatech.se>","date":"2019-08-28T01:16:58","name":"[libcamera-devel,01/13] libcamera: pipeline: vimc: Increase version of dummy IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9e65db495bff5a1fa1080701e97a9a42dd50ee31","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1866/mbox/","series":[{"id":470,"url":"https://patchwork.libcamera.org/api/1.1/series/470/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=470","date":"2019-08-28T01:16:57","name":"libcamera: ipa: Add basic IPA support","version":1,"mbox":"https://patchwork.libcamera.org/series/470/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1866/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1866/checks/","tags":{},"headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FDD060C10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Aug 2019 03:17:35 +0200 (CEST)","from bismarck.berto.se (unknown [95.195.154.80])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 94214421-c931-11e9-bdc3-005056917a89;\n\tWed, 28 Aug 2019 03:17:19 +0200 (CEST)"],"X-Halon-ID":"94214421-c931-11e9-bdc3-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 28 Aug 2019 03:16:58 +0200","Message-Id":"<20190828011710.32128-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.22.1","In-Reply-To":"<20190828011710.32128-1-niklas.soderlund@ragnatech.se>","References":"<20190828011710.32128-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 01/13] libcamera: pipeline: vimc: Increase\n\tversion of dummy IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 28 Aug 2019 01:17:35 -0000"},"content":"An IPA version number of 0 will be redefined as No IPA support. Increase\nthe VIMC dummy IPA version to 1 to allow it to keep loading.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/ipa/ipa_dummy.cpp           | 2 +-\n src/libcamera/pipeline/vimc.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp\nindex 4c8b6657689d0c9f..b0e944a17fc5cffb 100644\n--- a/src/ipa/ipa_dummy.cpp\n+++ b/src/ipa/ipa_dummy.cpp\n@@ -31,7 +31,7 @@ int IPADummy::init()\n extern \"C\" {\n const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n-\t0,\n+\t1,\n \t\"PipelineHandlerVimc\",\n \t\"Dummy IPA for Vimc\",\n \t\"LGPL-2.1-or-later\",\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex f8f91d6219b1aee4..e5c4890501db71c8 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -361,7 +361,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \tif (!media)\n \t\treturn false;\n \n-\tipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n+\tipa_ = IPAManager::instance()->createIPA(this, 1, 1);\n \tif (ipa_ == nullptr)\n \t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n \telse\n","prefixes":["libcamera-devel","01/13"]}