{"id":18641,"url":"https://patchwork.libcamera.org/api/1.1/patches/18641/?format=json","web_url":"https://patchwork.libcamera.org/patch/18641/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230519162215.413831-1-jacopo.mondi@ideasonboard.com>","date":"2023-05-19T16:22:15","name":"[libcamera-devel] ipa: ipu3: agc: drop hard-codec analogue gain range","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fea185d12ddb3b972a3879941b4cb149eba063bb","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18641/mbox/","series":[{"id":3882,"url":"https://patchwork.libcamera.org/api/1.1/series/3882/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3882","date":"2023-05-19T16:22:15","name":"[libcamera-devel] ipa: ipu3: agc: drop hard-codec analogue gain range","version":1,"mbox":"https://patchwork.libcamera.org/series/3882/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18641/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18641/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32FB4C31E9\n\tfor ;\n\tFri, 19 May 2023 16:22:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3DC86285F;\n\tFri, 19 May 2023 18:22:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13003627CD\n\tfor ;\n\tFri, 19 May 2023 18:22:28 +0200 (CEST)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C9AA720;\n\tFri, 19 May 2023 18:22:14 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1684513349;\n\tbh=xB07lu0dDMtJPXv5ttm7E5kTf000VC8udf1ZV1hHHEY=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=QSZvQZ+Y2o/hwsom0EgRzyvMZf3o2DySpbwlKZtPB7aqVmy0FSVerUf4AgZSZv2X/\n\twKdzgLDSjuWdXXrkgJa5kgddZ/jM6ea/7VM3XQ1hJWQGQ2ydME2VKs/O7BXlEz0j08\n\t/Sfx7qrtLyeGmHpz7rsve3wx/Ba79kwACdifaAF0Bps4W2sHhmcwaZLjsdYNQYRDN0\n\tWwPDGV+KR9kBBNWffUNYUpSEq0Bkf5NeOhRXuFNm61boeu6rv2E/q0cbA4u1mJw8gZ\n\tTuHdbK1Pld9b2S40Lh+y0cxPBjyXyKltJfAGUIZpu8GqOpXfDw8D4jsfFOmg0W2C4x\n\tRKHBF02WhB36g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1684513334;\n\tbh=xB07lu0dDMtJPXv5ttm7E5kTf000VC8udf1ZV1hHHEY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=CQ/ZzbzudfMbco4MZi2QlLurdhn2npe9Zu76dmKhgedTj0DddIOLbcIQBTI8n94Xz\n\tnsP3rd2EmMyLPVrha3pOjDcO0p8awZZurgYghxHPZFkUvrq209GnSMVCv/ECkpmf5k\n\tEY/s1HgqIgbndhczXoUVlh6fci62LRo7dxg7BbFY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CQ/Zzbzu\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 May 2023 18:22:15 +0200","Message-Id":"<20230519162215.413831-1-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: ipu3: agc: drop hard-codec analogue\n\tgain range","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"As the sensor's analogue gain range is known drop the arbitrary\nlimits for the sensor analogue gain.\n\nSigned-off-by: Jacopo Mondi \n---\n src/ipa/ipu3/algorithms/agc.cpp | 10 +++-------\n 1 file changed, 3 insertions(+), 7 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex b5309bdbea25..74a14675fca0 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -47,10 +47,6 @@ namespace ipa::ipu3::algorithms {\n \n LOG_DEFINE_CATEGORY(IPU3Agc)\n \n-/* Limits for analogue gain values */\n-static constexpr double kMinAnalogueGain = 1.0;\n-static constexpr double kMaxAnalogueGain = 8.0;\n-\n /* \\todo Honour the FrameDurationLimits control instead of hardcoding a limit */\n static constexpr utils::Duration kMaxShutterSpeed = 60ms;\n \n@@ -96,11 +92,11 @@ int Agc::configure(IPAContext &context,\n \tmaxShutterSpeed_ = std::min(configuration.agc.maxShutterSpeed,\n \t\t\t\t kMaxShutterSpeed);\n \n-\tminAnalogueGain_ = std::max(configuration.agc.minAnalogueGain, kMinAnalogueGain);\n-\tmaxAnalogueGain_ = std::min(configuration.agc.maxAnalogueGain, kMaxAnalogueGain);\n+\tminAnalogueGain_ = configuration.agc.minAnalogueGain;\n+\tmaxAnalogueGain_ = configuration.agc.maxAnalogueGain;\n \n \t/* Configure the default exposure and gain. */\n-\tactiveState.agc.gain = std::max(minAnalogueGain_, kMinAnalogueGain);\n+\tactiveState.agc.gain = minAnalogueGain_;\n \tactiveState.agc.exposure = 10ms / configuration.sensor.lineDuration;\n \n \tframeCount_ = 0;\n","prefixes":["libcamera-devel"]}