{"id":1859,"url":"https://patchwork.libcamera.org/api/1.1/patches/1859/?format=json","web_url":"https://patchwork.libcamera.org/patch/1859/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190827095008.11405-4-jacopo@jmondi.org>","date":"2019-08-27T09:50:03","name":"[libcamera-devel,v2,3/7] libcamera: controls: Add camera properties IDs","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5b6b25cfa5e8baa8e1a5b008f66ba18684015dbd","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/1.1/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/1859/mbox/","series":[{"id":468,"url":"https://patchwork.libcamera.org/api/1.1/series/468/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=468","date":"2019-08-27T09:50:00","name":"libcamera: camera_sensor: Collect camera location and sizes","version":2,"mbox":"https://patchwork.libcamera.org/series/468/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1859/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1859/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8256C60E38\n\tfor ;\n\tTue, 27 Aug 2019 11:48:46 +0200 (CEST)","from uno.homenet.telecomitalia.it (unknown [87.18.63.98])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id C8C3C100003;\n\tTue, 27 Aug 2019 09:48:45 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 27 Aug 2019 11:50:03 +0200","Message-Id":"<20190827095008.11405-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20190827095008.11405-1-jacopo@jmondi.org>","References":"<20190827095008.11405-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/7] libcamera: controls: Add camera\n\tproperties IDs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 27 Aug 2019 09:48:46 -0000"},"content":"Add the PropertyID enumeration where to list the camera static\nproperties supported by libcamera. Initially add the Location and\nRotation properties\n\nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/control_ids.h | 11 +++++++\n src/libcamera/controls.cpp | 55 +++++++++++++++++++++++++++++++++\n 2 files changed, 66 insertions(+)","diff":"diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\nindex 75b6a2d5cafe..d8c3c3265ee6 100644\n--- a/include/libcamera/control_ids.h\n+++ b/include/libcamera/control_ids.h\n@@ -21,6 +21,17 @@ enum ControlId {\n \tManualGain,\n };\n \n+enum CameraLocation {\n+\tCAMERA_LOCATION_EXTERNAL,\n+\tCAMERA_LOCATION_FRONT,\n+\tCAMERA_LOCATION_BACK,\n+};\n+\n+enum PropertyId {\n+\tLocation,\n+\tRotation,\n+};\n+\n } /* namespace libcamera */\n \n namespace std {\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 9adc3badc254..9562ecc189bb 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -555,4 +555,59 @@ void ControlList::update(const ControlList &other)\n * Specify a fixed gain parameter\n */\n \n+/**\n+ * \\enum CameraLocation\n+ * \\brief List the supported mounting location of a camera\n+ */\n+\n+/**\n+ * \\var CameraLocation::CAMERA_LOCATION_EXTERNAL\n+ * \\brief Identify an external camera\n+ *\n+ * The camera is connected to the main device through extension cables\n+ * and is freely movable. Typical examples of externally mounted cameras are\n+ * webcams and digital camera devices.\n+ */\n+\n+/**\n+ * \\var CameraLocation::CAMERA_LOCATION_FRONT\n+ * \\brief Identify a camera mounted in the device front location\n+ *\n+ * The camera is mounted on the front side of the device, which is typically\n+ * the user facing side.\n+ */\n+\n+/**\n+ * \\var CameraLocation::CAMERA_LOCATION_BACK\n+ * \\brief Identify a camera mounted in the device back location\n+ *\n+ * The camera is mounted on the back side of the device, which is typically\n+ * the side opposed to the front one.\n+ */\n+\n+/**\n+ * \\enum PropertyId\n+ * \\brief Numerical properties ID\n+ *\n+ * List the identifiers of the static properties exposed by a Camera.\n+ */\n+\n+/**\n+ * \\var PropertyId::Location\n+ * \\brief The camera mounting location\n+ *\n+ * The Camera device location is expressed as the position relative to the\n+ * device intended usage orientation. Possible values are identified by the\n+ * libcamera::CameraLocation enumeration.\n+ */\n+\n+/**\n+ * \\var PropertyId::Rotation\n+ * \\brief The camera sensor rotation\n+ *\n+ * The Camera rotation is expressed as counter-clockwise rotation in degrees\n+ * in respect to the intended device orientation. Typical values are 0 for\n+ * upright mounted cameras, and 180 for cameras mounted upside down.\n+ */\n+\n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v2","3/7"]}