{"id":18578,"url":"https://patchwork.libcamera.org/api/1.1/patches/18578/?format=json","web_url":"https://patchwork.libcamera.org/patch/18578/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230501155507.116039-2-kieran.bingham@ideasonboard.com>","date":"2023-05-01T15:55:06","name":"[libcamera-devel,1/2] libcamera: ipa_manager: Only parse IPA modules","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a4126355a381e8edadee3ee89caca1776fd7f6c6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18578/mbox/","series":[{"id":3857,"url":"https://patchwork.libcamera.org/api/1.1/series/3857/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3857","date":"2023-05-01T15:55:05","name":"V4L2 Compatibility installation directory","version":1,"mbox":"https://patchwork.libcamera.org/series/3857/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18578/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18578/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F906C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  1 May 2023 15:55:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 62ACD633B5;\n\tMon,  1 May 2023 17:55:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E16E633AC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  1 May 2023 17:55:12 +0200 (CEST)","from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB2B6A06;\n\tMon,  1 May 2023 17:55:10 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682956514;\n\tbh=5bIdp2VL87GMBjCEWZrG2smdw7KJWc/bHMvFZjQYvQQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=DqR/vH0Ra+4JqsFqAkMufQSvsv/HsXeSIwptFym8uA+uWBmhyleWbdekkQyYWTUkX\n\tyUiCsh8Qy7WmKagST8vy1HWIiD3JEF0ohUyUriSNZDJ+rQRm6UVkuJO6x4pZXXqeaR\n\twb3MtoYTZXNI5LvxJ4tRHCy4XNYh3rlsplMZhPeVKQLzAeMO6ermxDnNaOti/f4jJW\n\t1XGFh24fDFAOrC7lkhJnBHS7DEOMu8PkjVmfRe4bLyd7Z7O1HyXdM876Xz0T0c+Lhu\n\tQRyanNRIosSSBixlew/x9JfCF7KxkoFBnxMrRHrVwP+FHlBtHduH3mnHkJEXZEsSIy\n\t5dfrWVUfFfltA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1682956511;\n\tbh=5bIdp2VL87GMBjCEWZrG2smdw7KJWc/bHMvFZjQYvQQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=K+OeNp23jVSv+1z7RaulXnpjTudmzhtBUSnd+YQ0/W4g9H6bcGsDbb0V4UR0b2J+D\n\toQLPGzp+Q4Esxoxq53uJwGbXjQKL00JkIJdyHLYseFr+CV6t5uhEzZgKH9/XRCdHie\n\t4zLXpUNwjEeBx87gRKIffqEQhST0vregFz8bgIoM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"K+OeNp23\"; dkim-atps=neutral","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Mon,  1 May 2023 16:55:06 +0100","Message-Id":"<20230501155507.116039-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230501155507.116039-1-kieran.bingham@ideasonboard.com>","References":"<20230501155507.116039-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] libcamera: ipa_manager: Only parse\n\tIPA modules","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Ensure that when we iterate the libcamera libdir we only select shared\nobjects which are expected to be IPA modules, with an ipa_ prefix.\n\nAny shared object not matching this filter is ignored and not processed\nby the IPA Manager.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/ipa_manager.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex 030ef43fb994..c0c2f027e902 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -206,6 +206,10 @@ void IPAManager::parseDir(const char *libDir, unsigned int maxDepth,\n \t\tif (strcmp(&ent->d_name[offset], \".so\"))\n \t\t\tcontinue;\n \n+\t\t/* Ignore any modules which are not IPAs. */\n+\t\tif (strncmp(ent->d_name, \"ipa_\", 4) != 0)\n+\t\t\tcontinue;\n+\n \t\tfiles.push_back(std::string(libDir) + \"/\" + ent->d_name);\n \t}\n \n","prefixes":["libcamera-devel","1/2"]}