{"id":18386,"url":"https://patchwork.libcamera.org/api/1.1/patches/18386/?format=json","web_url":"https://patchwork.libcamera.org/patch/18386/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230313091944.9530-4-jacopo.mondi@ideasonboard.com>","date":"2023-03-13T09:19:41","name":"[libcamera-devel,v2,3/6] libcamera: imx8-isi: Automatically select media bus code","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"04df9144ac3ccbef80172d7f76de840086fd7607","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18386/mbox/","series":[{"id":3803,"url":"https://patchwork.libcamera.org/api/1.1/series/3803/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3803","date":"2023-03-13T09:19:38","name":"libcamera: imx8-isi: Remove pixelformat-2-media-bus map","version":2,"mbox":"https://patchwork.libcamera.org/series/3803/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18386/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18386/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37A1DC329C\n\tfor ;\n\tMon, 13 Mar 2023 09:20:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0C6962706;\n\tMon, 13 Mar 2023 10:20:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 241CC6270E\n\tfor ;\n\tMon, 13 Mar 2023 10:20:04 +0100 (CET)","from uno.homenet.telecomitalia.it\n\t(host-79-33-55-183.retail.telecomitalia.it [79.33.55.183])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C6E88CC;\n\tMon, 13 Mar 2023 10:20:03 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678699207;\n\tbh=2kwdxLJ8KK9CeegsffhjUTIUNbeuof79GYeeS/CAa3I=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=z07rUkOjpHJ++rjXP8Kh4X+8HySunqCjrGbNO3A0cbCQ2z6WmhcDvmoJPu+Y+QNxa\n\t5RnMSAYv6TGK0d4VzJVOksTrX5wa+pJDUnifX97QM9VHTccxyOTXufMXQLYxfDKlrg\n\ttHKWODr6AIV8ukl3iKWT8sMnI4+rissfWNyKle9EYMYUV3dRsityNzX7M/5J8s03l+\n\tfeOKS6LZ82I5+yOgDmzSPKzb90QJppilmsvOt0D7jLn2EWqaCQ8SexoqM0GlgUg4Ul\n\tkRZz8pgwdT8YmvaeghmSnc5jLDPPQxo4JJ3RZmAyx0coVM3yf8UgSG8ySPinzPcovX\n\tT4WXhe7HrWI2A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678699203;\n\tbh=2kwdxLJ8KK9CeegsffhjUTIUNbeuof79GYeeS/CAa3I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SPeP6HRUNE78EISjtYgELzu5wbEGwov+nbT1a3v2s/ZbbFY3/eaka40Ix7+J7X1Ki\n\tQMKakF8t9Gwezo4tsFuJ7Yfw33qg9SHqJCyu239gIjZbOz/ZrxP6ETDZO8z4/Gwwoz\n\tUouL3MS28H5xyUs9edMSNQn28ZQWXn6hhoGQrPDI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SPeP6HRU\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 13 Mar 2023 10:19:41 +0100","Message-Id":"<20230313091944.9530-4-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.39.0","In-Reply-To":"<20230313091944.9530-1-jacopo.mondi@ideasonboard.com>","References":"<20230313091944.9530-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/6] libcamera: imx8-isi: Automatically\n\tselect media bus code","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ISICameraConfiguration::validate() function selects which media\nbus format to configure the sensor with based on the pixel format\nof the first configured stream using the media bus code associated to it\nin the formatsMap_ map.\n\nIn order to remove the PixelFormamt-to-mbus-code association in\nformatsMap_ provide a wrapper function for the newly introduced\ngetRawMediaBusFormat() and getYuvMediaBusFormat() that automatically\nselects what media bus format to use based on the first stream pixel\nformat.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Paul Elder \nReviewed-by: Daniel Scally \nTested-by: Daniel Scally \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex 390e82b6947f..146ba7465012 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -61,6 +61,7 @@ public:\n \n \tunsigned int getRawMediaBusFormat(PixelFormat *pixelFormat) const;\n \tunsigned int getYuvMediaBusFormat(PixelFormat *pixelFormat) const;\n+\tunsigned int getMediaBusFormat(PixelFormat *pixelFormat) const;\n \n \tstd::unique_ptr sensor_;\n \tstd::unique_ptr csis_;\n@@ -315,6 +316,15 @@ unsigned int ISICameraData::getYuvMediaBusFormat(PixelFormat *pixelFormat) const\n \treturn supportedCodes[0];\n }\n \n+unsigned int ISICameraData::getMediaBusFormat(PixelFormat *pixelFormat) const\n+{\n+\tif (PixelFormatInfo::info(*pixelFormat).colourEncoding ==\n+\t PixelFormatInfo::ColourEncodingRAW)\n+\t\treturn getRawMediaBusFormat(pixelFormat);\n+\n+\treturn getYuvMediaBusFormat(pixelFormat);\n+}\n+\n /* -----------------------------------------------------------------------------\n * Camera Configuration\n */\n@@ -628,16 +638,16 @@ CameraConfiguration::Status ISICameraConfiguration::validate()\n \t * image quality in exchange of a usually slower frame rate.\n \t * Usage of the STILL_CAPTURE role could be consider for this.\n \t */\n-\tconst PipeFormat &pipeFmt = formatsMap_.at(config_[0].pixelFormat);\n-\n \tSize maxSize;\n \tfor (const auto &cfg : config_) {\n \t\tif (cfg.size > maxSize)\n \t\t\tmaxSize = cfg.size;\n \t}\n \n+\tPixelFormat pixelFormat = config_[0].pixelFormat;\n+\n \tV4L2SubdeviceFormat sensorFormat{};\n-\tsensorFormat.mbus_code = pipeFmt.sensorCode;\n+\tsensorFormat.mbus_code = data_->getMediaBusFormat(&pixelFormat);\n \tsensorFormat.size = maxSize;\n \n \tLOG(ISI, Debug) << \"Computed sensor configuration: \" << sensorFormat;\n","prefixes":["libcamera-devel","v2","3/6"]}