{"id":18369,"url":"https://patchwork.libcamera.org/api/1.1/patches/18369/?format=json","web_url":"https://patchwork.libcamera.org/patch/18369/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230309142601.70556-9-tomi.valkeinen@ideasonboard.com>","date":"2023-03-09T14:25:54","name":"[libcamera-devel,v4,08/15] py: Drop get_ready_requests()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f761202a170f1656e038494318e31cdac31ba8ba","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/1.1/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18369/mbox/","series":[{"id":3796,"url":"https://patchwork.libcamera.org/api/1.1/series/3796/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3796","date":"2023-03-09T14:25:46","name":"py: New python bindings event handling","version":4,"mbox":"https://patchwork.libcamera.org/series/3796/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18369/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18369/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EFB26C32A0\n\tfor ;\n\tThu, 9 Mar 2023 14:26:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88282626F7;\n\tThu, 9 Mar 2023 15:26:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3C3A626E7\n\tfor ;\n\tThu, 9 Mar 2023 15:26:19 +0100 (CET)","from desky.lan (91-154-32-225.elisa-laajakaista.fi [91.154.32.225])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B6668B1;\n\tThu, 9 Mar 2023 15:26:19 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678371986;\n\tbh=/JddElKh6X9ITcfC6NJ0RVE/Z/A8GC7PA2q4w37zG88=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=LBNhgORObVRrBpPMQ/tEQ2oFM/Jw+uaQCVreybZWJD/ZrCXQXOOvalAL8tuZU4V4Y\n\tdzAhU6tX8xRllP/O1tvkWlDnS2UJ+ZTpywGzFDAEmJIk0K2r5+iYpEjsgp/Wi0Opmm\n\tZTATgM8fAcjzIcZP+qkhpyMynhIcrVmbiL4MdeQnxQJwzaxGxe6sRaYPzcAMB2E6ye\n\tqSf78lNBh1G8mDG3LVDrg8ABaOxLOX4DvLbRHEGj4S17gpyi5g5rn4pkXqX5DExR6K\n\tP/sqdbmuA0YqL4WmQsbW1PB2C1AQ64KD08SdiwyYpziaJtymds+E986g8wvgACq0Ny\n\tkK2qOq4qNnjvA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678371979;\n\tbh=/JddElKh6X9ITcfC6NJ0RVE/Z/A8GC7PA2q4w37zG88=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wiky06JM/2502k+Cw53z7FqMHxPLTdnFOHqpcR64P5etxzXzK3FI4zcYmS05oxqyM\n\tQA424XVZe0BYWWSfSFQqABy2Ja8xCYxxCXEdMt9B4kQQqeJQowFTdxUDinwBi3cMEH\n\ttWDaTBAMkGnlWPxIi+BSe+ztgYj/hQN0BbJWEIxg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wiky06JM\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Mar 2023 16:25:54 +0200","Message-Id":"<20230309142601.70556-9-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>","References":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 08/15] py: Drop get_ready_requests()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"get_ready_requests() is deprecated, and the Python code in libcamera has\nbeen converted to the new event system, so we can drop\nget_ready_requests().\n\nSigned-off-by: Tomi Valkeinen \n---\n src/py/libcamera/py_camera_manager.cpp | 24 ------------------------\n src/py/libcamera/py_camera_manager.h | 1 -\n src/py/libcamera/py_main.cpp | 3 ---\n 3 files changed, 28 deletions(-)","diff":"diff --git a/src/py/libcamera/py_camera_manager.cpp b/src/py/libcamera/py_camera_manager.cpp\nindex 7d6dded4..c3b9646f 100644\n--- a/src/py/libcamera/py_camera_manager.cpp\n+++ b/src/py/libcamera/py_camera_manager.cpp\n@@ -103,30 +103,6 @@ PyCameraEvent PyCameraManager::convertEvent(const CameraEvent &event)\n \treturn pyevent;\n }\n \n-/* DEPRECATED */\n-std::vector PyCameraManager::getReadyRequests()\n-{\n-\tint ret = readFd();\n-\n-\tif (ret == -EAGAIN)\n-\t\treturn std::vector();\n-\n-\tif (ret != 0)\n-\t\tthrow std::system_error(-ret, std::generic_category());\n-\n-\tstd::vector py_reqs;\n-\n-\tfor (const auto &ev : getEvents()) {\n-\t\tif (ev.type_ != CameraEventType::RequestCompleted)\n-\t\t\tcontinue;\n-\n-\t\tPyCameraEvent pyev = convertEvent(ev);\n-\t\tpy_reqs.push_back(pyev.request_);\n-\t}\n-\n-\treturn py_reqs;\n-}\n-\n std::vector PyCameraManager::getPyEvents()\n {\n \tint ret = readFd();\ndiff --git a/src/py/libcamera/py_camera_manager.h b/src/py/libcamera/py_camera_manager.h\nindex 757f6d8e..648d78af 100644\n--- a/src/py/libcamera/py_camera_manager.h\n+++ b/src/py/libcamera/py_camera_manager.h\n@@ -68,7 +68,6 @@ public:\n \n \tint eventFd() const { return eventFd_.get(); }\n \n-\tstd::vector getReadyRequests(); /* DEPRECATED */\n \tstd::vector getPyEvents();\n \tstd::vector getPyCameraEvents(std::shared_ptr camera);\n \ndiff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 0fffc030..1069fd9c 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -126,9 +126,6 @@ PYBIND11_MODULE(_libcamera, m)\n \n \t\t.def_property_readonly(\"event_fd\", &PyCameraManager::eventFd)\n \n-\t\t/* DEPRECATED */\n-\t\t.def(\"get_ready_requests\", &PyCameraManager::getReadyRequests)\n-\n \t\t.def(\"get_events\", &PyCameraManager::getPyEvents)\n \n \t\t.def_readwrite(\"buffer_completed_active\", &PyCameraManager::bufferCompletedEventActive_);\n","prefixes":["libcamera-devel","v4","08/15"]}