{"id":18353,"url":"https://patchwork.libcamera.org/api/1.1/patches/18353/?format=json","web_url":"https://patchwork.libcamera.org/patch/18353/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230307114804.42291-4-jacopo.mondi@ideasonboard.com>","date":"2023-03-07T11:48:03","name":"[libcamera-devel,v3,3/4] libcamera: rkisp1: Reserve main path for StillCapture","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"539245e23369e6cd4b10e6c4ad473b195b48d59f","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18353/mbox/","series":[{"id":3792,"url":"https://patchwork.libcamera.org/api/1.1/series/3792/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3792","date":"2023-03-07T11:48:00","name":"libcamera: rkisp1: Fix generateConfiguration","version":3,"mbox":"https://patchwork.libcamera.org/series/3792/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18353/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18353/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3CADC329C\n\tfor ;\n\tTue, 7 Mar 2023 11:48:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24D7F626C4;\n\tTue, 7 Mar 2023 12:48:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BAB1626BB\n\tfor ;\n\tTue, 7 Mar 2023 12:48:21 +0100 (CET)","from uno.homenet.telecomitalia.it\n\t(host-79-47-54-87.retail.telecomitalia.it [79.47.54.87])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9EAEC4AD;\n\tTue, 7 Mar 2023 12:48:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678189704;\n\tbh=Js72QCTaA6BDl8LnSR0Hc45/HYXluIjxQWxgDjOpCIE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BgKtLIZOgX8njUAU7HklsygP3N0eFQutLC6NK81t9e6wkayEIdWQbp3kCqzw77aJ5\n\tU9j8lkljTxlOdhuyC4BtaRCQdlSH83DXEiKmONBKvPxxl0nD5CNqvEuInHd6JiSQEq\n\tF56EA5i/D1Ulfs3IfPDEDVWhz+GLALHUEcYRwpt1UurT4pDF2Uakjy/OlOP5qgThze\n\tlgC0w6j5hQhr7OPe1XHz+OZE+Jw0JiwGvWboYLz6CRa+QgndZyYL8lK4AU8tD19taq\n\ttd9Za3BLxc0OHKqby6vSzLsPCmuxWNySHokkUt227Ih+b6hEWesA5QHKhkVq4uvARS\n\tUW0z0aT7dP68w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678189701;\n\tbh=Js72QCTaA6BDl8LnSR0Hc45/HYXluIjxQWxgDjOpCIE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oPJefkvFu3UBXjKCnpTNfljnBuRgcb/lUnP0nslV3Q5RENLDKvHWzuYScnc1hO7N4\n\tHGhZvbb5vMBUt553wSFr6qktxizfPHatvU2ODO1y7g86t8Rmu6L/bbnDb+bixsEHsG\n\ta9K7PuVTpoXoPiLwHwVN0gHSMM9dEZGlwfYtbC2s="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oPJefkvF\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 7 Mar 2023 12:48:03 +0100","Message-Id":"<20230307114804.42291-4-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.39.0","In-Reply-To":"<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>","References":"<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 3/4] libcamera: rkisp1: Reserve main\n\tpath for StillCapture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi , libcamera@luigi311.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The main output path can produce images in higher resolution and\nshould be reserved for the StillCapture role when a configuration\nis generated.\n\nBefore this change if StillCapture was not requested first it got\nassigned to the self-path and thus down-scaled to 1920x1920.\n\nWith this change, StillCapture can be asked last and it would take\nprecedence over other streams for the usage of the main path.\n\n$ cam -c1 --stream role=viewfinder --stream role=still\nCamera camera.cpp:969 streams configuration: (0) 1920x1080-NV12 (1) 4208x3120-NV12\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Paul Elder \nReviewed-by: Kieran Bingham \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 60ab7380034c..cd92e99a50b3 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -643,6 +643,10 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \tif (roles.empty())\n \t\treturn config;\n \n+\t/* If still capture is requested, reserve the main path for it. */\n+\tbool reserveMainPath = std::find(roles.cbegin(), roles.cend(),\n+\t\t\t\t\t StreamRole::StillCapture) != roles.cend();\n+\n \t/*\n \t * As the ISP can't output different color spaces for the main and self\n \t * path, pick a sensible default color space based on the role of the\n@@ -661,6 +665,9 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t\t\tif (!colorSpace)\n \t\t\t\tcolorSpace = ColorSpace::Sycc;\n \n+\t\t\t/* Unlock usage of main path which was reserved. */\n+\t\t\treserveMainPath = false;\n+\n \t\t\tsize = data->sensor_->resolution();\n \t\t\tbreak;\n \n@@ -702,7 +709,7 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \n \t\tRkISP1Path *path;\n \n-\t\tif (useMainPath) {\n+\t\tif (useMainPath && !reserveMainPath) {\n \t\t\tpath = data->mainPath_;\n \t\t\tmainPathAvailable = false;\n \t\t} else {\n","prefixes":["libcamera-devel","v3","3/4"]}