{"id":18313,"url":"https://patchwork.libcamera.org/api/1.1/patches/18313/?format=json","web_url":"https://patchwork.libcamera.org/patch/18313/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230227204254.3965883-2-kieran.bingham@ideasonboard.com>","date":"2023-02-27T20:42:53","name":"[libcamera-devel,1/2] ipa: libipa: Add OV2685 Camera Sensor Helper","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8efc26dea6df3f4abcd2cf457a9bc534f30e51d5","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18313/mbox/","series":[{"id":3773,"url":"https://patchwork.libcamera.org/api/1.1/series/3773/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3773","date":"2023-02-27T20:42:52","name":"ipa: libipa: Add sensor helpers for the Acer Chrometab 10","version":1,"mbox":"https://patchwork.libcamera.org/series/3773/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18313/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18313/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03388C3257\n\tfor ;\n\tMon, 27 Feb 2023 20:43:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C08FA6268D;\n\tMon, 27 Feb 2023 21:43:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 669156267E\n\tfor ;\n\tMon, 27 Feb 2023 21:42:58 +0100 (CET)","from Monstersaurus.tail69b4.ts.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E30221257;\n\tMon, 27 Feb 2023 21:42:57 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677530580;\n\tbh=p9t84BALirKeBElcV7UuoghAqipTaLglocLXAmVT7h0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=S/LBEgsjvtovXIEXEY3yaGHmA+u3aUkXRQgJIxeyoj3V5FIRebu9aeauDLp+8JQJF\n\twJgtg0sicDGyvuT7Ln0c8h9+M0UZB4aoaPxCg8oNKHREAKvBr3d+NtM0SU/9dFszK3\n\tDS1764mZy/UX6HQN+9PRkbZqMW/9aHqpR8m/75dYeq6e5Di4ClPx9OP8vM/BnS4l5d\n\tXsGB7ODHE5W+0gabvrWgWUZnfloCsM09DDNR3uzFcQoj56KSmQIYmeAEsxFR1QH0Bc\n\tfbRrOz8cuFNBRpkzur21pb4fmaMbkYFN7uMmDSXpMy5vRy60rRZGK0PUjYFnyYjCZT\n\tJhg4JGbRvHm0g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1677530578;\n\tbh=p9t84BALirKeBElcV7UuoghAqipTaLglocLXAmVT7h0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wXmEt4V2QZkp8i0OF6iHVV9EvYtXFOWLMZLcTTiaKOssJ3O8PGn890rbiMNUQT2Qv\n\tRLG6xFQ1ozZ8RP9sTNZMTzcbrzjpCdcjlK0H2DtP/D+hU+h8wYh4ksZU73H/DDARCo\n\tF+smwoNkVSxrkvHU07Q6y31O4g3pCzz/aOsBdqBk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wXmEt4V2\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Mon, 27 Feb 2023 20:42:53 +0000","Message-Id":"<20230227204254.3965883-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230227204254.3965883-1-kieran.bingham@ideasonboard.com>","References":"<20230227204254.3965883-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] ipa: libipa: Add OV2685 Camera Sensor\n\tHelper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide a CameraSensorHelper for the OV2685, along with the\ncorresponding camera sensor properties.\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++\n 2 files changed, 25 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 7977d7eb6c07..d1051cc25656 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -450,6 +450,17 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n \n+class CameraSensorHelperOv2685 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperOv2685()\n+\t{\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 1, 0, 0, 128 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"ov2685\", CameraSensorHelperOv2685)\n+\n class CameraSensorHelperOv2740 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex b8c532699684..7652c5f3e24c 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -133,6 +133,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n \t\t\t},\n \t\t} },\n+\t\t{ \"ov2685\", {\n+\t\t\t.unitCellSize = { 1750, 1750 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1},\n+\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 2 },\n+\t\t\t\t/*\n+\t\t\t\t * Also exposed by the driver:\n+\t\t\t\t * - OV2685_TEST_PATTERN_RANDOM,\n+\t\t\t\t * - OV2685_TEST_PATTERN_BW_SQUARE,\n+\t\t\t\t * - OV2685_TEST_PATTERN_COLOR_SQUARE,\n+\t\t\t\t */\n+\t\t\t},\n+\t\t} },\n \t\t{ \"ov2740\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n \t\t\t.testPatternModes = {\n","prefixes":["libcamera-devel","1/2"]}