{"id":18288,"url":"https://patchwork.libcamera.org/api/1.1/patches/18288/?format=json","web_url":"https://patchwork.libcamera.org/patch/18288/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230220074352.1221623-1-matthias.fend@emfend.at>","date":"2023-02-20T07:43:52","name":"[libcamera-devel] libcamera: keep using syslog logging target also for isolated IPA modules","commit_ref":"dbe96a2a6b130f7a3ffa1ad037b96cbbd7514956","pull_url":null,"state":"accepted","archived":false,"hash":"3de6907f91acc2ae0929fa8763903bfb4af5ef8f","submitter":{"id":134,"url":"https://patchwork.libcamera.org/api/1.1/people/134/?format=json","name":"Matthias Fend","email":"matthias.fend@emfend.at"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18288/mbox/","series":[{"id":3759,"url":"https://patchwork.libcamera.org/api/1.1/series/3759/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3759","date":"2023-02-20T07:43:52","name":"[libcamera-devel] libcamera: keep using syslog logging target also for isolated IPA modules","version":1,"mbox":"https://patchwork.libcamera.org/series/3759/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18288/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18288/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A7FCBE080\n\tfor ;\n\tMon, 20 Feb 2023 07:44:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8001262605;\n\tMon, 20 Feb 2023 08:44:00 +0100 (CET)","from lx20.hoststar.hosting (lx20.hoststar.hosting [168.119.41.54])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA68761EE3\n\tfor ;\n\tMon, 20 Feb 2023 08:43:58 +0100 (CET)","from 194-208-208-245.tele.net ([194.208.208.245]:58851\n\thelo=localhost.localdomain)\n\tby lx20.hoststar.hosting with esmtpsa (TLS1.3) tls\n\tTLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93)\n\t(envelope-from ) id 1pU0q5-0023hs-OI\n\tfor libcamera-devel@lists.libcamera.org;\n\tMon, 20 Feb 2023 08:43:58 +0100"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676879040;\n\tbh=f45dz8v9MynZz8+VRJvUOnyv645czI1HEYmLCjNTbos=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=tMe/xLmgrPiEQcowAwbmyfdJVXD/X+UFfT91YI0Od1N9mUblaK3LcRw0PC5TFt1AD\n\tt7kNkzimozfm90O6il7RaouwAv/2T5b2WXxW86vcZklctLEFtywXitZyqbulNT5XV3\n\tLMy+NMSQOZi9sIHGwndc3FBaahrgk5JMSaf+RRS7paWp5zr4olG/++6SvwWMgjJqjm\n\tg0de0oPKdLOmMCN/7iedlJLQ4apm3391f/pQj1PrmSTlDWDiVeArNrR7YQ2NrC8JIp\n\tcG9BOLBGOgnc0lMHXBZ4BdaHk2j3hBJV7bbzEXZ/i+8E79WlzRe6j5Dv4NfUZgB5fA\n\ttXooRr32ikthA==","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=emfend.at;\n\ts=mail;\n\th=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:\n\tFrom:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=RoieJowT7tMojEgNKe3onMHeu1m+OKtKPMjEFBH77/g=;\n\tb=EfbLXxbgplWYzeBdzj6FFyjs08\n\tJCLoREQC+FM/f8gNi7P238jkpgY/863RLyMMHZDjErX6/xkvi5UTDHcsEvh78yUs3lOUe+9Nhqn6y\n\tlt3U0bNLfthzPDNkEsz2XRh4gib/uX568zIN+IuxsYkVwe3sU66O9MS0ub7w2i6tQgno=;"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=emfend.at header.i=@emfend.at\n\theader.b=\"EfbLXxbg\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Feb 2023 08:43:52 +0100","Message-Id":"<20230220074352.1221623-1-matthias.fend@emfend.at>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Score":"","X-Spam-Bar":"","X-Spam-Report":"","Subject":"[libcamera-devel] [PATCH] libcamera: keep using syslog logging\n\ttarget also for isolated IPA modules","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Matthias Fend via libcamera-devel ","Reply-To":"Matthias Fend ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Currently it is not possible to display debug output from an isolated IPA\nmodule. The standard descriptors are all closed and any specified log\nfile is explicitly deactivated for the IPA module. Since libcamera and the\nisolated IPA modul are separate processes, they cannot write to the same\nfile. However, if syslog is used, then this would be possible.\n\nIf syslog is specified as a log file, then this is left as it is for the\nisolated IPA module.\n\nSigned-off-by: Matthias Fend \n---\n src/libcamera/process.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 0e6b4e1d..86a382fb 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -263,7 +263,9 @@ int Process::start(const std::string &path,\n \n \t\tcloseAllFdsExcept(fds);\n \n-\t\tunsetenv(\"LIBCAMERA_LOG_FILE\");\n+\t\tconst char *file = utils::secure_getenv(\"LIBCAMERA_LOG_FILE\");\n+\t\tif (file && strcmp(file, \"syslog\"))\n+\t\t\tunsetenv(\"LIBCAMERA_LOG_FILE\");\n \n \t\tconst char **argv = new const char *[args.size() + 2];\n \t\tunsigned int len = args.size();\n","prefixes":["libcamera-devel"]}