{"id":18258,"url":"https://patchwork.libcamera.org/api/1.1/patches/18258/?format=json","web_url":"https://patchwork.libcamera.org/patch/18258/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230206170356.20340-5-laurent.pinchart@ideasonboard.com>","date":"2023-02-06T17:03:56","name":"[libcamera-devel,v1,4/4] pipeline: raspberrypi: Drop unused code","commit_ref":"3aa42f36c0d7de48e267b6505158ab1e89374285","pull_url":null,"state":"accepted","archived":false,"hash":"95bba5b8d568385897612ae91b642eb5379ae1d6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18258/mbox/","series":[{"id":3740,"url":"https://patchwork.libcamera.org/api/1.1/series/3740/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3740","date":"2023-02-06T17:03:52","name":"Misc fixes for transformation handling","version":1,"mbox":"https://patchwork.libcamera.org/series/3740/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18258/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18258/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C287CC324D\n\tfor ;\n\tMon, 6 Feb 2023 17:04:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77D02625FF;\n\tMon, 6 Feb 2023 18:04:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6352C61EF6\n\tfor ;\n\tMon, 6 Feb 2023 18:04:03 +0100 (CET)","from pendragon.ideasonboard.com (unknown [109.136.43.56])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 117144DA\n\tfor ;\n\tMon, 6 Feb 2023 18:04:03 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675703044;\n\tbh=mhAXj3ZJoUvv57m/BjNK7q+eRy5lZd9dn4NUX+9gsCw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=NydW+nF1nPmAwTIpqm8I1Zw5d8D8Rw99/E0cVgTK2cJ6iEMl1LjabzQ4+4vZ3ss7X\n\ti9RFwcJBIIE+ZOu/gyqyL9BvtAgzM27jXCD4SBQGyqH+G4h7tnpQlJkeF5wFmcFXQ5\n\tc0h81R0PseCo86N8DEu3iZJ1QLtCYlvDnQxLpR9VLgIyUJ2hilIKIW+XcjJv7E1hD7\n\t9NWotVZM9/9jHY6VOkq7530bknos9Moy+Hrcgu/EGjI0nuQGW9k/HmgLtMCS6Z2WJu\n\tISB2GEed/FIIMJYzerAa88swAUtEkXub3R66Td+FGZ1kQSbGnjuxLdEwtgAFW7b3cV\n\tkRUNIZXaoITig==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675703043;\n\tbh=mhAXj3ZJoUvv57m/BjNK7q+eRy5lZd9dn4NUX+9gsCw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=FUrBXjSJLWT6NC2wDNP7OyxXwP0VfgvkhxEFdy5Hk2BnNldFZLSaMRdJDnXVXUbCD\n\tNYwp9ab+PIexVPJbncLMwQdyXeOZhkD8yhb2Bkp0f+dQ6J9Ql02qFgvG2Vx2MVNuGV\n\tW+74iO3RFZu04YP8zeQUbtDUlUCmxtEqIUw6BRx4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FUrBXjSJ\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 6 Feb 2023 19:03:56 +0200","Message-Id":"<20230206170356.20340-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.39.1","In-Reply-To":"<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>","References":"<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 4/4] pipeline: raspberrypi: Drop unused\n\tcode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Commit 1a614866a29c (\"libcamera: camera_sensor: Validate Transform\") has\nremoved usage of the RPiCameraData::supportsFlips_ but hasn't removed\nthe field itself, nor its initialization. Drop those as they're unused.\n\nFixes: 1a614866a29c (\"libcamera: camera_sensor: Validate Transform\")\nSigned-off-by: Laurent Pinchart \n---\n .../pipeline/raspberrypi/raspberrypi.cpp | 21 +++++++------------\n 1 file changed, 8 insertions(+), 13 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex d752911ddfff..77e860ab0e72 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -187,8 +187,8 @@ class RPiCameraData : public Camera::Private\n public:\n \tRPiCameraData(PipelineHandler *pipe)\n \t\t: Camera::Private(pipe), state_(State::Stopped),\n-\t\t supportsFlips_(false), flipsAlterBayerOrder_(false),\n-\t\t dropFrameCount_(0), buffersAllocated_(false), ispOutputCount_(0)\n+\t\t flipsAlterBayerOrder_(false), dropFrameCount_(0),\n+\t\t buffersAllocated_(false), ispOutputCount_(0)\n \t{\n \t}\n \n@@ -275,11 +275,9 @@ public:\n \tstd::deque requestQueue_;\n \n \t/*\n-\t * Manage horizontal and vertical flips supported (or not) by the\n-\t * sensor. Also store the \"native\" Bayer order (that is, with no\n-\t * transforms applied).\n+\t * Store the \"native\" Bayer order (that is, with no transforms\n+\t * applied).\n \t */\n-\tbool supportsFlips_;\n \tbool flipsAlterBayerOrder_;\n \tBayerFormat::Order nativeBayerOrder_;\n \n@@ -1424,12 +1422,10 @@ int PipelineHandlerRPi::registerCamera(MediaDevice *unicam, MediaDevice *isp, Me\n \tdata->properties_.set(properties::ScalerCropMaximum, Rectangle{});\n \n \t/*\n-\t * We cache three things about the sensor in relation to transforms\n-\t * (meaning horizontal and vertical flips).\n-\t *\n-\t * If flips are supported verify if they affect the Bayer ordering\n-\t * and what the \"native\" Bayer order is, when no transforms are\n-\t * applied.\n+\t * We cache two things about the sensor in relation to transforms\n+\t * (meaning horizontal and vertical flips): if they affect the Bayer\n+\t * ordering, and what the \"native\" Bayer order is, when no transforms\n+\t * are applied.\n \t *\n \t * We note that the sensor's cached list of supported formats is\n \t * already in the \"native\" order, with any flips having been undone.\n@@ -1438,7 +1434,6 @@ int PipelineHandlerRPi::registerCamera(MediaDevice *unicam, MediaDevice *isp, Me\n \tconst struct v4l2_query_ext_ctrl *hflipCtrl = sensor->controlInfo(V4L2_CID_HFLIP);\n \tif (hflipCtrl) {\n \t\t/* We assume it will support vflips too... */\n-\t\tdata->supportsFlips_ = true;\n \t\tdata->flipsAlterBayerOrder_ = hflipCtrl->flags & V4L2_CTRL_FLAG_MODIFY_LAYOUT;\n \t}\n \n","prefixes":["libcamera-devel","v1","4/4"]}