{"id":18216,"url":"https://patchwork.libcamera.org/api/1.1/patches/18216/?format=json","web_url":"https://patchwork.libcamera.org/patch/18216/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230128162402.892389-1-luca@z3ntu.xyz>","date":"2023-01-28T16:24:03","name":"[libcamera-devel] qcam: Decrease minimum width of selector dialog","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"abb17e33abceea92280a9cbb1ec8d3d4722075e6","submitter":{"id":147,"url":"https://patchwork.libcamera.org/api/1.1/people/147/?format=json","name":"Luca Weiss","email":"luca@z3ntu.xyz"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18216/mbox/","series":[{"id":3729,"url":"https://patchwork.libcamera.org/api/1.1/series/3729/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3729","date":"2023-01-28T16:24:03","name":"[libcamera-devel] qcam: Decrease minimum width of selector dialog","version":1,"mbox":"https://patchwork.libcamera.org/series/3729/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18216/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18216/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7945BEFBE\n\tfor ;\n\tSat, 28 Jan 2023 20:50:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6A23625E4;\n\tSat, 28 Jan 2023 21:50:32 +0100 (CET)","from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED84860430\n\tfor ;\n\tSat, 28 Jan 2023 17:24:50 +0100 (CET)","from g550jk.arnhem.chello.nl (unknown [62.108.10.64])\n\tby mail.z3ntu.xyz (Postfix) with ESMTPSA id 3E071C3FEB;\n\tSat, 28 Jan 2023 16:24:20 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674939033;\n\tbh=OSPQX4oZYGKbc9i4Pa2LPcYoiknvlj6WzE/hZphcGGo=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=OBI6rWHRHwr0jayRPQQsfwTEs0tPDZhB3PiWx5slSaUlGD3zRdIkkgPTlGZfz55ra\n\tmkQAWs7oUKIGe6TPunHO+SHq8fBJ1v9XnhSCUF1z1S9hENaMFuiLltDwSmfexNx1wV\n\tyjWgWcfHU3waIzT2Q2kLSRj/RVHFqelL3iWbZZbyTlOTeSPtYayD8Is3RK7UvxOe0L\n\tJIGDT832bJKlVB6wxcv44ZWAIbX1jMCUcxk6CBLQx9BbmaZfT5TLEJBgPWOwZAVi26\n\t8HR5tFo6v7ThP9gDkasP9a9IyFYxybPa2uF8xZp4FPZ82vl+ukAUFytcgnAevF5c4y\n\tTTvoDC9iA/lsQ==","v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu;\n\tt=1674923060; bh=OSPQX4oZYGKbc9i4Pa2LPcYoiknvlj6WzE/hZphcGGo=;\n\th=From:To:Cc:Subject:Date;\n\tb=XYvcI+BgPlvY+SIomV2d0rcXaYxF4H5FE2tM5MKtVI13Te05LG+PIqEK0nvIV8qhX\n\tCjyZOf82hUNgYGMb+AcGD6ebIumG79DtUc2rk0UVLZhCZ4qzoinULGVzpDBgPujIF0\n\tlOKFShXay3oNIBQVS2d8dt0inFTPjH2ESCJ/P2Ic="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=z3ntu.xyz header.i=@z3ntu.xyz\n\theader.b=\"XYvcI+Bg\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 28 Jan 2023 17:24:03 +0100","Message-Id":"<20230128162402.892389-1-luca@z3ntu.xyz>","X-Mailer":"git-send-email 2.39.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Sat, 28 Jan 2023 21:50:30 +0100","Subject":"[libcamera-devel] [PATCH] qcam: Decrease minimum width of selector\n\tdialog","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Luca Weiss via libcamera-devel ","Reply-To":"Luca Weiss ","Cc":"Luca Weiss ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"On phone screens the default width is too wide, so the OK button cannot\nbe clicked.\n\nFix this by decreasing the minimum size of the dialog so it fits nicely.\n\nSigned-off-by: Luca Weiss \n---\n src/apps/qcam/cam_select_dialog.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/apps/qcam/cam_select_dialog.cpp b/src/apps/qcam/cam_select_dialog.cpp\nindex 3c8b12a9..2a600383 100644\n--- a/src/apps/qcam/cam_select_dialog.cpp\n+++ b/src/apps/qcam/cam_select_dialog.cpp\n@@ -25,6 +25,9 @@ CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager *cameraManag\n \t/* Use a QFormLayout for the dialog. */\n \tQFormLayout *layout = new QFormLayout(this);\n \n+\t/* Decrease minimum width of dialog to fit on narrow screens */\n+\tsetMinimumSize(250, 100);\n+\n \t/* Setup the camera id combo-box. */\n \tcameraIdComboBox_ = new QComboBox;\n \tfor (const auto &cam : cm_->cameras())\n","prefixes":["libcamera-devel"]}