{"id":18193,"url":"https://patchwork.libcamera.org/api/1.1/patches/18193/?format=json","web_url":"https://patchwork.libcamera.org/patch/18193/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230124233624.2058-1-laurent.pinchart@ideasonboard.com>","date":"2023-01-24T23:36:24","name":"[libcamera-devel] py: Drop redundant std::move()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9fbb3fab9d9e26cb93cc27b571682474dc482efd","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18193/mbox/","series":[{"id":3723,"url":"https://patchwork.libcamera.org/api/1.1/series/3723/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3723","date":"2023-01-24T23:36:24","name":"[libcamera-devel] py: Drop redundant std::move()","version":1,"mbox":"https://patchwork.libcamera.org/series/3723/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18193/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18193/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B786BDB1D\n\tfor ;\n\tTue, 24 Jan 2023 23:36:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7409625E4;\n\tWed, 25 Jan 2023 00:36:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C010D603C7\n\tfor ;\n\tWed, 25 Jan 2023 00:36:29 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 123B46D0;\n\tWed, 25 Jan 2023 00:36:29 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674603391;\n\tbh=QgfwCjPT96MLrsXgB7tYfPYX77ucvKS6qSKqnonuY4U=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=KCtcJtqstTuglkq0ZvF7A6Et29m74GflNxLhzXnldlgL8+eQyrqEtVy+VVRmY+m98\n\tTSRkZlkJnjc0z40LF1ZQj9hVtM8zcnjOGGNFm29SEUTLAyit+X0tdy33upVY1cTBC2\n\tcs0xkhebiRqSyHOhhBn+6KIwuilAmucP0rnA4IYyJi3Bvt4QfKMzTgDKgVtuVgcPs6\n\tM9ezsqQ1yoLiS1DlLc6EmYU+Ye3Gw5dxvBM0M1ZCs2aAWOk5o1L5dwEuWTcxOVaywt\n\ty8dXdcgh/C3rIu7On2M/8mt+TpTDs/EYba+hD/eQdRcBAgHpx6nDke/MR/FrUOHZpB\n\tIUvJu3iU4qOcQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674603389;\n\tbh=QgfwCjPT96MLrsXgB7tYfPYX77ucvKS6qSKqnonuY4U=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Xh/me29JA0x1G6wIAn/iVyjDln3AZf4uH+a+326FICRFHAO1TQZ7UzSGV2RKLwYW5\n\tB/mnj3MwRGRPlNdIeqBmi3i+MpUMGepbT9rurBVqp5dC1kZZ3B6TUqwFISLfSyDXFf\n\tOUE5mXU1oiFVzkjr+oGSOaIWJMxSfwRppYgJ/d6M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Xh/me29J\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 25 Jan 2023 01:36:24 +0200","Message-Id":"<20230124233624.2058-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.39.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] py: Drop redundant std::move()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"gcc-13 warns that the valueOrTuple() function has a redundant\nstd::move() in a return statement:\n\n../../src/py/libcamera/py_helpers.cpp: In instantiation of ‘pybind11::object valueOrTuple(const libcamera::ControlValue&) [with T = bool]’:\n../../src/py/libcamera/py_helpers.cpp:38:28: required from here\n../../src/py/libcamera/py_helpers.cpp:28:35: error: redundant move in return statement [-Werror=redundant-move]\n 28 | return std::move(t);\n\nDrop it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/py/libcamera/py_helpers.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 13986d6ce3ab64c44a8f086ef8942f56bbedff63\nprerequisite-patch-id: f6a3b225240a9069104d326be29ae2451ba8e9f0\nprerequisite-patch-id: 8d95f21764dd480d4197b573e213721a7b6dae42\nprerequisite-patch-id: 7eff091a4898b00438bac219873379769811c391","diff":"diff --git a/src/py/libcamera/py_helpers.cpp b/src/py/libcamera/py_helpers.cpp\nindex 79891ab63862..5bedea047e31 100644\n--- a/src/py/libcamera/py_helpers.cpp\n+++ b/src/py/libcamera/py_helpers.cpp\n@@ -25,7 +25,7 @@ static py::object valueOrTuple(const ControlValue &cv)\n \t\tfor (size_t i = 0; i < cv.numElements(); ++i)\n \t\t\tt[i] = v[i];\n \n-\t\treturn std::move(t);\n+\t\treturn t;\n \t}\n \n \treturn py::cast(cv.get());\n","prefixes":["libcamera-devel"]}