{"id":18174,"url":"https://patchwork.libcamera.org/api/1.1/patches/18174/?format=json","web_url":"https://patchwork.libcamera.org/patch/18174/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230123140619.177878-5-mike.rudenko@gmail.com>","date":"2023-01-23T14:06:19","name":"[libcamera-devel,v2,4/4] ipa: rkisp1: Raise maximum analogue gain","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ac72192e1b0e80758ce8164e5486bd6f89ef0a1d","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/1.1/people/146/?format=json","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18174/mbox/","series":[{"id":3718,"url":"https://patchwork.libcamera.org/api/1.1/series/3718/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3718","date":"2023-01-23T14:06:15","name":"Add Omnivision OV4689 support","version":2,"mbox":"https://patchwork.libcamera.org/series/3718/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18174/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18174/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40C5ABEFBE\n\tfor ;\n\tMon, 23 Jan 2023 14:06:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EFACB625EF;\n\tMon, 23 Jan 2023 15:06:38 +0100 (CET)","from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com\n\t[IPv6:2a00:1450:4864:20::22e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A22D7625D8\n\tfor ;\n\tMon, 23 Jan 2023 15:06:36 +0100 (CET)","by mail-lj1-x22e.google.com with SMTP id y18so13186439ljk.11\n\tfor ;\n\tMon, 23 Jan 2023 06:06:36 -0800 (PST)","from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125])\n\tby smtp.gmail.com with ESMTPSA id\n\tk20-20020a2eb754000000b00287eb396f27sm4463926ljo.7.2023.01.23.06.06.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 23 Jan 2023 06:06:35 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674482799;\n\tbh=DLekmU5YxUdpDQJaNMa/zEFiFDOu+7zfKc3VjzXgj3I=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=4a9Cmo+l+lCpCAQ2Hioyljlb4TkKjsRONob1ved3iRICy2+tJdIwJEnrkGx+r88Pb\n\tiX1HUH3vXYb33Z+7h+zk0MIeE3czXmi9CFn1N79JEKaGszLfDO29aSieoOGQ5lJbAZ\n\tVYZvjMzoO2JzWp+0eYQ0/gnS/5OVhUGZSO2rNicXL5y5qcpa9bSRIQtSdhy3vbHwE9\n\tO4Z94qwEwJhq+CsrrBjknMVXTgdGXA1U4EKU3G2ZdtuNr2uKm9gtT1pihN2mkwAdnD\n\t1Y6Txlz3+1O+yE2g144dXy3BuB/gOYPzsCMuajB2ZZJdnqDV0kgDL8gIXY7RJrwUHD\n\tG1pZVHuO07Txw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=N+q4oXWlN7tVgrlEigWQgWnFoiDOaEvPc0hFBSvDfyE=;\n\tb=YVRx/k2QtubRnUjXDoGPztuA64o1KpqQ59yWfDVLMYIEC7NPeXVfNbBTVhjf5OvDBl\n\trH+e8wfxKJ6lEI5RcS87txSOE0EhqJqZEvOu95wCLXlHZDyOaAQomH+JA8HZAF5rZ1Jn\n\tig7PwN/bLC+zsVPn+MIcgDaYZNO4p7CfEJq/nqAof3Hlp0w44Gg7f0KGesDMmgu4KVpt\n\tjDbP2annVxpLETQcS25WW4nzqwKVBvSLqxXyjFSJ+Xo2Pskc6j+zS112ROMKZWEcTblc\n\taty15C4WuLE6pyBh4VUr3CPHMbugB8+wjhZ1cyZVD4X4c8XhTSHmYhAI95MC/k3CMb0T\n\t0Swg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"YVRx/k2Q\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=N+q4oXWlN7tVgrlEigWQgWnFoiDOaEvPc0hFBSvDfyE=;\n\tb=QVbBZUGfGo1eCAVYcPlZ+ly2FlYOPX6vX7E4xcjYc8QwVZKIVzEkTz4ZRIocEpXPqw\n\tEBqQqwW/pRBLbF4lLQ/dTpY3r/2oZmqXbcUDZ1bDFuzx4eFkfLyz1J1+9dV0glXO7ixb\n\tXVt7X12A0kwuaCAVFRUIflyjuJVqCLcBk8SzoQbiyjhE//tj1yumADqBvGljHvE9I0l7\n\t9DsBOEayh6sAnWQ7BZuzAQE26Rq2x30c/zoDUnpKxOoBWv7RqqY4OUZUxwrGs3ko8Ce9\n\tS8+5xrDzIXAnkp5Qk1Hfr/FSzOB8vL2KZs2PlEO0wNco05iIxbs7KbzbnqFVSq6t+mrb\n\tE+HA==","X-Gm-Message-State":"AFqh2kogmEAekZu4M2xUOCxT6N7VlYn6NqWV2LUNV+skQAmM+piWN6kv\n\tcLlkmTudH/ifhocGKL30hpaQooadIkc=","X-Google-Smtp-Source":"AMrXdXuNvvXc9PpIY08j9oU2ij6DmmcGqLWg7XJVV+8wtkVBaa+G8YQCNw+QeKtLHyOB7H9iR4UZiw==","X-Received":"by 2002:a2e:bc25:0:b0:27f:bedc:6f09 with SMTP id\n\tb37-20020a2ebc25000000b0027fbedc6f09mr8004246ljf.7.1674482795678; \n\tMon, 23 Jan 2023 06:06:35 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Jan 2023 17:06:19 +0300","Message-Id":"<20230123140619.177878-5-mike.rudenko@gmail.com>","X-Mailer":"git-send-email 2.39.1","In-Reply-To":"<20230123140619.177878-1-mike.rudenko@gmail.com>","References":"<20230123140619.177878-1-mike.rudenko@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 4/4] ipa: rkisp1: Raise maximum\n\tanalogue gain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mikhail Rudenko via libcamera-devel\n\t","Reply-To":"Mikhail Rudenko ","Cc":"Mikhail Rudenko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Omnivision OV4689 sensor driver exposes maximum analogue gain of\n16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can\nbe used.\n\nSigned-off-by: Mikhail Rudenko \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex e3470e25..e4cb2fc7 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -38,7 +38,7 @@ LOG_DEFINE_CATEGORY(RkISP1Agc)\n \n /* Limits for analogue gain values */\n static constexpr double kMinAnalogueGain = 1.0;\n-static constexpr double kMaxAnalogueGain = 8.0;\n+static constexpr double kMaxAnalogueGain = 16.0;\n \n /* \\todo Honour the FrameDurationLimits control instead of hardcoding a limit */\n static constexpr utils::Duration kMaxShutterSpeed = 60ms;\n","prefixes":["libcamera-devel","v2","4/4"]}