{"id":18116,"url":"https://patchwork.libcamera.org/api/1.1/patches/18116/?format=json","web_url":"https://patchwork.libcamera.org/patch/18116/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230114194712.23272-6-jacopo.mondi@ideasonboard.com>","date":"2023-01-14T19:47:12","name":"[libcamera-devel,v2,5/5] documentation: sensor_drivers: Document H/V flip","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1bab904b2322d9c7be473ad2f08557087a98f104","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18116/mbox/","series":[{"id":3711,"url":"https://patchwork.libcamera.org/api/1.1/series/3711/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3711","date":"2023-01-14T19:47:07","name":"libcamera: camera_sensor: Centralize flips handling","version":2,"mbox":"https://patchwork.libcamera.org/series/3711/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18116/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18116/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63D5CC3295\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 14 Jan 2023 19:47:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3E2E625F6;\n\tSat, 14 Jan 2023 20:47:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63115625E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 14 Jan 2023 20:47:27 +0100 (CET)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77DE54DD;\n\tSat, 14 Jan 2023 20:47:26 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1673725651;\n\tbh=7Y5lZedw3sQCQu5BnIQLNkw7XghiBC6Se9sQDo5K4PU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=28L9Fv7MnYdvrwuBoD0zue0O61sZCZ0op9rtiSfX9hQjaDWtK/yS5KCnjnbTQxTqo\n\tnDOCXWyitTZVea4MuzY243x1V+G87GCeXhoJtfDIRfKLZ/tSQ8gMtArqFkF8Ukpg95\n\tSxWHEqXdW0kfI8/NV2XZF+vbr9Gl7K4Ke7SuFU9QtTiXufCzlyiu6nnCJghRd/33hG\n\tIn78U7wY5lUG5gWMzK7rlSYBxFKDcaawP1eb9CxuEWQWRDi5NRIm0kg74Szfo/+sYP\n\tfhR4FZZ7O5svWSNuo4hSOCwkcRRCgdHxDuqUZPJyOQDDrOip5NgzhoJGScwcb9OiK0\n\tEMjSrwJxN3F9g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1673725646;\n\tbh=7Y5lZedw3sQCQu5BnIQLNkw7XghiBC6Se9sQDo5K4PU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=u4/1hqeot/o7PGNmPBXs0X1n99YLNZHETzqnQJNt3gsCu3/dao7zF3ElXnPHyspVr\n\tFFxeGwLousnG2o9bYL536kJ7/jNCz4crvLRB3jXDw79Wbl9sf9KiZutojqqLhindom\n\tkLoyTIMDKhSuC5euy+XBCkNHcTbclNBd52K3Uk2k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"u4/1hqeo\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 14 Jan 2023 20:47:12 +0100","Message-Id":"<20230114194712.23272-6-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.39.0","In-Reply-To":"<20230114194712.23272-1-jacopo.mondi@ideasonboard.com>","References":"<20230114194712.23272-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/5] documentation: sensor_drivers:\n\tDocument H/V flip","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Briefly document the optional requirement support for H/V flip controls.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n Documentation/sensor_driver_requirements.rst | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst\nindex 3abc8f35924a..0e516b34a215 100644\n--- a/Documentation/sensor_driver_requirements.rst\n+++ b/Documentation/sensor_driver_requirements.rst\n@@ -62,6 +62,18 @@ The sensor driver should support the following V4L2 controls:\n \n The controls are used to register the camera location and rotation.\n \n+In order to support rotating the image the sensor driver should support\n+\n+* `V4L2_CID_HFLIP`_\n+* `V4L2_CID_VFLIP`_\n+\n+.. _V4L2_CID_HFLIP: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html\n+.. _V4L2_CID_VFLIP: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html\n+\n+The controls must be writable from userspace. In case of a RAW Bayer sensors,\n+drivers should correctly report if vertical/horizontal flips modify the Bayer\n+pattern ordering by reporting the `V4L2_CTRL_FLAG_MODIFY_LAYOUT` control flag.\n+\n The sensor driver should implement support for the V4L2 Selection API,\n specifically it should implement support for the\n `VIDIOC_SUBDEV_G_SELECTION`_ ioctl with support for the following selection\n","prefixes":["libcamera-devel","v2","5/5"]}