{"id":18112,"url":"https://patchwork.libcamera.org/api/1.1/patches/18112/?format=json","web_url":"https://patchwork.libcamera.org/patch/18112/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230114194712.23272-2-jacopo.mondi@ideasonboard.com>","date":"2023-01-14T19:47:08","name":"[libcamera-devel,v2,1/5] libcamera: camera_sensor: Verify flips support","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"514dc52a842ec33989729766596334233592e438","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18112/mbox/","series":[{"id":3711,"url":"https://patchwork.libcamera.org/api/1.1/series/3711/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3711","date":"2023-01-14T19:47:07","name":"libcamera: camera_sensor: Centralize flips handling","version":2,"mbox":"https://patchwork.libcamera.org/series/3711/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18112/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18112/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AEA1AC3240\n\tfor ;\n\tSat, 14 Jan 2023 19:47:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5F4C625E7;\n\tSat, 14 Jan 2023 20:47:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03368625D0\n\tfor ;\n\tSat, 14 Jan 2023 20:47:25 +0100 (CET)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 289BF4DD;\n\tSat, 14 Jan 2023 20:47:24 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1673725647;\n\tbh=fcPrR1vBAffWHMMstDC1JL0aPnhAGq2eJMsR3VGqptU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0+6gIbtBYdTRmzM+2KsZ5pis7HEfzprh0jFkv3khKHufPR5F3QlODb8RnDtd+LBpq\n\tlYyT1zTb8WAv7mz6llKi2o057qf7ra1vqNgED1Dr1DjiOH9JY5WSWm+BLJ5lSoFIcx\n\tiULOlJhhKrKFbWfu5jIeRebMSVkNfc1wcn4UQfWZN6KWSTAcT7DkX8wvTj6X5c+jWF\n\tctfh1VzRfn+AtulKA1IhbcmhR/Z+iWx0OFmEDSVMpu4t4ojjjrvkgDCaRpc/qTSv2u\n\tVmgg//+JzQoEz9RLLBy9WN0vB79HqdzjSefx4p4NebcPC4KRjrMkdlL49krpQ3p16m\n\tM/k1qFCHrd7aw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1673725644;\n\tbh=fcPrR1vBAffWHMMstDC1JL0aPnhAGq2eJMsR3VGqptU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cRmJZqbgQgCqoik5uGqxtT5dgkdadR75d8lOS/dbyIM58nl12K2g+1jvTsRc4WEzj\n\t9WhnqLkE/bgxeKYZeH74EvVzJ2AKSn/2Km+zLQHVthmm2WOU12fdciOf2u3CsBniPX\n\twIWWvIMWSKdiOg5cOHRBktedhpDDb2acDWwee03E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cRmJZqbg\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 14 Jan 2023 20:47:08 +0100","Message-Id":"<20230114194712.23272-2-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.39.0","In-Reply-To":"<20230114194712.23272-1-jacopo.mondi@ideasonboard.com>","References":"<20230114194712.23272-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/5] libcamera: camera_sensor: Verify\n\tflips support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"During the camera sensor driver validation, verify if the sensor\nsupports horizontal and vertical flips and store a flag as\nCameraSensor::supportFlips_ class member.\n\nThe flag will be later inspected when applying flips.\n\nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/internal/camera_sensor.h | 1 +\n src/libcamera/camera_sensor.cpp | 18 +++++++++++++++++-\n 2 files changed, 18 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex b9f4d7867854..878f3c28a3c9 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -101,6 +101,7 @@ private:\n \tSize pixelArraySize_;\n \tRectangle activeArea_;\n \tconst BayerFormat *bayerFormat_;\n+\tbool supportFlips_;\n \n \tControlList properties_;\n \ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex a210aa4fa370..83ac075a4265 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -55,7 +55,8 @@ LOG_DEFINE_CATEGORY(CameraSensor)\n */\n CameraSensor::CameraSensor(const MediaEntity *entity)\n \t: entity_(entity), pad_(UINT_MAX), staticProps_(nullptr),\n-\t bayerFormat_(nullptr), properties_(properties::properties)\n+\t bayerFormat_(nullptr), supportFlips_(false),\n+\t properties_(properties::properties)\n {\n }\n \n@@ -247,6 +248,21 @@ int CameraSensor::validateSensorDriver()\n \t\t}\n \t}\n \n+\t/*\n+\t * Verify if sensor supports horizontal/vertical flips\n+\t *\n+\t * \\todo Handle horizontal and vertical flips independently.\n+\t */\n+\tconst struct v4l2_query_ext_ctrl *hflipInfo = subdev_->controlInfo(V4L2_CID_HFLIP);\n+\tconst struct v4l2_query_ext_ctrl *vflipInfo = subdev_->controlInfo(V4L2_CID_VFLIP);\n+\tif (hflipInfo && !(hflipInfo->flags & V4L2_CTRL_FLAG_READ_ONLY) &&\n+\t vflipInfo && !(vflipInfo->flags & V4L2_CTRL_FLAG_READ_ONLY))\n+\t\tsupportFlips_ = true;\n+\n+\tif (!supportFlips_)\n+\t\tLOG(CameraSensor, Warning)\n+\t\t\t<< \"Camera sensor does not support horizontal/vertical flip\";\n+\n \t/*\n \t * Make sure the required selection targets are supported.\n \t *\n","prefixes":["libcamera-devel","v2","1/5"]}