{"id":1810,"url":"https://patchwork.libcamera.org/api/1.1/patches/1810/?format=json","web_url":"https://patchwork.libcamera.org/patch/1810/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190815122332.13717-1-laurent.pinchart@ideasonboard.com>","date":"2019-08-15T12:23:32","name":"[libcamera-devel] hal: Fix comparison of unsigned integer < 0","commit_ref":"a8b472598ebc7874651a92f6342c714c37b0f083","pull_url":null,"state":"accepted","archived":false,"hash":"d758f9631c64092d63a71dce054a134cfca0d29e","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1810/mbox/","series":[{"id":460,"url":"https://patchwork.libcamera.org/api/1.1/series/460/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=460","date":"2019-08-15T12:23:32","name":"[libcamera-devel] hal: Fix comparison of unsigned integer < 0","version":1,"mbox":"https://patchwork.libcamera.org/series/460/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1810/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1810/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 353B660E2D\n\tfor ;\n\tThu, 15 Aug 2019 14:23:39 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B45572AF\n\tfor ;\n\tThu, 15 Aug 2019 14:23:38 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565871818;\n\tbh=iv0rf0HRBOFv8EwwGcGPezFz0t7QYmxJ/VXPit81sQI=;\n\th=From:To:Subject:Date:From;\n\tb=PLZRR/kjgtE55XbqqWWgiK01A/iqhVzUK+Hq8to8jSwvgy+Z3hACM6VCowbBioVmE\n\t+1YFnTPGw4BCeov6rHWYUJZ70GE8ayG5mVJu54lYdsbB/304halz3ev8+Q/mT8yMh3\n\tvoPI+DN7fJVH2p4duRfpuG6CfRIk5JAzlOffpdUI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 15 Aug 2019 15:23:32 +0300","Message-Id":"<20190815122332.13717-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] hal: Fix comparison of unsigned integer <\n\t0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 15 Aug 2019 12:23:39 -0000"},"content":"The CameraHalManager::getCameraInfo() validates the camera id it\nreceives from the camera service, and in doing so generates a compiler\nerror as the id is an unsigned integer and can never be negative:\n\n../src/android/camera_hal_manager.cpp: In member function ‘CameraProxy* CameraHalManager::open(unsigned int, const hw_module_t*)’:\n../src/android/camera_hal_manager.cpp:89:9: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]\n if (id < 0 || id >= numCameras()) {\n\nFix it by removing the unneeded comparison.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/camera_hal_manager.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 1e66f63240da..37ba01355258 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -86,7 +86,7 @@ void CameraHalManager::run()\n CameraProxy *CameraHalManager::open(unsigned int id,\n \t\t\t\t const hw_module_t *hardwareModule)\n {\n-\tif (id < 0 || id >= numCameras()) {\n+\tif (id >= numCameras()) {\n \t\tLOG(HAL, Error) << \"Invalid camera id '\" << id << \"'\";\n \t\treturn nullptr;\n \t}\n","prefixes":["libcamera-devel"]}